Module talk:National squad

Template-protected edit request on 2 September 2020

It is requested that an edit be made to the template-protected module at Module:National squad.
(edit · history · last · links · sandbox · edit sandbox · sandbox history · sandbox last edit · sandbox diff · transclusion count · protection log)

This template must be followed by a complete and specific description of the request, so that an editor unfamiliar with the subject matter could complete the requested edit immediately.

Edit requests to template-protected pages should only be used for edits that are either uncontroversial or supported by consensus. If the proposed edit might be controversial, discuss it on the protected page's talk page before using this template. Consider making changes first to the module's sandbox before submitting an edit request. To request that a page be protected or unprotected, make a protection request. When the request has been completed or denied, please add the |answered=yes parameter to deactivate the template.

Implement Special:permalink/976342160 to wikilink sport specific article for compitation in title. It will be useful for this merger. Tested at Template:National squad no numbers/testcases (second testcase). → Timbaaa_talk 12:51, 2 September 2020 (UTC)[reply]

Timbaaa, do we know how many transclusions are not using |comp link=? this will potentially cause a change in the linking for all of them. For example, it would break the links in 1996 UEFA Futsal Championship squads, and Template:Bahrain squad 2007 AFC Asian Cup. Frietjes (talk) 15:30, 2 September 2020 (UTC)[reply]

Frietjes, Come to think of it, transclusion without |team link= is breaking team link in the title. In the same example 1996 UEFA Futsal Championship squads, all the links are to football squads as opposed to futsal squads.

In that case, for the merger to go on, |sport= has to be made a required parameter. And football be removed as default. → Timbaaa_talk 03:11, 3 September 2020 (UTC)[reply]

For what it's worth, I have a list of all templates using this module, divided by sport, at User:S.A. Julio/Squad navboxes. S.A. Julio (talk) 03:29, 3 September 2020 (UTC)[reply]

finding and fixing all of them seems like a large task (now tracking with Category:Pages using national squad without comp link). if this feature were "opt in" with |auto comp link=y or something, we wouldn't need to worry about fixing current uses. Frietjes (talk) 15:42, 2 September 2020 (UTC)[reply]

I think we have two issues

the sport parameter which was added in June 2020. if you check, before that in both the LUA and non-LUA versions, sport=football was "hard coded". the reason why the futsal links are wrong is because User:Primefac redirected the futsal template here but the transclusions were never updated. I simple bot or AWB run over the 400 or so transclusions to add |sport=futsal would fix that problem. however, I agree that making |sport= mandatory is a good idea in the longer term.
the proposed change would still break links even when |sport= is set properly in templates like Template:Bahrain squad 2007 AFC Asian Cup, which currently links to 2007 AFC Asian Cup but would link to the redundant Football at the 2007 AFC Asian Cup without either (a) explicitly adding |comp link= to all transclusions without it or (b) making this feature opt-in. Frietjes (talk) 14:55, 3 September 2020 (UTC)[reply]