Module talk:Main page image

Module:Main page image is permanently protected from editing because it is a heavily used or highly visible module. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit protected}} to notify an administrator to make the requested edit.

Calculate by area

ProcrastinatingReader, now that we have overcome the challenge of adoption. I wonder if there is not a better way of calculating size. The best way to calculate the image size is actually by area. Could you rewrite this module to calculate the width size that would return an image occupying a surface area equal to 140x140 = 19,600? Note, this is approximately the same size as 120x160 or 160x120 = 19,200. --- C&C (Coffeeandcrumbs) 15:37, 11 August 2020 (UTC)[reply]

Coffeeandcrumbs, sorry, I don't quite follow. How would this work? And what's the visible difference over the current way of doing it? And how would it know whether to be upright or not since both 120x160 and 160x120 are 19,200 pixels? ProcrastinatingReader (talk) 11:06, 12 August 2020 (UTC)[reply]

ProcrastinatingReader, I created Module:Main page image/sandbox to show how it could work. My hope is to address cases where the image is very wide or very tall. --- C&C (Coffeeandcrumbs) 17:25, 12 August 2020 (UTC)[reply]

ProcrastinatingReader Did you have a chance to review the new code in the sandbox. If you have no objections, I am going to make a request to implement it. --- C&C (Coffeeandcrumbs) 19:24, 13 August 2020 (UTC)[reply]

Coffeeandcrumbs, yes, sorry. I was fiddling around with how it would look with the TFA yesterday, see User:ProcrastinatingReader/sandbox3. Code wise it's fine. Functionality wise, I'd only note that a) it can result in varying widths (which I suppose is the point) and b) for some dimensions, like the example in sandbox, can be fairly small and result in the caption looking a bit messy (seems to vary for different browsers, looks worse in Safari than Chrome for me). ProcrastinatingReader (talk) 19:39, 13 August 2020 (UTC)[reply]

ProcrastinatingReader, I recommend you install User:SD0001/sandbox4.js. It will let you preview template changes on live pages without having to create such sandboxes.

As for your sandbox3, note that I manipulated that original TFA blurb using <br /> and width=x222. We will have to continue using your override feature to address such extreme cases. --- C&C (Coffeeandcrumbs) 19:59, 13 August 2020 (UTC)[reply]

Fair point. Code wise looks fine to me - good work, and nice formula! I've made a very small edit (since the variable is already declared). ProcrastinatingReader (talk) 20:07, 13 August 2020 (UTC)[reply]

Request

It is requested that an edit be made to the fully protected module at Module:Main page image.
(edit · history · last · links · sandbox · edit sandbox · sandbox history · sandbox last edit · sandbox diff · transclusion count · protection log)

This template must be followed by a complete and specific description of the request, so that an editor unfamiliar with the subject matter could complete the requested edit immediately.

Edit requests to fully protected pages should only be used for edits that are either uncontroversial or supported by consensus. If the proposed edit might be controversial, discuss it on the protected page's talk page before using this template. Consider making changes first to the module's sandbox before submitting an edit request. To request that a page be protected or unprotected, make a protection request. When the request has been completed or denied, please add the |answered=yes parameter to deactivate the template.

Please replace the current code with the version in the sandbox: Module:Main page image/sandbox. --- C&C (Coffeeandcrumbs) 20:23, 13 August 2020 (UTC)[reply]