Talk:Rust (programming language)/GA1
Appearance
GA Review
GA toolbox |
---|
Reviewing |
Article (edit | visual edit | history) · Article talk (edit | history) · Watch
Reviewer: Hawkeye7 (talk · contribs) 03:53, 14 July 2022 (UTC)
Picking this one up. Review to follow. Hawkeye7 (discuss) 03:53, 14 July 2022 (UTC)
Comments
Article looks in reasonable shape. Some work required.
- Lead
- Last paragraph of the lead is not covered in the body. I would move all but the first sentence into the body.
Done. 0xDeadbeef
- Last paragraph of the lead is not covered in the body. I would move all but the first sentence into the body.
- Early origins (2006–2012):
- Evolution (2013–2019)
- Mozilla Layoffs and Rust Foundation (2020–present)
- Hello, World program
- Should we mention that the bang indicates a macro instead of a function?
Done. 0xDeadbeef
- Should we mention that the bang indicates a macro instead of a function?
- Syntax and semantics
- Entire section is unreferenced. References are required here.
Done. 0xDeadbeef 14:37, 14 July 2022 (UTC)
- Entire section is unreferenced. References are required here.
- Keywords and control flow
- Might as well mention comments here as well, since you're using them
Done. 0xDeadbeef
- Might as well mention comments here as well, since you're using them
- Expression blocks
- "if the semicolon is omitted, the last expression in the function will be used as the return value" The last expression, or the value of the last expression?
Done. 0xDeadbeef
- "if the semicolon is omitted, the last expression in the function will be used as the return value" The last expression, or the value of the last expression?
- Types
- For inferred types, can the table tell us what type is inferred?
Done by explaining what (inferred type) means in the table. 0xDeadbeef
- Link immutable object, syntactic sugar
Done. 0xDeadbeef
- For inferred types, can the table tell us what type is inferred?
- Memory management
- Citation required.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- Ownership
- Citation required.
Done - removed the section because it is a duplicate. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- Types and polymorphism
- Citation required.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- Cargo
- Citation required.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- IDE support
- Citation required.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- Performance
- Merge sentences into one paragraph.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Merge sentences into one paragraph.
- Adoption
- Citation required.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- Components
- Can we describe the standard library?
Not done: I cannot find reliable sources that can provide a good summary of the standard library. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- McNamara, Tim (2021). Rust in Action (1st ed.). Manning Publications. ISBN 9781617294556. (already cited once in the article) says:
- "Sadly, though, Rust has a fairly tight standard library. As with regular expressions, another area with relatively minimalist support is handling command-line arguments." (p. 71)
- "Rust's standard library is comparatively slim. It excludes numeric types that are often available within other languages. These include: Many mathematical objects for working with rational numbers and complex numbers; arbitrary-size integers and arbitrary-precision floating-point numbers ... fixed-point decimal numbers for working with currencies" (p.43)
- "Rust's standard library tends to lack many things that other languages provide, like random number generators and regular expression support. That means it's common to incorporate third-party crates into your project." (p.67)
- I think it's alright to cite a primary source as well, i.e. [1]. And maybe it's worth noting that you can exclude std if desired. Ovinus (talk) 18:50, 14 July 2022 (UTC)
- McNamara, Tim (2021). Rust in Action (1st ed.). Manning Publications. ISBN 9781617294556. (already cited once in the article) says:
- Can we describe the standard library?
- Web browsers and services
- Citation required.
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Citation required.
- Rust Foundation
- Citation required.
Done and fixed pov. 0xDeadbeef 14:37, 14 July 2022 (UTC)
- Citation required.
- Notes
- Still require references.
Done. 0xDeadbeef 14:37, 14 July 2022 (UTC)
- Still require references.
- References
- fn 1, 104 - need access date
Done. 0xDeadbeef
- fn 1, 6, 7, 8, 12, 24, 38, 40, 42, 66, 69, 75, 85, 95, 96, 102, - need publisher
Done. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- fn 34 - needs degree + university
Done. 0xDeadbeef
- fn 1, 104 - need access date
GA review – see WP:WIAGA for criteria
- Is it well written?
- A. The prose is clear and concise, and the spelling and grammar are correct:
- B. It complies with the manual of style guidelines for lead sections, layout, words to watch, fiction, and list incorporation:
- A. The prose is clear and concise, and the spelling and grammar are correct:
- Is it verifiable with no original research?
- A. It contains a list of all references (sources of information), presented in accordance with the layout style guideline:
- B. All in-line citations are from reliable sources, including those for direct quotations, statistics, published opinion, counter-intuitive or controversial statements that are challenged or likely to be challenged, and contentious material relating to living persons—science-based articles should follow the scientific citation guidelines:
- C. It contains no original research:
- D. It contains no copyright violations nor plagiarism:
- A. It contains a list of all references (sources of information), presented in accordance with the layout style guideline:
- Is it broad in its coverage?
- A. It addresses the main aspects of the topic:
- B. It stays focused on the topic without going into unnecessary detail (see summary style):
- A. It addresses the main aspects of the topic:
- Is it neutral?
- It represents viewpoints fairly and without editorial bias, giving due weight to each:
- It represents viewpoints fairly and without editorial bias, giving due weight to each:
- Is it stable?
- It does not change significantly from day to day because of an ongoing edit war or content dispute:
- It does not change significantly from day to day because of an ongoing edit war or content dispute:
- Is it illustrated, if possible, by images?
- A. Images are tagged with their copyright status, and valid non-free use rationales are provided for non-free content:
- B. Images are relevant to the topic, and have suitable captions:
- A. Images are tagged with their copyright status, and valid non-free use rationales are provided for non-free content:
- Overall:
- Pass or Fail:
- Quite good. Putting on hold pending changes.
- Thank you, User:Hawkeye7, I suppose the use of WP:ABOUTSELF sources in the technical sections would not prevent it from passing the GA? Or is there a need to reference the book "The Rust Programming Language (Covers Rust 2018)" in addition? 0xDeadbeef 06:43, 14 July 2022 (UTC)
- WP:ABOUTSELF only applies to biographies. Citing a book about the Rust programming language is precisely what is required. Hawkeye7 (discuss) 08:07, 14 July 2022 (UTC)
- @Hawkeye7: I've responded to all points raised above, please take another look when you have time :) Thanks again. 0xDeadbeef 17:39, 14 July 2022 (UTC)
- Thank you, User:Hawkeye7, I suppose the use of WP:ABOUTSELF sources in the technical sections would not prevent it from passing the GA? Or is there a need to reference the book "The Rust Programming Language (Covers Rust 2018)" in addition? 0xDeadbeef 06:43, 14 July 2022 (UTC)
- Quite good. Putting on hold pending changes.
- Pass or Fail:
@Hawkeye7: Thanks for the review! Caleb Stanford (talk) 16:13, 14 July 2022 (UTC)