Jump to content

Module talk:Sports table/Archive 2

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
< Module talk:Sports table
This is an old revision of this page, as edited by Lowercase sigmabot III (talk | contribs) at 06:03, 3 April 2021 (Archiving 1 discussion(s) from Module talk:Sports table) (bot). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.
Archive 1Archive 2

Again on some bugs I noted

Hi, I'm again here with some bugs/feature requests I would like to note. All of them are in my sandbox, but they can be summed up as two main problems:

  1. compatiblity and/or showing of bonus/penalty/starting points; and
  2. editable played/points columns.

For each problem I've presented a couple of examples of what I mean. Thanks. --Sannita - not just another it.wiki sysop 15:09, 28 November 2019 (UTC)

  1. Example 1 : Use |bonus_header= and |show_bonus_points=. I reckon this is to blame for example 2  : local s_pts = tonumber(Args['adjust_points_'..team_code_ii]) or tonumber(Args['startpoints_'..team_code_ii]) or 0 : it will use adjust_points then startpoints then 0 rather than adding them together. If there are bonus points and penalties require separate columns then this will require a further change. I've added them to your tables as an example. Spike 'em (talk) 15:26, 28 November 2019 (UTC)
    Spike 'em, thank you for identifying the bug. I have fixed this part. I would support having a |show_start_points=yes to have a separate starting points column. first, we should probably get an idea of how many pages are using both adjust_points and startpoints to make sure there are no surprises (now tracking in category:Pages using sports table with both adjust and startpoints). Frietjes (talk) 15:38, 28 November 2019 (UTC)
  2. You can hide the played column using |hide_played=yes, which I think is what you want for Example 2. In each case |only_pld_pts=yes not only hides the data columns, but also the result. If another usage of this parameter is needed then it would need more code changes. As to setting the played column to what you need, then I'd add the required number to the losses (can even enter it as "3+2" if you know there are 3 actual losses and 2 missing games) Spike 'em (talk) 16:26, 28 November 2019 (UTC)
Note: it is possible to set the Pld column directly using |matches_ABC= but these are only used if at least one of |win_ABC= |draw_ABC= or |loss_ABC= are blank or non-numeric. It would require a code change (a new table param?) to use this value to override the sum of W+D+L, even if all values are set. Something like 
if yesno(Args['override_matches'] or 'no') or tonumber(Args['win_'..team_code_ii]) == nil or tonumber(Args['draw_'..team_code_ii]) == nil or tonumber(Args['loss_'..team_code_ii]) == nil then
Spike 'em (talk) 16:54, 28 November 2019 (UTC)
I possibly have not understood correctly the situation, if so, correct me. Is the situation is that there are 10 played games, but we (the editors) know only results for 8 of them, then to manually set it to 10 played games but add data only for 8? If so, then maybe just add another param |unknown_results= or something and then it will count W+D+L+Unknown and add a note to played cell explaining that there are missing results for x amount of games; possibly also adding the page to a tracking category. --Gonnym (talk) 17:35, 28 November 2019 (UTC)
That is my understanding : we know the final games played and points totals, and some (but not all) of the individual results. I think on the given Example 1 we can work out the full WDL record for each team (ARS must have beaten SIR at home, and SIR drew one and lost one against SCL), but I guess that is beside the point. Spike 'em (talk) 10:11, 29 November 2019 (UTC)
@Spike 'em and Frietjes: thank you for your answers, and sorry for being this late in answering - other things took over, as always...
About the bonus/penalty/starting points, IMHO they should be treated as three different things, although I do not know how many cases there are of teams that get bonus points and penalty points. I think I found an example somewhere, but it's lost in my laptop's folder, and it might take a while to find it again.
About the |hide_played=, I did not know it existed, but it's interesting to know. :) TBH, I'd use |matches_ABC=, but in some way this should be used also when |win_ABC= |draw_ABC= or |loss_ABC= are not blank. Otherwise the |unknown_results= proposal is also good.
Thank you again for your help! --Sannita - not just another it.wiki sysop 16:31, 3 December 2019 (UTC)
we have Category:Pages using sports table with both adjust and startpoints to find pages using both adjust and start points. I don't see any articles in there, so we can definitely split the two without any problems. we will, however, need to be careful with any headers to make sure we don't mislabel anything. I don't entirely understand the need for |unknown_results_XYZ= since you can set the number of matches manually with |matches_XYZ=. yes, it is true that in order for that parameter to work you must have a non-numeric value in least one of the |win_XYZ=, |draw_XYZ=, and |loss_XYZ=. but, this makes sense since more than one of them must be unknown for the number of matches to be unknown. you simply put a ? or some marker after the value to have it considered as non-numeric (see this edit). I do see that the results column is always hidden if you have |only_pld_points=yes. I don't know the best user syntax for having all the Pld/W/D/L/GF/GA hidden but still having the points and results columns shown. come up with some good input syntax and I can certainly make it work in the module. Frietjes (talk) 17:30, 3 December 2019 (UTC)

Hiding GF&GA columns

I have a table where the source only gives information on GD but not on GF or GA: [1]. Is there a way I can hide the GF and GA columns and only display the GD column? Chanheigeorge (talk) 23:00, 4 January 2020 (UTC)

Chanheigeorge, okay, |hide_for_against_columns=y should work now. Frietjes (talk) 16:33, 5 January 2020 (UTC)

Hockey

Hi, I'm using the template for different sports and I noticed width is different for Ice Hockey and other sports, is there any specific reason ? I think they should be all the same.

Pos Team Pld W D L GF GA GD Pts
1  Cameroon 3 3 0 0 10 5 +5 9
Source: [citation needed]
Pos Team Pld W OTW OTL L GF GA GD Pts
1  Cameroon 3 3 0 0 0 22 7 +15 9
Source: [citation needed]

Mohsen1248 (talk) 13:26, 5 January 2020 (UTC)

They have different columns due to different rules about draws (or lack of them). Do you have any pages which mix usage of these tables that are experiencing problems? Spike 'em (talk) 14:51, 5 January 2020 (UTC)
in addition, sometimes there are different point multipliers assigned for OTW/OTL vs PKW/PKL. Frietjes (talk) 16:34, 5 January 2020 (UTC)
I still can't understand why for example the "pos" column should be different in those two tables. I didn't say why they have different columns, obviously I know they are different sports, I mean why column width is different. why hockey tables are wider ? Mohsen1248 (talk) 17:36, 5 January 2020 (UTC)
WDL has a standard column width of 28, whereas WDL OT (which WL OT invokes) has 32. Each of these has been the same since the modules were first created in 2014 / 2016 respectively. As to why this was done you'd have to ask the module creators (though it maybe that the 3 letter column headings are too wide to fit in the 28 pixel columns, so all the columns were widened so that they are constant within a given table?) Spike 'em (talk) 21:41, 5 January 2020 (UTC)
I can see the reason but if the whole idea of creating this Module:Sports table is to standardize all sport tables then it should be the same as others. I think maybe they can only keep those two columns at "32 pixel" or maybe even make it OW and OL instead of OWL and OTL. Mohsen1248 (talk) 11:29, 7 January 2020 (UTC)

Abbreviation issue

The right-hand side of the tables at the Group A section 2015 Ken Galluccio Cup use abbreviations that aren't written anywhere else in the article. Not sure why the usage is even warranted, as there is certainly enough space to write it out in full (as MOS:ABBR says Always consider whether it is better to simply write a word or phrase out in full, thus avoiding potential confusion for those not familiar with its abbreviation. Remember that Wikipedia does not have the same space constraints as paper.), but even if it's desired, the abbreviations should use {{abbr}} as the left-side of the table does - consistent and less confusion for everyone. --Gonnym (talk) 07:33, 1 February 2020 (UTC)

Volleyball

@McVahl, Mohsen1248, and Voncabriga: after some discussion on my talk page, I have added alternative syntax to Module:Sports table/Volleyball that is similar to the input format used in {{Vb cl9 team}}. Note that you probably only want to use on input style at a time, but if you do try to use more than one input style, the results should be additive. after my changes, the following should be roughly equivalent

Vb templates 
{{Vb cl3 header}}
{{Vb cl9 team |p=1 |t={{vb|SRI}} |w3_0=3 |w3_1=0 |w3_2=0 |l2_3=0 |l1_3=0 |l0_3=0 |spw=225 |spl=158 |bc=#ccffcc}}
{{Vb cl9 team |p=2 |t={{vb|AUS}} |w3_0=0 |w3_1=1 |w3_2=1 |l2_3=0 |l1_3=0 |l0_3=1 |spw=256 |spl=269 |bc=#ccffcc}}
{{Vb cl9 team |p=3 |t={{vb|KSA}} |w3_0=0 |w3_1=1 |w3_2=0 |l2_3=0 |l1_3=1 |l0_3=1 |spw=243 |spl=254 |bc=#ffcccc}}
{{Vb cl9 team |p=4 |t={{vb|KAZ}} |w3_0=0 |w3_1=0 |w3_2=0 |l2_3=1 |l1_3=1 |l0_3=1 |spw=233 |spl=276 |bc=#ffcccc}}
{{end}}
Sports table 
{{#invoke:Sports table|main|style=Volleyball
|team1=SRI|name_SRI={{vb|SRI}} |win3s_SRI=3 |win4s_SRI=0 |win5s_SRI=0 |loss5s_SRI=0 |loss4s_SRI=0 |loss3s_SRI=0 |spw_SRI=225 |spl_SRI=158 
|team2=AUS|name_AUS={{vb|AUS}} |win3s_AUS=0 |win4s_AUS=1 |win5s_AUS=1 |loss5s_AUS=0 |loss4s_AUS=0 |loss3s_AUS=1 |spw_AUS=256 |spl_AUS=269 
|team3=KSA|name_KSA={{vb|KSA}} |win3s_KSA=0 |win4s_KSA=1 |win5s_KSA=0 |loss5s_KSA=0 |loss4s_KSA=1 |loss3s_KSA=1 |spw_KSA=243 |spl_KSA=254 
|team4=KAZ|name_KAZ={{vb|KAZ}} |win3s_KAZ=0 |win4s_KAZ=0 |win5s_KAZ=0 |loss5s_KAZ=1 |loss4s_KAZ=1 |loss3s_KAZ=1 |spw_KAZ=233 |spl_KAZ=276 

|col_A=#ccffcc|result1=A|result2=A
|col_E=#ffcccc|result3=E|result4=E
}}

note that win3s means win in 3 sets, which is the same as w3_0 in the old vb templates. any win by more than one set is a "big win", and any loss by more than one set is a "big loss". the point values for big wins and big losses are the same as before and can be changed the same as before. let me know if you see any problems. Frietjes (talk) 21:14, 6 February 2020 (UTC)

Legs parameter from Module:Sports results

When the matches are defined in the template, would it be possible to support additional legs (for 3+ meetings in a season) as is done in Module:Sports results? For example here, so the results table doesn't have to be separate. S.A. Julio (talk) 23:15, 24 January 2020 (UTC)

Can't you use {{ThreeLegStart}}? It has an option to extend it to five legs. Howard the Duck (talk) 13:48, 25 January 2020 (UTC)
Doesn't really fit, as this isn't based on aggregate score or winning more matches than the other, but finishing first in a table based on points and goal difference. S.A. Julio (talk) 14:06, 25 January 2020 (UTC)
S.A. Julio, probably works now, but let me know if I didn't implement it correctly. Frietjes (talk) 19:27, 26 January 2020 (UTC)
Frietjes, great thanks! Only difference I noticed is the null value doesn't work for leg 3 (just displays a normal blank cell). S.A. Julio (talk) 03:11, 27 January 2020 (UTC)

S.A. Julio, I think you are talking about the difference in the match3_BBB_AAA cell (which is omitted and not set to null) seen here

Pos Team Pld W D L GF GA GD Pts AAA BBB AAA BBB AAA BBB
1 Team A 4 3 0 1 8 4 +4 9 0–1 3–1
2 Team B 4 1 0 3 4 8 −4 6 2–3 0–2 [a]
Source: the source
Rules for classification: 1) points; 2) head-to-head points; 3) head-to-head goal difference; 4) head-to-head goals scored; 5) goal difference; 6) number of goals scored.
Notes:
  1. ^ Match not played
Home \ Away AAA BBB AAA BBB AAA BBB
Team A 0–1 3–1
Team B 2–3 0–2 –[a]
Updated to match(es) played on unknown. Source: [citation needed]
Legend: Blue = home team win; Yellow = draw; Red = away team win.
Notes:
  1. ^ Match not played

the interesting thing about this is that if you check the standard 1 leg case you see the same thing. the source of this difference can be found by checking the code for Module:Sports results line 184 which has Args[m..team_code_ii..'_'..team_code_jj] = (Args[m..team_code_ii..'_'..team_code_jj] or '–')..note_string which is default dash and Module:Sports table line 472 which has Args[m..team_code_ii..'_'..team_code_jj] = (Args[m..team_code_ii..'_'..team_code_jj] or '')..note_string which has default blank. another interesting feature is that if you were try to put a null in that cell you don't get what you would expect:

Pos Team Pld W D L GF GA GD Pts AAA BBB AAA BBB AAA BBB
1 Team A 4 3 0 1 8 4 +4 9 0–1 3–1
2 Team B 4 1 0 3 4 8 −4 6 2–3 0–2 null[a]
Source: the source
Rules for classification: 1) points; 2) head-to-head points; 3) head-to-head goal difference; 4) head-to-head goals scored; 5) goal difference; 6) number of goals scored.
Notes:
  1. ^ Match not played
Home \ Away AAA BBB AAA BBB AAA BBB
Team A 0–1 3–1
Team B 2–3 0–2 null[a]
Updated to match(es) played on unknown. Source: [citation needed]
Legend: Blue = home team win; Yellow = draw; Red = away team win.
Notes:
  1. ^ Match not played

unless you remove the note from the result. editors have probably figured this out by now. as far as the inconsistency goes, I am all for making them consistent. if possible, I would like to merge more of the redundant code which would force them to be consistent. the main question is: should the default be dash or should the default be blank? I really don't care either way. Frietjes (talk) 16:16, 27 January 2020 (UTC)

Frietjes, thanks a lot for adding the legs functionality to this module. I have tried to add it to the Dutch version as well but weirdly it doesn't work there. nl:Sjabloon:Stand Play-off 3 (voetbal België) is one of the instance where its use is desired there. Could you take a look?Tvx1 21:18, 22 February 2020 (UTC)
Tvx1, okay, I think I fixed it. there is a lot there, but you had missed making changes to the header and row subfunctions in nl:Module:Sports results. now that I have implemented the changes there, it should be working (although I may have missed something). Frietjes (talk) 14:45, 23 February 2020 (UTC)

I've been thinking about this a bit more and I'm starting to wonder why these legs are always generated in pairs (e.g. 2/4/6). In the above example, for instance, I'd think that the sixth column of matches doesn't really need to be there.Tvx1 22:39, 29 February 2020 (UTC)

Head to head column

I have been using the WDL template. In sports that frequently have multiple teams/players tied, it might be more useful to have a separate column for HTH rather than attaching notes to the points column. A hacky way that I have done this is to use 

|rw_header=<abbr title="head-to-head score among tied players">HTH</abbr>
|show_rw=yes
|rwpoints=0

with |rw_NAME=1 (or however many points NAME had among tied teams/players)

This runs into problems though, especially if |rwpoints=0 gets removed in someone else's edit.

Is there a way someone could make an option for a hth column that appears right after the points column? Thanks!

The main reason I want one is for Chess tournaments. There is a Chess version of Sports table, but I'm not sure how it works exactly. At least, you can't just convert a WDL table into one, which would be kinda necessary. NHammen (talk) 13:49, 23 March 2020 (UTC)


I decided to make one in the sandbox for WDL myself. Testing testing:

Rank Player Pts Pld W D L SB NEP MVL CAR GIR WAN GRI DIN ALE
1  Ian Nepomniachtchi (RUS) 4.5 6 3 3 0 12 —      ½    1   1    ½    1     ½ 
2  Maxime Vachier-Lagrave (FRA) 3.5 6 1 5 0 9    —  ½     ½    ½   ½    1     ½ 
3  Fabiano Caruana (USA) 3 6 1 4 1 9  ½     ½  —   ½       ½    0   1  
4–5  Anish Giri (NED) 3 6 1 4 1 7.75  0    ½    ½   —   ½       ½    1 
4–5  Wang Hao (CHN) 3 6 1 4 1 7.75   0   ½       ½   —   ½    1   ½  
6  Alexander Grischuk (RUS) 3 6 0 6 0 9   ½    ½   ½       ½   —  ½    ½  
7  Ding Liren (CHN) 2 6 1 2 3 6   0    0   1    ½    0     ½  —   
8  Kirill Alekseenko (RUS) 2 6 0 4 2 7  ½    ½      0   0     ½    ½     —
Updated to match(es) played on 23 March 2020. Source: Official website
Rules for classification: 1) points; 2) head-to-head score among tied players; 3) total number of wins; 4) Sonneborn–Berger score (SB); 5) tie-break games.

Note: Numbers in the crosstable in a white background indicate the result playing the respective opponent with the white pieces (black pieces if on a black background).


Seems to work. How does this get moved from sandbox to main? NHammen (talk) 20:16, 23 March 2020 (UTC)

Nevermind. I got the Chess module table to work. So I don't need this to migrate from sandbox anymore. NHammen (talk) 00:31, 5 April 2020 (UTC)

Chess style match table

@Frietjes: In the chess style, I would like to make the match table look like the match table from the 2014 candidates tournament (copied below). However, the match table is called from Sports table main, not from the Chess style, so an alteration would have to be made to Sports table main. Would it be acceptable to make a copy of Module:Sports_results called Module:Sports_results/Chess which would only include the necessary functions (header and row I think) so that we could reverse the order of the team and leg loops in that module? In Sports table we would also need to add a line of code after local p_matches = match_table and require('Module:Sports results') that says if style_def == 'Chess' then local p_matches = match_table and require('Module:Sports results/Chess') end. Is that too hacky?

Alternatively, we could add an option in Sports results which flips the order of the team and leg loops, but that would involve duplicating a lot of code in ways that it is easy to break things.

Anyways, I would like the match crosstable to end up looking something like this:

Final standings of the 2014 Candidates Tournament
Rank Player Rating
March 2014 		1
(VA) 		2
(SK) 		3
(VK) 		4
(SM) 		5
(DA) 		6
(LA) 		7
(PS) 		8
(VT) 		Points Tiebreaks
H2H Wins SB
W B W B W B W B W B W B W B W B
1 India Viswanathan Anand 2770 ½ ½ ½ ½ ½ 1 ½ ½ 1 ½ ½ ½ 1 ½ 8½ — 3 57.25
2 Russia Sergey Karjakin 2766 ½ ½ 1 0 ½ ½ ½ ½ 0 1 ½ 1 ½ ½ 7½ — 3 51.75
3 Russia Vladimir Kramnik 2787 ½ ½ 1 0 1 ½ ½ ½ ½ ½ 0 ½ 1 0 7 2½ 3 49.25
4 Azerbaijan Shakhriyar Mamedyarov 2757 0 ½ ½ ½ ½ 0 1 ½ 1 0 1 ½ ½ ½ 7 2 3 48.00
5 Russia Dmitry Andreikin 2709 ½ ½ ½ ½ ½ ½ ½ 0 1 ½ ½ 0 1 ½ 7 1½ 2 48.50
6 Armenia Levon Aronian 2830 ½ 0 0 1 ½ ½ 1 0 ½ 0 1 ½ ½ ½ 6½ 1½ 3 45.00
7 Russia Peter Svidler 2758 ½ ½ 0 ½ ½ 1 ½ 0 1 ½ ½ 0 1 0 6½ ½ 3 46.00
8 Bulgaria Veselin Topalov 2785 ½ 0 ½ ½ 1 0 ½ ½ ½ 0 ½ ½ 1 0 6 — 2 42.25

NHammen (talk) 20:49, 5 April 2020 (UTC)

@Frietjes: @CaradhrasAiguo: @Adpete: I built a Module:Sports results/Chess , and now I have some code in the sandbox. Here is the result:

Rank Player Rating
March 2014 		Score H2H Wins SB Qualification VA SK VK SM DA LA PS VT
1  Viswanathan Anand (IND) (Q) 2770 8 1⁄2 — 3 57.25 Advance to title match ½ ½ ½ ½ ½ 1 ½ ½ 1 ½ ½ ½ 1 ½
2  Sergey Karjakin (RUS) 2766 7 1⁄2 — 3 51.75 ½ ½ 1 0 ½ ½ ½ ½ 0 1 ½ 1 ½ ½
3  Vladimir Kramnik (RUS) 2787 7 2 1⁄2 3 49.25 ½ ½ 1 0 1 ½ ½ ½ ½ ½ 0 ½ 1 0
4  Shakhriyar Mamedyarov (AZE) 2757 7 2 3 48 0 ½ ½ ½ ½ 0 1 ½ 1 0 1 ½ ½ ½
5  Dmitry Andreikin (RUS) 2709 7 1 1⁄2 2 48.5 ½ ½ ½ ½ ½ ½ ½ 0 1 ½ ½ 0 1 ½
6  Levon Aronian (ARM) 2830 6 1⁄2 1 1⁄2 3 45 ½ 0 0 1 ½ ½ 1 0 ½ 0 1 ½ ½ ½
7  Peter Svidler (RUS) 2758 6 1⁄2  1⁄2 3 46 ½ ½ 0 ½ ½ 1 ½ 0 1 ½ ½ 0 1 0
8  Veselin Topalov (BUL) 2785 6 — 2 42.25 ½ 0 ½ ½ 1 0 ½ ½ ½ 0 ½ ½ 1 0
Source: [2]
(Q) Qualified to the phase indicated

For this to work, now all that needs to be done is that the 3 lines of code from Module:Sports table/sandbox need to be ported to the main Module:Sports table NHammen (talk) 01:02, 7 April 2020 (UTC)

You seem to have changed a lot more than 3 lines, is it just the section at the top that you need changing? Spike 'em (talk) 09:12, 7 April 2020 (UTC)
@Spike 'em: The diff (https://en.wikipedia.org/w/index.php?title=Special%3AComparePages&page1=Module%3ASports+table&page2=Module%3ASports+table%2Fsandbox) between the current Sports table and the Sports table/sandbox has five lines of code that are different. Two of those differences are just using the sandbox versions of other modules, which have no differences from their main. The other three lines of code are the lines that I added. NHammen (talk) 13:11, 7 April 2020 (UTC)
Ah, apologies: I was just diffing the recent changes you made to the sandbox, some of which was just getting that in-line with the main page. Spike 'em (talk) 14:02, 7 April 2020 (UTC)
No need to apologize. That's entirely understandable. NHammen (talk) 15:45, 7 April 2020 (UTC)
NHammen, I made this change which should be effectively what you had, but without the extra require. if we have a situation where there are more sports that have custom results tables, we can always refactor the code to use the equivalent of a "switch" statement there. hopefully I didn't break anything. the main reason why I stopped working on the chess submodule was lack of interest from the community. it seems like you will have more luck than I did. Frietjes (talk) 15:45, 8 April 2020 (UTC)
Frietjes, thank you. That works great! NHammen (talk) 17:51, 8 April 2020 (UTC)

Possible unclosed span tag error

This module appears to be causing unclosed span style="white-space:nowrap" tags in the formatted |teamn= table cell. You can see it if you copy the Group A table from 2014 FIFA World Cup qualification – AFC Third Round into Special:ExpandTemplates. Is it possible to close these span tags? Thanks. – Jonesey95 (talk) 15:01, 11 April 2020 (UTC)

I see them. These tags come from the column header for the match results table. This is handled by Module:Sports results, which is called from this module. This problem almost certainly arises from the get_short_name function in that module. Unfortunately, there is some rather complex gsub stuff going on there, which seems to be the source of the problem. One solution is to explicitly define |short_TTT= yourself, so that the meat of the get_short_name function is not called. But this is just hiding the fact that there is an error somewhere in this function. NHammen (talk) 20:07, 12 April 2020 (UTC)

@Jonesey95:I see the problem. The command n = mw.ustring.gsub(n, '(<span class="flagicon">%s*%[%[[Ff][Ii][Ll][Ee]:[^%[%]]*%]%][^<>]*</span>).*', '%1') removes everything after the closing span for the <span class="flagicon">. But at the point it is called in this example, the only thing after that closing span is the closing span for the <span style="white-space:nowrap">. I am hesitant to remove that line of code, because it must be there for a reason. Maybe it should strip everything before the <span class="flagicon"> as well? So that would be n = mw.ustring.gsub(n, '.*(<span class="flagicon">%s*%[%[[Ff][Ii][Ll][Ee]:[^%[%]]*%]%][^<>]*</span>).*', '%1'). NHammen (talk) 20:24, 12 April 2020 (UTC)

@Frietjes: before I go into the sandbox to fix this issue, do you remember why the line of code in this diff (https://en.wikipedia.org/w/index.php?title=Module:Sports_results&diff=926327613&oldid=925509592) was added? I don't want to end up breaking something that you had fixed. NHammen (talk) 20:38, 12 April 2020 (UTC)
So, I went into the sandbox, and my addition of 2 characters does fix the issue discussed here. Still need to check if it breaks something else. NHammen (talk) 21:21, 12 April 2020 (UTC)
I copied over the sandbox. I think you understand the intent of that section of code (to remove everything but the flag in the abbreviation for the team name), so removing stuff before and/or after the flag would be correct. thank you! Frietjes (talk) 15:14, 13 April 2020 (UTC)
That's what I figured. Just wanted to be sure, because this could potentially have large effects. And I think I am not so good with the gsub stuff yet. NHammen (talk) 15:56, 13 April 2020 (UTC)
That looks good to me. Thanks! – Jonesey95 (talk) 19:38, 13 April 2020 (UTC)

Average number of points per matches played

Necessary for Template:2019–20 Ligue 1 table as per final declared table of Ligue 1: [3]. Chanheigeorge (talk) 16:27, 30 April 2020 (UTC)

In the WDL style, use |ranking_style=ppg for points per game NHammen (talk) 17:00, 30 April 2020 (UTC)

Wrestling

Hi, I tried to use this for the sport of wrestling, I tried to use current options but I need some help here

Athlete Pld W L CP TP
 Reineris Salas (CUB) 3 3 0 11 27
 Jordan Steen (CAN) 3 2 1 8 23
 José Daniel Díaz (VEN) 3 1 2 5 11
 Miguel Sánchez (MEX) 3 0 3 0 0
CP / TP CAN CUB MEX VEN
 Canada 0–5 11–0 12–1
 Cuba 3–0 PO 10–0 12–1
 Mexico 0–4 SU 0–4 SU 0–9
 Venezuela 1–4 SU1 1–4 SU1 3–0 PO
Pos Athlete Pld W L GF GA Pts CUB CAN VEN MEX
1  Reineris Salas (CUB) 3 3 0 0 0 11 — 5–0 12–1 10–0
2  Jordan Steen (CAN) 3 2 1 0 0 8 0–3 PO — 12–1 11–0
3  José Daniel Díaz (VEN) 3 1 2 0 0 5 1–4 SU1 1–4 SU1 — 9–0
4  Miguel Sánchez (MEX) 3 0 3 0 0 0 0–4 SU 0–4 SU 0–3 PO —
Source: [citation needed]

Is it possible to hide GF/GA columns as well ? I couldn't find that option. in this sport they never count the number of points against, "points for" is called "Technical points" (TP) but since that's not a tie breaker not necessary to be in the table. also I would like it more if it was possible to see CP instead of Pts but if this is not easy to make that change, I can live with that Pts column, but another request, in some events the first factor is the number of win (actually in most competitions) and CP comes second, but also in some older events CP was the first deciding factor. we have an option to use |ranking_style=w but in that case it will hide the Pts/CP column, is it possible to have both columns (W and Pts) but make it optional which one is bold ? thanks in advance. Mohsen1248 (talk) 23:11, 27 April 2020 (UTC)

For the first question, there is an easy solution: |for_against_style=none. For the rest, it would require either changes to the existing WL style or creating a new style. NHammen (talk) 03:12, 29 April 2020 (UTC)
Wait. You can bold wins and still show points, because of the way you are setting points with |adjust_points_TTT=. If you use |ranking_style=w then wins is bolded and points are not shown, as you noted. But, then you can use |show_bonus_points=yes combined with |bonus_header=. In that case you get:
Pos Athlete Pld W L CP CUB CAN VEN MEX
1  Reineris Salas (CUB) 3 3 0 11 — 5–0 12–1 10–0
2  Jordan Steen (CAN) 3 2 1 8 0–3 PO — 12–1 11–0
3  José Daniel Díaz (VEN) 3 1 2 5 1–4 SU1 1–4 SU1 — 9–0
4  Miguel Sánchez (MEX) 3 0 3 0 0–4 SU 0–4 SU 0–3 PO —
Source: [citation needed]

NHammen (talk) 03:27, 29 April 2020 (UTC)

Thanks a lot for your answer, it already answers most of my requests, one last request, as I said in some competitions CP is the first decider (and not the number of wins) is it possible to keep the table exactly as your example but have that CP column in bold ? Mohsen1248 (talk) 04:55, 29 April 2020 (UTC)
Not as far as I can see. In this case, you could decide not to use |ranking_style=w, and just use the Pts column which would be in bold. But you can't change the header of Pts. That's the only way I see to do it. NHammen (talk) 13:27, 29 April 2020 (UTC)
That's OK, I can use Pts (and not CP) for all the tables, thanks for your help. Mohsen1248 (talk) 14:16, 29 April 2020 (UTC)

@Mohsen1248: I just created a new style called Custom. This style allows you to set the number of columns that the table has, and give each one a custom header. That is, it has more customization than the WL or WDL styles, but doesn't calculate as much. This only calculates matches played, points, and points per game. But I think that is more than you need. See below:

Pos Athlete Pld W L CP TP CUB CAN VEN MEX
1  Reineris Salas (CUB) 3 3 0 11 27 — 5–0 12–1 10–0
2  Jordan Steen (CAN) 3 2 1 8 23 0–3 PO — 12–1 11–0
3  José Daniel Díaz (VEN) 3 1 2 5 11 1–4 SU1 1–4 SU1 — 9–0
4  Miguel Sánchez (MEX) 3 0 3 0 0 0–4 SU 0–4 SU 0–3 PO —
Source: [citation needed]

If you want to set only one of the columns as bold, just remove the |bold_col2=yes or |bold_col4=yes as appropriate. NHammen (talk) 21:30, 1 May 2020 (UTC) I haven't written any documentation for this new style yet though, so you'll have to stumble along blindly for a bit if you want to use it right away. NHammen (talk) 21:40, 1 May 2020 (UTC)

@NHammen:, thanks a lot, this is great and covers everything, I also can probably use it for other individual sports, I already know good enough to use it myself but having documentation will help others. I'm not really familiar with how things work here, so this is ready for use and I can start using it with the name Custom ? nobody will rename it or something like that later ? Mohsen1248 (talk) 21:44, 1 May 2020 (UTC)
@Mohsen1248: I don't see any reason why the name of the style would be changed. But I only started editing Sports table modules a couple of weeks ago, so there are people around who might care a bit more than I do. Which means I can't say for certain that this will not be renamed later. But based on the fact that when the Football style was renamed to WDL, they ensured backwards compatibility with the old name, it stands to reason that even if the name is changed, all tables that use |style=Custom will still work properly. I have a lot of free time due to Coronavirus, so I will probably be adding documentation relatively soon. NHammen (talk) 22:06, 1 May 2020 (UTC)
@NHammen: Great, thanks again, I really appreciate your work. Mohsen1248 (talk) 22:30, 1 May 2020 (UTC)
@Mohsen1248: So I have written some documentation. There are a few more things I need to add to it, but it's mostly complete. However, I should mention that I have added a new parameter |ranking_col= which in addition to selecting which column to bold, also sets the column to show any hth notes in. I did this because I saw that no column was showing hth notes. Since you probably didn't define any hth notes in your uses, that still is okay. The parameter |bold_colN=yes still works, but it is preferable to use |ranking_col=N going forward, so that there will always be a column to show hth notes, if there are any, and to avoid any shenanigans caused by the default value of this new parameter. I did go and edit a few of the pages you had used the module in, just to test it out. NHammen (talk) 20:01, 2 May 2020 (UTC)
Thanks, that's even better for the reason you explained. Mohsen1248 (talk) 20:20, 2 May 2020 (UTC)
@NHammen: I made necessary adjustments in all articles using this module, so if you want to make any change or even remove that previous option, that won't make any harm. anyway I highly doubt there will be a table with more than column in bold. Mohsen1248 (talk) 20:37, 2 May 2020 (UTC)

In the WDL style, highest_pos and show_gb interact badly

If you use |show_gb=yes but do not define |GB_team= then |GB_team= defaults to 1. On line 329 of the WDL style, the following concatenation is used: 'win_'..team_list[GB_team_no]. However, the team list that is passed to the row function in the style only includes teams between |highest_pos= and |lowest_pos=. Therefore, if |highest_pos= is greater than 1, then team_list[GB_team_no] is nil, and a Lua error is thrown indicating that a concatenation with a nil value was attempted. Either GB_team_no needs a different default value (maybe equal to highest_pos), or some sort of error checking is needed to prevent concatenation with a nil. NHammen (talk) 16:39, 27 May 2020 (UTC)

Screws up if rank doesn't start at #1

Is there a way for this to start on any other ranking save for #1? There are some tournaments were lower seeded teams compete separately from higher seeded teams. Or maybe I'm doing it wrong? — Preceding unsigned comment added by Howard the Duck (talk • contribs) 12:16, 23 May 2020 (UTC)

@Howard the Duck: There are a couple of ways of handling this.
Option 1: define all teams but use |highest_pos=:
{{#invoke:Sports table|main|style=WDL

|team1=AAA |team2=BBB |team3=CCC |team4=DDD |team5=EEE

|name_AAA=Team A
|name_BBB=Team B
|name_CCC=Team C
|name_DDD=Team D
|name_EEE=Team E

|highest_pos=3
}}
Pos Team Pld W D L GF GA GD Pts
3 Team C 0 0 0 0 0 0 0 0
4 Team D 0 0 0 0 0 0 0 0
5 Team E 0 0 0 0 0 0 0 0
Updated to match(es) played on unknown. Source: [citation needed]
Option 2: define only the needed teams and use |pos_XXX=:
{{#invoke:Sports table|main|style=WDL

|team1=CCC |team2=DDD |team3=EEE
|pos_CCC=3 |pos_DDD=4 |pos_EEE=5

|name_CCC=Team C
|name_DDD=Team D
|name_EEE=Team E
}}
Pos Team Pld W D L GF GA GD Pts
3 Team C 0 0 0 0 0 0 0 0
4 Team D 0 0 0 0 0 0 0 0
5 Team E 0 0 0 0 0 0 0 0
Updated to match(es) played on unknown. Source: [citation needed]
Note that if you do both, bad things will happen. NHammen (talk) 16:24, 27 May 2020 (UTC)
Copy that. Thanks! Howard the Duck (talk) 17:05, 27 May 2020 (UTC)

Requested move 17 May 2020

The following is a closed discussion of a requested move. Please do not modify it. Subsequent comments should be made in a new section on the talk page. Editors desiring to contest the closing decision should consider a move review after discussing it on the closer's talk page. No further edits should be made to this discussion.

The result of the move request was: Moved to Module:Sports table/styledoc as suggested — Martin (MSGJ · talk) 21:19, 27 May 2020 (UTC)

– The current title of this page makes absolutely zero sense; docuementation pages don't themselves need documentation * Pppery * it has begun... 17:36, 17 May 2020 (UTC)

The discussion above is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

PPG and Points

Is there a way for Module:Sports_table/WDL to show the teams' total points alongside their Points Per Game, if a league was decided by the latter?

The current code is messy and seems to insert PPG and just gets rid of Points. How can we show them both together? They're both important information in any football table. - Demokra (talk) 03:17, 6 June 2020 (UTC)

I agree that we need both PPG and points in football tables for seasons cancelled by the pandemic that were resolved by PPG. I've mentioned this thread on a relevant thread at Wikipedia talk:WikiProject Football. Kahastok talk 11:04, 6 June 2020 (UTC)
I've added a |ranking_style=ppgpts option. I made the change in the module WDL subpage without using a sandbox because I couldn't see how to use an appropriate sandbox, but I don't see how the changes will affect anything else. Please revert if you see any problems. —  Jts1882 | talk  12:52, 6 June 2020 (UTC)
Thanks, Jts – the PPGPTS looks good so far. - Demokra (talk) 21:45, 6 June 2020 (UTC)
There is a minor issue that head to head notes are displayed in both columns, which seems a bit odd to me. But its better than not having the option at all. NHammen (talk) 22:05, 6 June 2020 (UTC)

"Matches with background in a lighter colour were decided after overtime."

Can there be an option for U.S. spelling of "color", or use a different word altogether? Howard the Duck (talk) 13:48, 6 July 2020 (UTC)

That text is in Module:Sports results. It can also display "Colours: ". PrimeHunter (talk) 15:47, 6 July 2020 (UTC)
Oops let me post that there... Howard the Duck (talk) 15:50, 6 July 2020 (UTC)

extra space in transclusion

I am transcluding 2022 FIFA World Cup qualification – AFC Second Round in 2020–21 in Indian football. But I am getting extra linebreaks above and below the table. I verified in the original page, but I don't see such linebreaks there. Not sure what's causing it. Can anyone help? Coderzombie (talk) 16:48, 2 July 2020 (UTC)

This was unrelated to the module. Smartyllama placed a bunch of newlines inside <onlyinclude>...</onlyinclude> in the article.[4] I have removed them.[5] It also caused unwanted whitespace in other articles. PrimeHunter (talk) 18:04, 2 July 2020 (UTC)
Huh, not really sure how I did that. I certainly wasn't trying to. My apologies. I was trying to delete the word "originally" as unnecessary but somehow did a whole lot more. Smartyllama (talk) 18:27, 2 July 2020 (UTC)
@Smartyllama: I can reproduce it with VisualEditor. It often makes unwanted changes with no editor action. PrimeHunter (talk) 18:45, 2 July 2020 (UTC)
@Smartyllama: @PrimeHunter: Thank you! I removed extra spaces in Group E, but didn't know extra spaces in other sections would also affect it. Coderzombie (talk) 02:53, 3 July 2020 (UTC)
It's a confusing scenario. The code {{:2022 FIFA World Cup qualification – AFC Second Round|transcludesection=Group E|show_matches=y|showteam=IND}} transcludes everything inside <onlyinclude>...</onlyinclude> in 2022 FIFA World Cup qualification – AFC Second Round. transcludesection=Group E is not a MediaWiki feature and does not refer to the article section 2022 FIFA World Cup qualification – AFC Second Round#Group E. transcludesection=Group E is just a parameter value like in templates, and the transcluded page decides what to do with the parameter. In this case, each onlyinclude block is of form {{#invoke:Sports table|main|style=WDL|section=Group E}} or another group name. When Module:Sports table is used on an article which is itself transcluded somewhere else, it is coded to only output anything when the transclusion has a matching transcludesection=Group E. So each of the other onlyinclude blocks output nothing from the module itself at 2020–21 in Indian football#2022 FIFA World Cup qualification. But after [6] they each output the newline VisualEditor added after the module call but inside <onlyinclude>...</onlyinclude>. PrimeHunter (talk) 12:24, 3 July 2020 (UTC)
@PrimeHunter: That's a wonderful explanation. But as these templates get more and more complex, these issues will get tougher to handle to naive users. Coderzombie (talk) 14:13, 6 July 2020 (UTC)
you can also wrap the content in {{trim}}, but removing the newlines is the better approach. Frietjes (talk) 17:20, 14 July 2020 (UTC)

Custom columns

Is there an easy way on adding additional columns aside from switching to Custom? Howard the Duck (talk) 15:14, 14 July 2020 (UTC)

Howard the Duck, what column to you want to add? Frietjes (talk) 17:18, 14 July 2020 (UTC)
It's to show the record of the team in that particular stage of the tournament; the other parts of the table show its overall record. Howard the Duck (talk) 17:27, 14 July 2020 (UTC)
Howard the Duck, do you have an example? Frietjes (talk) 18:10, 14 July 2020 (UTC)
2012 PBA Governors' Cup#Semifinals. I used 2 tables in here, but could've used just one with an extra column for the teams' semifinal round record. Howard the Duck (talk) 18:15, 14 July 2020 (UTC)
I tried doing this using Custom version, but I can't since it doesn't allow you to calculating by winning percentage, just points. I'd suggest allowing that functionality... or allow adding extra columns in the WL version, just in case those US leagues start using this module. Howard the Duck (talk) 18:39, 14 July 2020 (UTC)

Floating tables and moving the source to the title

Per request at 1993 Football League First Division play-off Final, I have added two more features. (1) if you use |float=left or |float=right it essentially uses {{stack begin}} and {{stack end}} to float the table to the left or right. (2) if you use |title= and |title_source= then a source is appended to the title, and the source in the footer is no longer required. I will work on updating the documentation. please let me know if I broke something. Frietjes (talk) 17:18, 14 July 2020 (UTC)

I also added an optional |digitpad=1 for WDL style, which _should_ do nothing if omitted, but otherwise pads under 10 by one {{0}}. to have the module first scan the columns to determine the alignment would require a lot more work (two passes), but this seems to work in many cases where it's wanted. if this addition is controversial, I will remove it. Frietjes (talk) 18:22, 15 July 2020 (UTC)

How about |float=center as an option as well? —Anomalocaris (talk) 17:19, 2 October 2020 (UTC)

Lua error

Am I the only one who gets "lua error"? For me, the templates work in 2022 FIFA World Cup qualification#Current stage (first round) 3, but not in 2022 FIFA World Cup qualification (UEFA)#Groups, In the later link I get the error message "Lua error: bad argument #1 to 'formatDate' (NaN)". I also tested in incognito mode (google chrome), then the templates work as they should. Did I miss a setting? This makes me so confused. DenSportgladeSkåningen (talk) 19:34, 24 November 2020 (UTC)

Yes I am receiving the same issue, that too on different browsers. Maybe someone has changed something up.--Anbans 585 (talk) 20:53, 24 November 2020 (UTC)
It seems to occur when a team in the table has yet to play a match, i.e. their record is 0-0-0. Once every team in the table has at least one win, draw or loss it no longer gets the Lua error. I have no idea why this error happens all of a sudden, but that seems to be what triggers it. QQ2NFLD (talk) 05:50, 25 November 2020 (UTC)
Pinging Frietjes, who might be able to troubleshoot this. – Jonesey95 (talk) 06:22, 25 November 2020 (UTC)
Same issue with 2020–21 Indian Super League season#League table  Saha ❯❯❯ Stay safe  08:51, 25 November 2020 (UTC)
2020–21 A-League#League table as well fyi. WDM10 (talk) 09:34, 25 November 2020 (UTC)
Now the template does not work at all for me, not even if I go into incognito mode. DenSportgladeSkåningen (talk) 10:40, 25 November 2020 (UTC)
Also getting this error but only for tables where no team has played a match yet, otherwise it's working normally. Ben5218 (talk) 13:39, 25 November 2020 (UTC)
@DenSportgladeSkåningen, Anbans 585, QQ2NFLD, Jonesey95, and WDM10: should be fixed now. Frietjes (talk) 15:04, 25 November 2020 (UTC)
@Frietjes: Can confirm that the error is no longer occurring, good job Frietjes! Ben5218 (talk) 15:21, 25 November 2020 (UTC)
@Frietjes: All good on the A-League page. Thanks! WDM10 (talk) 21:08, 25 November 2020 (UTC)

Would someone please work out what has to be done to fix:

Johnuniq (talk) 06:41, 26 November 2020 (UTC)

Johnuniq, done [7] [8] Frietjes (talk) 14:28, 26 November 2020 (UTC)
Beautiful, all cleaned up, thanks. Johnuniq (talk) 22:52, 26 November 2020 (UTC)

Module documentations

Has anyone given a thought about writing /docs to many of the styles listed on the main page (like WLHA, for example), because I have a hard time trying to use styles without reading the /docs or knowing them too well (like WL and WL OTL tiebreaker)? –Piranha249 17:23, 2 January 2021 (UTC)

Retrieved from "https://en.wikipedia.org/w/index.php?title=Module_talk:Sports_table/Archive_2&oldid=1015731777"