User talk:Js/6tabs-vector.js

Protocol-relative URL

This edit request has been answered. Set the |answered= parameter to no to reactivate your request.

In the line that sets the src attribute of each icon image:

.attr('src','/media/wikipedia/'+name)

the URL should be protocol-relative, that is:

.attr('src','/media/wikipedia/'+name)

in order to avoid mixed content in the event that someone is using the secure server without HTTPS Everywhere. Does this look right, or am I missing something? SoledadKabocha (talk) 05:28, 21 September 2012 (UTC)[reply]

In other words, diff of the requested edit SoledadKabocha (talk) 05:03, 24 September 2012 (UTC)[reply]

Okay

Done. Let me know if there are any problems. — Martin (MSGJ · talk) 14:56, 26 September 2012 (UTC)[reply]

Interface-protected edit request on 1 February 2021

It is requested that an edit be made to the interface-protected user page at User:Js/6tabs-vector.js. (edit · history · last · links · protection log)

This template must be followed by a complete and specific description of the request, that is, specify what text should be removed and a verbatim copy of the text that should replace it. "Please change X" is not acceptable and will be rejected; the request must be of the form "please change X to Y".

The edit may be made by any interface administrator. Remember to change the |answered=no parameter to "yes" when the request has been accepted, rejected or on hold awaiting user input. This is so that inactive or completed requests don't needlessly fill up the edit requests category. You may also wish to use the {{EIp}} template in the response. To request that a page be protected or unprotected, make a protection request. When the request has been completed or denied, please add the |answered=yes parameter to deactivate the template.

Currently, the accesskey attribute is copied to the links of the two tabs added by this script. Because of this, pressing <access key modifier>+t when on a content page only cycles through the view, edit, and history tabs for the talk page, instead of the normal (without this script) behaviour of navigating to the talk page. The same issue exists when you are on a talk page and want to navigate to the content page, just the other way around.

The problem can be fixed by inserting .removeAttr('accesskey') before the semicolon on line 21 (diff), which removes the attribute from the added tabs. You can test this change by loading my modified version of this script in your common.js or vector.js using {{subst:lusc|User:Rummskartoffel/6tabs-vector.js}}. If you don't normally use access keys and don't know the modifier on your browser and OS, see Wikipedia:Keyboard shortcuts#Using access keys.

After applying the change, please delete User:Rummskartoffel/6tabs-vector.js. Thanks in advance! – Rummskartoffel (talk • contribs) 15:13, 1 February 2021 (UTC)[reply]