View source for Template talk:Navbox

{{WikiProject banner shell|
{{WikiProject Templates|template_for_template_maintenance=y}}
}}
{{User:MiszaBot/config |archiveheader={{talkarchivenav}} |maxarchivesize=70K |counter=24 |minthreadsleft=4 |minthreadstoarchive=1 |algo=old(120d) |archive=Template talk:Navbox/Archive %(counter)d}}
{{Central|Module talk:Navbox}}
{{Archives |auto=long |search=yes |bot=MiszaBot II |age=120 |
* {{longitem|See [[Template talk:Navbox generic]] for previous discussions.}}
}}

== ID ==

This template is using ids apparently for aria-labelledby. The ids are the arguments title, above or group1. This causes issues when more than one template is used on a page with the same title. Those pages end up on [[Special:LintErrors/duplicate-ids]], which is currently unsupported by [[Mw:Parsoid|Parsoid]], the new parser. I am not convinced these ids are necessary. Could it just have an accessible label and no id, instead of using aria-labelledby? [[User:Snævar|Snævar]] ([[User talk:Snævar|talk]]) 18:42, 26 November 2024 (UTC)

:aria-labelledby is because there is no other way to identify the structure for navigation aids (well, there's aria-label lying around or something, but that would just include duplicating the title and then stripping all the potential wikitext and such which is hackier at the end of the day). I looked at this a bit when the lint rolled out and I think the easiest/best solution is just to rip it out for non-full-navboxes, and also removing support for using group1/above, which is most often the issue anyway. (above probably shouldn't be in the fallback list anyway.)
:Patches welcome ~ [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 19:25, 26 November 2024 (UTC)
::The other solution would be doing something like hashing the full contents of the navbox, which is likely to result in a unique ID, and then using that instead. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 19:27, 26 November 2024 (UTC)
:::Couldn't it just generate a random string? [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 19:33, 26 November 2024 (UTC)
::::Based on what seed? Either it's unseeded and you're varying the parser cache unreasonably or it's seeded and you still have to figure out where the seed is coming from. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 19:38, 26 November 2024 (UTC)
:::::Hmm. Can a module count how many times it's run on the page? [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 19:55, 26 November 2024 (UTC)
::::::No. And intentionally not, so even if there is a way it's not supported and could be broken at will. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:07, 26 November 2024 (UTC)
:::::Also: What's the harm in varying the parser cache? Isn't it generated only once per purge? [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 19:59, 26 November 2024 (UTC)
::::::Uh, I'm not entirely sure what I said there was truthful? I'm just thinking that you can't determine what the content will be on any given day/week/month which is generally bad for caches. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:11, 26 November 2024 (UTC)
:::@[[User:Izno|Izno]], [[User:Nardog|Nardog]], [[User:Snævar|Snævar]]: I implemented a very "quick-and-dirty" hashing scheme in [[Module:Navbox/sandbox]] (it just adds up the total length of the arguments), but I don't know enough about aria (or the intent behind its implementation here) to see if it's really working as intended. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 16:59, 8 January 2025 (UTC)
::A part of this problem is that sometimes child navboxes get an id. For example [[Template:2024_United_States_presidential_election]] has an id from child7_title, even though the child is a part of an larger navbox. That id is never used by aria-labeledby. In that example, there is an conflict on [[Tom_Hoefling]] with [[Template:2016_United_States_presidential_election]]. The same happens with group1 in child navboxes. [[User:Snævar|Snævar]] ([[User talk:Snævar|talk]]) 20:04, 28 November 2024 (UTC)
:::Right. I don't really know why group was decided to be a fallback - I can think of basically no legitimate cases. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 06:32, 1 December 2024 (UTC)

== [show] and [hide] buttons miscolored ==
The [show] and [hide] buttons in the title bar have the pale, external link color on the original Vector skin. They're the only ones with this problem. Please fix this. [[Special:Contributions/89.172.154.11|89.172.154.11]] ([[User talk:89.172.154.11|talk]]) 21:11, 27 December 2024 (UTC)

== How to make navbox with multiple horizontal bars/headers/sections? ==

So I'm just wondering, like for example, can I edit a navbox template to add a horizontal subheader? Like something similar to "above" or "below", except that I can insert it into the middle of the template or anywhere else. Do you understand what I mean? I tried to read about how to use the navbox template with collapsible subsections, but it just confused the hell out of me. [[User:AHI-3000|AHI-3000]] ([[User talk:AHI-3000|talk]]) 05:23, 31 December 2024 (UTC)
:If you're not looking to add a collapsible child subbox, you could always use a <code>listX</code> without the corresponding <code>groupX</code>, which would put the list values on its own line separating the other groups. At least, I think that's what you're aiming for based on your statement, but I might have misread. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 17:28, 31 December 2024 (UTC)
::@[[User:Primefac|Primefac]]: I meant a distinct header to place above or between the groups/lists in the navbox, something to help organize a navbox by dividing it into like two or more sets of different groups. [[User:AHI-3000|AHI-3000]] ([[User talk:AHI-3000|talk]]) 18:03, 6 January 2025 (UTC)
:::Your best bet is probably to use {{t|Navbox with collapsible groups}} with {{para|stateX|off}} for each corresponding {{para|groupX}}. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 16:08, 7 January 2025 (UTC)

== Revisiting merging [[Module:Navbox]], [[Module:Navbox with collapsible groups]], and [[Module:Navbox with columns]] ==

I'd like to revisit merging [[Module:Navbox]], [[Module:Navbox with collapsible groups]], and [[Module:Navbox with columns]], as discussed in [[#Directly render child navboxes]], now that the dust has had time to settle on those changes and the implementation of [[Module:Navbox with columns]].

[[Module:Navbox/sandbox]] is currently set up to serve as the backend for all three templates. This has the advantage of keeping the code and configuration files in one place, so that it's easier to maintain consistency between the three, and allows for nesting one type of navbox inside another using the {{para|type}} (or {{para|1_type}}) parameter. It also allows replacing a call to {{tl|navbox with columns}} or {{tl|navbox with collapsible groups}} with {{ml|navbox|with columns}} or {{ml|navbox|with collapsible groups}}.

The downside is that [[Module:Navbox]] gets larger and somewhat harder to navigate, but I think the reuse of the helper functions makes it worth it.

Thoughts? <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 21:35, 7 January 2025 (UTC)

:No fundamental issue for me. You might want to take a look at [[user talk:Izno#Navbox]] (I don't think your changes caused that issue but maybe they did, IDK). [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:39, 7 January 2025 (UTC)
:{{done}}. Feel free to revert if this causes any problems. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 19:30, 22 January 2025 (UTC)
::I reverted due to issues with {{tl|taxonbar}} and {{tl|Military navigation}} that were not captured by the testcases. I have re-deployed the change with that bug fixed, but we'll see what else crops up. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 20:05, 22 January 2025 (UTC)

== TemplateStyles hoisting in collapsible groups ==
{{moved from|User talk:Izno}}

So what's up with {{tl|IPA navigation}}? Is the stripping of TemplateStyles a bug on the module's part? Is there no workaround? [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 15:30, 3 January 2025 (UTC)

:As I've commented earlier, it's supposed to work. And does work from the parameters which aren't the relevant lists. I couldn't tell you why it doesn't work. There is no workaround that doesn't require including the 4 separate TemplateStyles invocations directly in the template definition. [[User:Izno|Izno]] ([[User talk:Izno#top|talk]]) 20:21, 3 January 2025 (UTC)
:Further discussion might reasonably be on [[Template talk:Navbox]] about it, Ahecht has done recent work and can probably fizzle the issue out. [[User:Izno|Izno]] ([[User talk:Izno#top|talk]]) 20:24, 3 January 2025 (UTC)
::@[[User:Izno|Izno]] Looks like it has something to do with your [[Special:Diff/1128570433]]. As far as I can tell, the styles aren't being added back in if the navbox is a subgroup. I can pretty easily change that (as shown at [[Special:Diff/1268198362]]), and it does solve the {{tl|IPA navigation}} problem, but I don't know enough about [[phab:T303378]] to know if that will cause other issues. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 15:58, 8 January 2025 (UTC)
:::That specific diff is when the hoisting was introduced, so if it never worked, it was either buggy from the get go or I just didn't think the issue totally through. Your change shouldn't cause an issue.
:::T303378 is the reason we have the hoisting in the first place. If/when that's no longer an issue (or when navboxes are displayed on mobile rather than stripped [[phab:T124168]]), we should be able to delete the relevant code entirely, but who knows when that will be. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:48, 8 January 2025 (UTC)
::::Thanks, and sorry for the confusing on the IPA navigation template. I could've sworn I ''was'' editing the sandbox. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 20:50, 8 January 2025 (UTC)
:::::You did. And then you also didn't. ;D
:::::One thing about your adjustment, and there may just be nothing we can or want to do about it, is that it's pulling up the navbox templatestyles sheet into navbox-styles. These are naturally deduplicated by TemplateStyles so it probably isn't a big deal... [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:55, 8 January 2025 (UTC)
::::::And it seems to be pulling up a lot more copies into navbox-styles than it should. I think I count 5 plus the original? And something like 4 tags for the hlist styles plus the original that should already be there. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:57, 8 January 2025 (UTC)
:::::::@[[User:Izno|Izno]] I fixed some of the duplication by making <code>hiding_templatestyles</code> a global variable instead of outputting {{tag|div|attribs=class="navbox-styles"}} for each of the child navboxes. The extra hlist styles are there because they're correctly being pulled from {{tl|flatlist}}, which is in {{tl|IPA common}}, which is in {{tl|IPA pulmonic consonants}}, {{tl|IPA non-pulmonic consonants}}, {{tl|IPA co-articulated consonants}}, and {{tl|IPA vowels}} (there's the 4 extra tags). <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 22:29, 8 January 2025 (UTC)
::::::::Ah nice. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 22:34, 8 January 2025 (UTC)

== generates errors from Module:Military navigation ==

When {{tl|Military navigation}} is invoked, it ends up invoking Module:navbox which produces the error "Lua error in Module:Navbox at line 192: attempt to concatenate field 'argHash' (a nil value).". This is true even on the [[Module:Military_navigation]] page. What is causing this error? -- [[User:Mikeblas|mikeblas]] ([[User talk:Mikeblas|talk]]) 19:42, 22 January 2025 (UTC)

:{{u|Ahecht }}, is this problem caused by {{diff||1271144115|1243116216|your changes}}? The error appears on very many pages. -- [[User:Mikeblas|mikeblas]] ([[User talk:Mikeblas|talk]]) 19:49, 22 January 2025 (UTC)
::@[[User:Mikeblas|Mikeblas]] Yup, I've reverted and and working on deploying a fix now. <span class="nowrap">--[[User:Ahecht|Ahecht]] ([[User talk:Ahecht|<b style="color:#FFF;background:#04A;display:inline-block;padding:1px;vertical-align:middle;font:bold 50%/1 sans-serif;text-align:center">TALK<br />PAGE</b>]])</span> 19:58, 22 January 2025 (UTC)
::: Still broken - see [[Wikipedia:Village_pump_(technical)#Incomprehensible_error_message]].[[User:Nigel Ish|Nigel Ish]] ([[User talk:Nigel Ish|talk]]) 20:13, 22 January 2025 (UTC)

== Default styles create Lint Errors ==

Since the default styles (bodystyle, basestyle, titlestyle, etc.) set background colors but do not set text colors, using this template creates Lint Errors. Please fix. [[User:Robkelk|Rob Kelk]] 23:14, 30 January 2025 (UTC)

:This cannot be systematically corrected. Sorry. Specific templates setting colors will need to fix their inputs. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 23:35, 30 January 2025 (UTC)

::Why not? It should be a simple addition to the code. --[[User:Robkelk|Rob Kelk]] 01:46, 31 January 2025 (UTC)
:::Whether it's appropriate to inherit colors is going to depend on the background itself. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 19:26, 31 January 2025 (UTC)
::::The backgrounds are specifically defined in the default styles. (That's what's creating the Lint Errors; background colors are specified but text colors are not. In order to stop creating the errors, either both need to be defined or neither need to be defined.) --[[User:Robkelk|Rob Kelk]] 20:36, 31 January 2025 (UTC)
:::::If it's the default styles you're actually complaining about, which are not in fact set by any of the various style parameters as referenced in your initial comment, I refer you to [[Template_talk:Navbox/Archive_24#Inaccessible_links_in_navbar|this discussion]]. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 01:40, 1 February 2025 (UTC)
::::::So it's been fixed for months but nobody updated the Documentation subpage to match? --[[User:Robkelk|Rob Kelk]] 15:30, 1 February 2025 (UTC)
:::::::Possibly. The documentation is not protected, so if you see a problem with it, and you know how to fix it, please do so. If you are reporting a problem with a specific page, please link to a page with an actual problem. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 03:43, 3 February 2025 (UTC)
::::::::I didn't know that I had to specify that it was ''this'' page's documentation when talking about this page. Also, I don't know how things were fixed. --`[[User:Robkelk|Rob Kelk]]