Module talk:Location map/Archive 10
![]() | This is an archive of past discussions about Module:Location map. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 5 | ← | Archive 8 | Archive 9 | Archive 10 | Archive 11 |
Edit request: Remove /sandbox from Module:Location map/multi
![]() | This edit request to Module:Location map/multi has been answered. Set the |answered= parameter to no to reactivate your request. |
Last edit[1] had local locmap = require('Module:Location map/sandbox')
. The /sandbox should be removed again. Christian75 (talk) 16:22, 23 February 2018 (UTC)
- @Frietjes: looks like the sandbox had got out of sync slightly with the main module, hence the unexplained removals (and also the require being a sandbox version). ∰Bellezzasolo✡ Discuss 20:23, 23 February 2018 (UTC)
- Bellezzasolo, yes, your diffs didn't ask for these removals, but when the sandbox was copied, that's what happened. I noticed because there was an explosion in the number of articles generating script errors, but we seem to be doing better now. Frietjes (talk) 20:26, 23 February 2018 (UTC)
- @Frietjes: looks like the sandbox had got out of sync slightly with the main module, hence the unexplained removals (and also the require being a sandbox version). ∰Bellezzasolo✡ Discuss 20:23, 23 February 2018 (UTC)
Proposed changes
I've made a change over at the module sandbox. This is the inclusion of a new parameter - |excludefrom=
. When set, the mark in question is excluded from the specified maps. The syntax for specifying maps is as usual. This is only useful in the context of multiple maps - either some of multiple marks are off the screen, or you have a map of a town, and you don't really want a dot saying that town's name slap bang in the centre - but you do want a map of the country.
∰Bellezzasolo✡ Discuss 07:22, 26 February 2018 (UTC)
- Bellezzasolo I do like the idea of supporting a static image without a locator pin (see this thread). there was also some discussion of having
|first_valid=
and/or|only_valid=
parameters which would (1) only show the first valid map and (2) only show the valid maps. a map is valid if the pin is on the map. this would be useful for Template:Infobox telescope which uses Template:Wikidata location map at the moment, but has problems with telescopes in Hawaii since they aren't on the main USA map. I don't see the point of showing maps that don't include any pins, unless these are static images that aren't location maps. Frietjes (talk) 16:48, 26 February 2018 (UTC)- @Frietjes: I was thinking in the context of {{Location map+}} mainly. There it has its uses, I think. ∰Bellezzasolo✡ Discuss 16:51, 26 February 2018 (UTC)
- Bellezzasolo can you provide an example in an article? Frietjes (talk) 16:53, 26 February 2018 (UTC)
- Frietjes e.g. University of Oxford#Map, which is tested with the new changes over at {{Location map+/testcases}} ∰Bellezzasolo✡ Discuss 17:14, 26 February 2018 (UTC)
- Bellezzasolo can you provide an example in an article? Frietjes (talk) 16:53, 26 February 2018 (UTC)
- @Frietjes: I was thinking in the context of {{Location map+}} mainly. There it has its uses, I think. ∰Bellezzasolo✡ Discuss 16:51, 26 February 2018 (UTC)
Multiple maps layout error
A problem was reported at Wikipedia:Help desk#Incorrect page layout. The example at Template:Location map#User selection of multiple maps displays the radio buttons to the left of the map instead of below. PrimeHunter (talk) 13:21, 4 March 2018 (UTC)
- Rabindranath Tagore was using Template:Location map+ with multiple maps. I've fixed the article, but there probably could be some improvements to the templates to detect this. (I don't believe we have any intention of supporting multiple locations and multiple maps simultaneously.) MB 14:38, 4 March 2018 (UTC)
- @PrimeHunter and MB: I will see about adding some tracking for this, and then (possibly) a method for correcting it. see Toggle options appear in the wrong place and Multiple maps without an infobox. Frietjes (talk) 15:04, 4 March 2018 (UTC)
- The example at Template:Location map#User selection of multiple maps still looks wrong to me but I don't know whether it does something unsupported. PrimeHunter (talk) 15:19, 4 March 2018 (UTC)
- @PrimeHunter and MB: I will see about adding some tracking for this, and then (possibly) a method for correcting it. see Toggle options appear in the wrong place and Multiple maps without an infobox. Frietjes (talk) 15:04, 4 March 2018 (UTC)