Jump to content

Wikipedia:Templates for discussion/Log/2018 April 5

Add links
From Wikipedia, the free encyclopedia
< Wikipedia:Templates for discussion | Log
This is an old revision of this page, as edited by Retro (talk | contribs) at 21:52, 5 April 2018 (Reviewed. Thanks Pppery.). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.
< April 4 April 6 >

April 5

Template:Bad

Propose merging Template:Bad with Template:No. Compare:

Bad No

It's a duplicate of {{no}}, aside from a barely noticable color difference (#faa vs. #F99). Nominated because there are only 3 uses with no parameters in the user space., meaning that the default form is never used to display "Bad", allowing it to be easily redirected to {{no}}.

I'm unfortunately short on time, so I haven't handled other formalities (notifying users); I will handle them later if no one else has. It would be nice if they could be automatically handled by a bot in the future, but that's just wishful thinking. E to the Pi times i (talk | contribs) 18:53, 5 April 2018 (UTC)[reply]

@Pppery: Oh! It was my edit to {{Bad}} that caused the erroneous merge template formatting! Thanks for fixing it; I'll definitely avoid making such an error in the future, now that I'm aware of it. E to the Pi times i (talk | contribs) 21:03, 5 April 2018 (UTC)[reply]
(edit conflict) A large number of unrelated things went wrong there leading to the mess.
  1. Your edit to {{bad}} broke the template by making it include the open table tag that it shouldn't.
  2. {{bad}} and {{no}} don't work when used directly, but only when inside of tables (that's what produced the style="background: #faa; color: black; vertical-align: middle; text-align: center; " nonsense. )
  3. You can't include two open curly brackets in a row in the middle of a template without escaping them (\{{2} in the regex did that). (that's what made the template not subst)
  4. Your signature has a displayed vertical bar in it. As it says in the relevant section of your preferences, Note: to use a displayed pipe ("|") character (i.e. not part of a piped link), please use &#124; for the pipe character; it can otherwise cause templates to fail., which only didn't cause a huge wikimarkup mess because of the previous problem.
  5. Table markup can't be used inside templates without escaping it. (You didn't try to do this, I had to tackle this issue when resolving the problem)
{{3x|p}}ery (talk) 21:11, 5 April 2018 (UTC)[reply]
@E to the Pi times i: {{3x|p}}ery (talk) 21:16, 5 April 2018 (UTC)[reply]
@Pppery: How do you escape curly brackets in templates? E to the Pi times i (talk | contribs) 21:20, 5 April 2018 (UTC)[reply]
{{((}} or <nowiki>{{</nowiki>, although in my case it was easier to rewrite the regex to avoid the bad combination. {{3x|p}}ery (talk) 21:21, 5 April 2018 (UTC)[reply]
(edit conflict) @Pppery: I note my sig is now substed. Did you change that? Does having it substed have any benefits over transclusion? E to the Pi times i (talk | contribs) 21:25, 5 April 2018 (UTC) Never mind, thanks for the policy link though. E to the Pi times i (talk | contribs) 21:29, 5 April 2018 (UTC)[reply]
I changed nothing, although there is a guideline against using templates in signatures. {{3x|p}}ery (talk) 21:27, 5 April 2018 (UTC)[reply]
Correction: your search is specific to article space. There are three userpages using {{bad}} without parameters. {{3x|p}}ery (talk) 21:32, 5 April 2018 (UTC)[reply]
Yeah, I was about to correct that. I was sorting out my sig business. But those can easily be changed, and the template obviously duplicates the functionality of {{no}}. E to the Pi times i (talk | contribs) 21:36, 5 April 2018 (UTC)[reply]
@Pppery: Okay, just wanted to give a heads-up on reviewing the problems with my previous edits. #1 and #2 were obvious, and could have been gleaned from more closely reviewing {{bad}} and {{no}} (I especially shouldn't have deleted that in {{bad}}, though its not a highly-transcluded template (~500 or so transclusions), so fortunately minimal harm was done. If the template more transclusions, I would have done testcases before requesting edit.) For #3, I'll be sure to keep the {{ in mind when crafting future regex; I only use that scheme instead of \{\{ because it's slightly more efficient on some regex engines. Regarding #4, I missed that in my preferences, it has since been corrected. #5 seemed weird at first but it makes sense now (obviously, it's because of the | being interpreted as pipes.) I appreciate your help greatly. In theory, I am not this scattered normally. E to the Pi times i (talk | contribs) 21:52, 5 April 2018 (UTC)[reply]
Retrieved from "https://en.wikipedia.org/w/index.php?title=Wikipedia:Templates_for_discussion/Log/2018_April_5&oldid=834467186"