Module talk:Coordinates/Archive 2

Archive 1

Archive 2

TPE on 11 Sep 2016

Could the sandbox versions of this module and {{Coord}} be merged into the main versions of each? This change would move the parser function {{#coordinates:}} into the module, allowing Wikidata to be used without generating errors, and would allow coordinates with latitude before longitude. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 16:23, 11 September 2016 (UTC)

@Jc86035: Some questions before a potential sync, since this is is very heavily transcluded. 1. What has been the extent of your testing and validation that your change in the module (and removal in the template) works correctly? 2. Despite WP:PERF, Could it have been possible to request this change in August and do a more cumulative sync to avoid having to edit twice to avoid server strain when possible? — Andy W. (talk · ctb) 17:18, 11 September 2016 (UTC)

@Andy M. Wang: Removing edit request; there are a few changes I'd like to make to the p._coordinsert function first. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 02:14, 12 September 2016 (UTC)

@Andy M. Wang: Reactivated edit request; additional changes didn't work. Tested original conditions in Module talk:Coordinates/testcases (all test failures are due to the addition of the parser function and are expected) and Template:Coord/testcases. (TL;DR: Could the sandbox versions of this module and {{Coord}} be merged into the main versions of each?) Thanks, Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 13:27, 13 September 2016 (UTC)

Synced module and template. Ping/reopen if there are pending issues, cheers — Andy W. (talk · ctb) 15:50, 13 September 2016 (UTC)

Undid, followed up on your talk — Andy W. (talk · ctb) 16:10, 13 September 2016 (UTC)

Usage of Module:Coordinates in Module:HS listed building results in error

Hi! There seems to be an issue with the Module:Coordinates after I added picture and Commonscat for an item in the List of Category A listed buildings in Highland. I'm not quite sure if this is a mistake on my side, but even looking at old versions of the list I still get the same error message "Lua error in Module:Coordinates at line 657: Tried to read nil global frame.". Does anyone here know how to fix this? Would be much appreciated! Braveheart (talk) 14:44, 20 September 2016 (UTC)

Backed out (for now, don't know if I have time to look into this) — Andy W. (talk · ctb) 16:00, 20 September 2016 (UTC)

@Andy M. Wang: This could probably be solved (rather quickly) by modifying HS listed building to use {{Coord}} instead of this module + the #coordinates: parser function. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 16:02, 20 September 2016 (UTC)

@Jc86035: I set up a sandbox at for the HS listing building templates/modules that call the coordinates sandbox. Can test at Template:HS listed building row/testcases to make sure the nil global frame issue can be fixed by your suggestion. — Andy W. (talk · ctb) 16:09, 20 September 2016 (UTC)

@Jc86035: A list of modules that looks to be tangentially related or possibly be affected by the change. (very rough list, didn't go further into detail): Module:FindFeatures, Module:FindFeatures/displayDatabase, Module:Geobox coor, Module:HS listed building (error reported), Module:Location map, Module:WikidataCoord, Module:Parameters, Module:OSM, Module:WikidataIB, Module:Solar eclipse, Module:Wikidata2. Modules like Module:WikidataIB, Module:Geobox coor, and Module:Solar eclipse call expandTemplate on coord. I can't tell if any other module is using Coordinates like HS listed building is. A bit busy right now, but may find the time still to call the module directly rather than the template, which I believe is better practice — Andy W. (talk · ctb) 17:51, 20 September 2016 (UTC)

@Andy M. Wang: I think HS listed building is likely the only module which calls Module:Coordinates directly, so none of the others should be affected. In any case, their uses would show up in Category:Pages with script errors. My Lua skills do not extend very far beyond the Ustring library, regular expressions and concatenating HTML, so it's probably up to a more experienced coder to do this. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 11:09, 21 September 2016 (UTC)

Never mind, I didn't notice that Jackmcbarn fixed it. Hopefully I haven't introduced any other weird errors in the module. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 11:14, 21 September 2016 (UTC)

Synced again, didn't find any other compatibility issues — Andy W. (talk · ctb) 04:59, 22 September 2016 (UTC)

I just updated Module:Geobox coor to use this module directly. please revert and let me know if there are any serious problems. Frietjes (talk) 14:36, 20 October 2016 (UTC)