Module talk:Coordinates/Archive 2

Archive 1

Archive 2

TPE on 11 Sep 2016

Could the sandbox versions of this module and {{Coord}} be merged into the main versions of each? This change would move the parser function {{#coordinates:}} into the module, allowing Wikidata to be used without generating errors, and would allow coordinates with latitude before longitude. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 16:23, 11 September 2016 (UTC)

@Jc86035: Some questions before a potential sync, since this is is very heavily transcluded. 1. What has been the extent of your testing and validation that your change in the module (and removal in the template) works correctly? 2. Despite WP:PERF, Could it have been possible to request this change in August and do a more cumulative sync to avoid having to edit twice to avoid server strain when possible? — Andy W. (talk · ctb) 17:18, 11 September 2016 (UTC)

@Andy M. Wang: Removing edit request; there are a few changes I'd like to make to the p._coordinsert function first. Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 02:14, 12 September 2016 (UTC)

@Andy M. Wang: Reactivated edit request; additional changes didn't work. Tested original conditions in Module talk:Coordinates/testcases (all test failures are due to the addition of the parser function and are expected) and Template:Coord/testcases. (TL;DR: Could the sandbox versions of this module and {{Coord}} be merged into the main versions of each?) Thanks, Jc86035 (talk) Use {{re|Jc86035}}
to reply to me 13:27, 13 September 2016 (UTC)

Synced module and template. Ping/reopen if there are pending issues, cheers — Andy W. (talk · ctb) 15:50, 13 September 2016 (UTC)

Undid, followed up on your talk — Andy W. (talk · ctb) 16:10, 13 September 2016 (UTC)