Talk:Cohen–Sutherland algorithm
Appearance
what is outcode is the point is on the line x=xmin or x=xmax or y=ymin or y=ymaz ? please help me
It has to be INSIDE when it's on the boundary, otherwise the loop will never terminate (unless both points are initially INSIDE.) 2620:79:0:165:1A03:73FF:FE20:3C3B (talk) 01:30, 13 November 2012 (UTC)
Implementation
if (!(outcode0 | outcode1)) { // Bitwise OR is 0. Trivially accept and get out of loop
Wouldn't logical OR be faster and more intuitive here? Also, shouldn't the whole algorithm be rewritten using Allman indentation style? And the last point, shouldn't we use use more structured approach? while (true) and breaks may be not friendly for beginners. My opinion. FaTony (talk)