Jump to content

Talk:Overlap–save method

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
This is an old revision of this page, as edited by Sascha.spors (talk | contribs) at 13:58, 16 January 2015 (→Dubious: new section). The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.
WikiProject iconComputing Unassessed
WikiProject iconThis article is within the scope of WikiProject Computing, a collaborative effort to improve the coverage of computers, computing, and information technology on Wikipedia. If you would like to participate, please visit the project page, where you can join the discussion and see a list of open tasks.ComputingWikipedia:WikiProject ComputingTemplate:WikiProject ComputingComputing
???This article has not yet received a rating on Wikipedia's content assessment scale.
???This article has not yet received a rating on the project's importance scale.

new pseudocode, Mar 5, 2014

Yes, the previous algorithm is "simple", which is a good thing. The difference is that it chooses the FFT size (N) in an optimal way, and derives the arbitrary segment length (L) accordingly. No zero-padding is necessary, so the claim "circular convolution used in it may be wrong, because we should pad zeroes in the head at initial step" is wrong and misleading. Your more-complicated algorithm, prioritizes the choice of L above the FFT size, P, (an important performance parameter). The claim that your inefficient and complicated code achieves the same result as conv(•) (as does the efficient, simple code) is not sufficient.
--Bob K (talk) 20:07, 5 March 2014 (UTC)[reply]

Dubious

The figure illustrating the overlap-save algorithm is misleading/wrong

  • the vertical axis labels indicate that the signals have an offset. The mean value seems to be 1. However, the convolution result itself indicates that the signals have zero-mean. Most likely the vertical axis is wrongly labeled. The labels should 0,1,2 should be replaced by -1,0,1.
  • the double arrow below the horizontal axis is misleading. The arrows should be removed or only the one pointing to the right should be shown
  • the length of the segments is not clear. From the caption it seems to 100 taps, but the red portion of the upper plot indicates a different length
  • it is not clear which part is overlapping from the previous segment
  • the impulse response should also be shown

Sascha.spors (talk) 13:58, 16 January 2015 (UTC)[reply]

Retrieved from "https://en.wikipedia.org/w/index.php?title=Talk:Overlap–save_method&oldid=642766023"