Talk:Shanks's square forms factorization
 | This article needs attention from an expert on the subject. Please add a reason or a talk parameter to this template to explain the issue with the article. |
This algorithm is somewhat vague and seems incomplete. Furthermore, it does not seem very efficient (or perhaps I did not implement it very well; my implementation took substantially longer than a brute force simple factorization).
I could not check the external link to verify the correctness of this article. This merits review. -- Aprogressivist 19/06/2006
I think that the P's and Q's are not the same variables in the two stages of the solver. BTW, I see identifiers like a, b, n, and so on reused to mean different things wihtin the same article a lot in math articles - maybe I should make that a sub-project of Mathematics. Walt 02:17, 23 June 2006 (UTC)