Module talk:WikiProject banner/Archive 3

Archive 1

Archive 2

Archive 3

Archive 4

Archive 5

→

Archive 10

Padding

User:PC78 reports that Template:WikiProject Korea/sandbox looks like this on his/her browser (Internet Explorer):

I thought this padding issue had been resolved? Martin 00:09, 2 January 2009 (UTC)

Me too, but then again I use a proper browser :D.  Fixed Happy‑melon 11:23, 2 January 2009 (UTC)

Looks better. Cheers! PC78 (talk) 12:29, 2 January 2009 (UTC)

WikiProject Merseyside

I've attemted a conversion of this project's banner at Template:WikiProject Merseyside/sandbox. It all looks good to me, but can someone more familiar with the meta cast an eye over it? I'd like to be sure before I switch the code over, and avoid any potential screw-ups. Thanks in advance! Small-town hero (talk) 22:17, 2 January 2009 (UTC)

Looks pretty good! But the colour of the Wikipedia:WikiProject Merseyside/Collaboration link suggests to me that you are not using this collaboration of the month thing, so maybe these should be fixed or removed? Ditto for Wikipedia:WikiProject Merseyside/Merging. As you are using so many of the extended quality classes, I might suggest that it would be simpler to use them all and do away with the custom class that you have created. Regards, Martin 23:33, 2 January 2009 (UTC)

I dunno, I'd prefer to keep things as they are in the current template - they can always be dealt with later. This is still a relatively new WikiProject after all. :) Since everything seems to be in order I'm going to go ahead with the switch. Cheers! Small-town hero (talk) 01:49, 3 January 2009 (UTC)

Another Padding Comment

Module:WikiProject banner/doc
This page is a soft redirect.

Module:WikiProject banner/doc
This page is a soft redirect.

There's a little bit of a difference with the border on the left when comparing the WPBannerMeta and Tmbox template. Should a bigger left border be added to WPBannerMeta? -- WOSlinker (talk) 13:20, 2 January 2009 (UTC)

I don't think the border should be bigger necessarily. But perhaps it ought to be the same as the border on the right, which it currently isn't (on my browser anyway). Martin 16:16, 2 January 2009 (UTC)

The main difference is that the quality/importance rows have backgrounds that fill the entire cell; IMO it looks a bit wierd having a huge border between them and the banner border. I agree that the right image should have the same padding as the left image, I'll have a look at that. Happy‑melon 16:38, 2 January 2009 (UTC)

I synchronised the padding left and right. What do people think about it overall? Happy‑melon 18:38, 3 January 2009 (UTC)

Looks better now that left & right match. Not too bothered about matching with tmbox. -- WOSlinker (talk) 19:22, 3 January 2009 (UTC)

Infobox parameter

So far as I can tell, the infobox parameter will always display the following text:

This page has been marked as needing an infobox.

Is it possible to have it use "article" instead of "page" where appropriate (to make it consistant with other uses of article/page/whatever in the banner)? Also, would it be possible to define custom text and even images for this parameter? This could be useful for a WikiProject to link to a specific template or page, for example. PC78 (talk) 02:11, 3 January 2009 (UTC)

It looks like there are two occurences of {{ns:0}} in WPBannerMeta/core that need changing to {{ns:1}} to fix the article/page issue. If you want to use more options for the infobox then there is always the option to use the note 1 parameters instead.

|note 1 = {{{needs-infobox|}}}
 |NOTE_1_TEXT     = This {{#switch:{{NAMESPACE}}|{{ns:0}}=article|page}} has been marked as needing an [[Template:Tulip Infobox|infobox]].
 |NOTE_1_IMAGE    = Nuvola apps arts.png
 |NOTE_1_CAT      = Tulip articles needing infoboxes. 

-- WOSlinker (talk) 10:50, 3 January 2009 (UTC)

What if notes 1-5 are already used? Is it possible to specify more? PC78 (talk) 13:17, 3 January 2009 (UTC)

There's a |HOOK_NOTE= parameter which can be used to add further notes. See example below: -- WOSlinker (talk) 13:44, 3 January 2009 (UTC)

{{WPBannerMeta
|PROJECT          = Tulips
 |small  = {{{small|}}}
 |category={{{category|¬}}}
 |listas = {{{listas|}}}
|note 1 = {{{audio-file|}}}
 |NOTE_1_TEXT     = An audio file has been created of this article.
 |NOTE_1_IMAGE    = Nuvola apps arts.png
 |NOTE_1_CAT      = Tulip articles with audio files
|note 5 = {{{infobox|}}}
 |NOTE_5_TEXT     = An infobox needs to be added to this article.
 |NOTE_5_IMAGE    = Diamond-caution.svg
 |NOTE_5_CAT      = Tulip articles without infoboxes
|HOOK_NOTE={{WPBannerMeta/hooks/notes
 |category={{{category|μ}}}
 |note 1={{{navbox|}}}
  |NOTE_1_TEXT          = An navbox needs to be added to this article.
  |NOTE_1_IMAGE         = Diamond-caution.svg
  |NOTE_1_CAT           = Tulip articles without navboxes
 |note 5={{{otherbox|}}}
  |NOTE_5_TEXT          = An otherbox needs to be added to this article.
  |NOTE_5_IMAGE         = Diamond-caution.svg
  |NOTE_5_CAT           = Tulip articles without otherboxes
 }}
}}

Gotcha. Cheers! PC78 (talk) 17:35, 3 January 2009 (UTC)

Another article/page issue

Could the WPBannerMeta/importancescale be altered so that "This article has been" is changed to "This {{#if:{{SUBJECTSPACE}}|page|article}} has been", so that it matches WPBannerMeta/qualityscale. Thanks. -- WOSlinker (talk) 12:47, 3 January 2009 (UTC)

 Done Happy‑melon 17:07, 3 January 2009 (UTC)

A couple of things...

1. Could the text for NA quality be changed to "This page is not an article and does not require a rating on the quality scale.", as per other non-article classes and NA importance? This would be useful where NA-Class is used in the article space in lieu of Disambig-Class or Redirect-Class.
2. When NA quality is used in the article space, the forced comment message is suppressed. Would it be possible/desirable to suppress the forced message for other non-standard quality grades as well?

Cheers! PC78 (talk) 17:50, 3 January 2009 (UTC)

Point 1 has now been fixed I believe. I don't quite understand point 2: what do you mean by "forced comment message"? Martin 18:32, 3 January 2009 (UTC)

The "please leave comments here..." message that appears if no comments exist and |COMMENT_FORCE= is set. Now disabled for Redirects and Disambigs. Any others? Happy‑melon 18:38, 3 January 2009 (UTC)

Thanks for that. PC78 (talk) 19:11, 3 January 2009 (UTC)

Collapsed section

In the Collapsed section, |c note 1= & |c note 2= don't work as there are two spaces missing from WPBannerMeta/core.

Could the following be changed from

{{#if:{{{COLLAPSED_TEXT|}}}{{#switch:{{{c note1|}}}{{{c note2|}}}{{{c note 3|}}}{{{c note 4|}}}{{{c 
note 5|}}}||¬|¬¬|¬¬¬|¬¬¬¬|¬¬¬¬¬=|yes}}

to

{{#if:{{{COLLAPSED_TEXT|}}}{{#switch:{{{c note 1|}}}{{{c note 2|}}}{{{c note 3|}}}{{{c note 4|}}}{{{c 
note 5|}}}||¬|¬¬|¬¬¬|¬¬¬¬|¬¬¬¬¬=|yes}}

Thanks. -- WOSlinker (talk) 23:37, 3 January 2009 (UTC)

Oops, that was this edit. Well spotted WOSlinker (what is a WOS linker?) Martin 09:17, 4 January 2009 (UTC)

Well spotted.  Fixed Happy‑melon 10:17, 4 January 2009 (UTC)

Well, WOS stands for World of Spectrum. When I first started, I was just adding links to a number of computer games articles. But since then I done a few other things. -- WOSlinker (talk) 11:44, 4 January 2009 (UTC)

You certainly have :) Martin 12:06, 4 January 2009 (UTC)

B-class checklist niggle

If none of the B-class checklist parameters are used, then the following is displayed:

| b1 <!--Referencing & citations--> = <yes/no>
| b2 <!-- Coverage and accuracy --> = <yes/no>
| b3 <!-- Structure             --> = <yes/no>
| b4 <!-- Grammar and style     --> = <yes/no>
| b5 <!-- Supporting materials  --> = <yes/no>
| b6 <!-- Accessible            --> = <yes/no>

However, not all projects use the same parameters (for example, some use B-Class-1, B-Class-2, etc.) so this may be incorrect. I was just thinking that Talk:East Prussia might really confuse someone who is trying to rate it as B-class. Martin 11:57, 4 January 2009 (UTC)

Ouch! I can see the issue, but I think trying to play with the default message is asking for a world of pain with optional parameters flying everywhere. Isn't the simplest method to make sure each banner supports this set of parameters, whatever their 'primary' parameters may be? Happy‑melon 13:28, 4 January 2009 (UTC)

Yes, maybe, but that will involve updating all banners which use the checklist which could also be very painful! Martin 13:34, 4 January 2009 (UTC)

There aren't actually that many of them. Happy‑melon 16:01, 4 January 2009 (UTC)

Okay, this should be possible then. Shall we just change any non-standard ones to

|b1={{{B-Class-1|{{{b1|}}}}}}

etc. I've noticed some using B1, B2, etc. I suppose parameters are case=sensitive? Martin 17:48, 4 January 2009 (UTC)

Yes, that looks good. Parameter names are case-sensitive, although the parameter values are not. Happy‑melon 17:51, 4 January 2009 (UTC)

Huh? That doesn't sound right. Parameter values are case-sensitive, otherwise we wouldn't need to use constructs such as {{lc:{{{class}}} }}. Martin 10:30, 5 January 2009 (UTC)

Sorry, I meant that parameter values are case-insensitive because we use the lc: construct everywhere :D. There's no equivalent construct to make parameter names case insentitive, unfortunately. Happy‑melon 10:38, 5 January 2009 (UTC)

 Done. All banners using the checklist have been fixed, and the documentation has been updated to prevent this problem in the future. Martin 16:06, 5 January 2009 (UTC)

class=Image

Would it be possible for class=Image to also recognize class=File after our namespace change? Just a thought. §hep • ¡Talk to me! 22:19, 5 January 2009 (UTC)

Yes :D  Done Happy‑melon 22:55, 5 January 2009 (UTC)

Thanks. §hep • ¡Talk to me! 23:18, 5 January 2009 (UTC)

listas={{{listas|}}}

It says in the template doc that listas={{{listas|}}} is required for the template to work. I was wondering if this changes means that {{OH-Project}} needs updated to include this? Is this a recent thing? I don't remember it always being required or even existent. §hep • ¡Talk to me! 19:59, 22 December 2008 (UTC)

This functionality should really be included in all banners, notwithstanding the fact that it is currently broken :D. I am waiting on a MediaWiki configuration change (Template:Bug) to make it possible to use this system efficiently. But there's no reason not to include it. The banner isn't going to explode if you don't use this feature, but equally it's not going to do any harm if you do. You don't even have to document it if you don't want to encourage its use. Happy‑melon 13:30, 23 December 2008 (UTC)

If you could include it that'd be great and I'd be more than happy to doc it. I just can't touch the template in its current state... Thanks. §hep • ¡Talk to me! 21:06, 25 December 2008 (UTC)

 Done Happy‑melon 21:41, 25 December 2008 (UTC)

Thanks. §hep • ¡Talk to me! 21:41, 25 December 2008 (UTC)

I have found a number of instances where the WP Greece banner does explode if it does not have a value for the listas parameter but a banner above it, especially WP Biography, does have a value for the listas parameter. It is not a pretty sight.

I firmly believe that all banners should use the listas parameter, rather than the hodge-podge that now exists. I further believe that all banners should have nested=yes.

Although I am working to clean it out Category:Pages with DEFAULTSORT conflicts may have examples of the above. Within the last 12 hours a bot has completed the listas parameter in only the WP Biography template. See what a mess can be made.

JimCubb (talk) 16:27, 6 January 2009 (UTC)

The |nested= parameter is completely superfluous on WPBannerMeta banners; you can include or not include it at your pleasure, but if you experiment you'll see that it has no effect whatsoever: moving a WPBannerMeta banner inside a banner shell collapses it automagically. As for listas, note that this functionality is currently somewhat broken (see #listas functionality below; we're waiting on a MediaWiki configuration change that will make it much easier to fix listas conflicts both here and with other banners. Your comments in that thread would be very much appreciated. Happy‑melon 16:35, 6 January 2009 (UTC)

listas functionality

On the to-do list, there is check listas functionality.

It looks to me as it's not quite doing which it should be. Although there is some code in WPBannerMeta/core which does {{#if:{{{listas|}}}|{{DEFAULTSORT:{{{listas}}}}} }}, anywhere that a category is set, it is overriding the default sort with the {{PAGENAME}} value. For example [[Category:{{{MAIN_CAT}}}|{{PAGENAME}}]]

I think if {{#if:{{{listas|}}}|{{DEFAULTSORT:{{{listas}}}}} }} was moved from WPBannerMeta/core to WPBannerMeta and then in WPBannerMeta listas was passed to core as |listas = {{{listas|{{PAGENAME}}}}} and also the listas parameter passed through to the other subpages as well, then category setting code could be changed to override to the listas value, For example [[Category:{{{MAIN_CAT}}}|{{{listas}}}]]

Would that be better?

-- WOSlinker (talk) 19:20, 5 January 2009 (UTC)

The todo should probably be "fix listas functionality", it is currently as you say completely broken. I'm actually waiting for Template:Bug, which will make the whole issue a hell of a lot easier (we'd just need to remove the sortkeys altogether). The solution you propose would fix the problem, but it would require passing parameters around that will become superfluous in the (hopefully) near future. I can 'fix' it if there's a pressing need for it, but I'm not aware of many projects that actively use this feature at the moment... Happy‑melon 20:04, 5 January 2009 (UTC)

No pressing need, although if you moved the {{#if:{{{listas|}}}|{{DEFAULTSORT:{{{listas}}}}} }} bit from core into the main template, there wouldn't be any need to pass listas over to core. -- WOSlinker (talk) 20:29, 5 January 2009 (UTC)

On the contrary, you'd have to pass 'listas', defaulting to {{PAGENAME}}, everywhere you wanted a category, so it could be specified as a sortkey. It would be messy :D Happy‑melon 22:51, 5 January 2009 (UTC)

I'm meaning after Template:Bug is fixed. -- WOSlinker (talk) 19:05, 6 January 2009 (UTC)

Ah, I see. Then yes, as you say, after the bug is fixed it will be very easy; move the listas code as you say, and remove all the sorkeys from all the subtemplates. Happy‑melon 20:02, 6 January 2009 (UTC)

COLLAPSED_TEXT issue

If both the |COLLAPSED_TEXT= and |c note 1= parameters are used then the template doesn't quite look right. There's a small change that you need to make to /core to fix it. In the code below, I think you need to change the "2" to a "3".

{{#if:{{{COLLAPSED_TEXT|}}}|
<tr><td colspan=2>
{{{COLLAPSED_TEXT}}}
</td></tr>
}}

See Template:WP UK Politics for an example of the problem. -- WOSlinker (talk) 22:11, 6 January 2009 (UTC)

Hmn... This probably masks a deeper problem (like why collapsible notes and the collapsible text are in the same collapse box to start with...). I'm wondering (entirely unrelated to this) whether to spin off the C_NOTES as a hook and add some more normal notes and taskforces instead, since they seem to be far more popular... something to investigate. Thanks for the fix though. Happy‑melon 22:33, 6 January 2009 (UTC)

On a slightly separate note, I've created a new hook at Template:WPBannerMeta/hooks/todolist which can be used to replace a lot of the uses of collapsible text. I've got a list of about 20 or so banners which are using collapsible text which I could convert over to this hook. It also allows for more than one collapsible text section by just adding the hook twice. -- WOSlinker (talk) 22:55, 6 January 2009 (UTC)

I've now converted all those templates I could find that were using COLLAPSED_TEXT over to this new hook. Perhaps you could add a tracking cat to see if anything is left using COLLAPSED_TEXT and also add some protection to the hook template. Thanks -- WOSlinker (talk) 23:13, 8 January 2009 (UTC)

Done, enjoy Category:WPBannerMeta banners using collapsed text. They're sorted by namespace. Happy‑melon 11:04, 9 January 2009 (UTC)

Just remove wpb from the CLASS' values of the first TABLE and the collapsible text will function properly. <table class="tmbox tmbox-notice collapsible innercollapse wpb"> –pjoef (talk • contribs) 10:16, 9 January 2009 (UTC)

But then it won't collapse inside banner shells. Kind of throwing the baby out with the bathwater :D Happy‑melon 10:57, 9 January 2009 (UTC)

{{WPMIX}}

In order for this project's assessments to be properly tallied and logged per the WP:1.0 team, it needs to be revamped so that it uses the {{WPBannerMeta}}template for its tag. So I need this template converted over to WPBannerMeta, can anyone help? --Jeremy ( Blah blah...) 07:13, 7 January 2009 (UTC)

I see you've already made a start in Template:WPMIX/Sandbox. Well, I've made some changes to that but there's still more more than needs doing to it. Looks like you've need a custom class hook setting up for the Needed, Merge & Afd classes (if you still want to use them). -- WOSlinker (talk) 23:08, 8 January 2009 (UTC)

Also, Template, Redirect, Cat & Dab classes are listed on the template docuemtation but not on the assesment page. -- WOSlinker (talk) 23:11, 8 January 2009 (UTC)

I had just copy and pasted the basic template to the page before I went to work, I am looking to use the full extended WP:1.0 assessments in the template. I was going to work on it in my spare time in the next couple of days. --Jeremy ( Blah blah...) 05:00, 9 January 2009 (UTC)

What's a lista?

What does the listas parameter do for WPBannerMeta?--Ipatrol (talk) 20:52, 8 January 2009 (UTC)

It kind of works as a defaultsort for banner categories. For a working verson check out {{WPBIO}} §hep • ¡Talk to me! 17:32, 9 January 2009 (UTC)

extra | in importance

High, mid and low importance ratings have gained an extra | in the rating box, eg Talk:Australian dollar. Template:WikiProject Business & Economics is particularly badly affected, with some text missing eg Talk:Bank of New York Mellon Corporation. TRS-80 (talk) 18:16, 11 January 2009 (UTC)

 Fixed nothing to do with WPBM: [1]. Happy‑melon 18:32, 11 January 2009 (UTC)

Quality Hooks

Currently, there are two hooks for adding extra quality scales into a banner: {{WPBannerMeta/hooks/qualitycats}} and {{WPBannerMeta/hooks/additquals}}. Just wondering if there is really a need for both versions. We just really need one. Which one is best? -- WOSlinker (talk) 09:37, 12 January 2009 (UTC)

/aditquals is less cleanly-coded (missing case-insensitivity, etc), but /qualitycats can only handle one set of categories at a time. Which one is more widely used? Happy‑melon 10:29, 12 January 2009 (UTC)

All there appears to be is one use of each: qualitycats, additquals. -- WOSlinker (talk) 10:50, 12 January 2009 (UTC)

It was a pretty marathon effort (I had about ten catgory warning boxes under the template at one point!) but I converted WPBeatles to use /qualitycats, so /additquals is unused. Msjg, do you mind if we delete in the interests of cleanliness, rather than redirecting? Happy‑melon 12:14, 12 January 2009 (UTC)

You've gone and used {{WPBannerMeta/qualityscale}} in WPBeatles. So do we actually need either hook? -- WOSlinker (talk) 12:38, 12 January 2009 (UTC)

Argh! On a pure technical level, no we don't, in the same way we don't need /hooks/notes or /hooks/taskforces. They're just wrappers for the internal templates. But they're wrappers that we need, because otherwise if we change the way things feed into the internal subtemplates, we have to update every banner that calls the subtemplates directly. If there's a complete and consistent 'shell' around the 'core' functions, we only need to ensure that the two interface with each other properly, and don't have to go hunting all over wikipedia to find the wierd and wonderful ways people have used the core templates directly. So while they might just be wrappers at the moment, it's still important to have them, and use them. So I've updated WPBeatles, and fixed the /hooks/qualitycats documentation that prompted me to use the internal template in the first place :D Happy‑melon 13:15, 12 January 2009 (UTC)

No, I don't mind. It's good to be clean. A problem with the Beatles template, as I noted here last year is that FQS is selectively used. I don't think you have sorted this problem yet. Martin 13:06, 12 January 2009 (UTC)

Thanks. Indeed not, that's a problem, and one that's become more difficult to fix with the new class masks... Hmn.... Happy‑melon 13:19, 12 January 2009 (UTC)

Of course, if you call the taskforce hook, you can specify FQS separately. Martin 13:20, 12 January 2009 (UTC)

Funny spacing

On my browser the two NA's are not aligned in this banner: {{WP Crime}}

That was quick! Martin 13:38, 12 January 2009 (UTC)

I'm bored :D Happy‑melon 13:40, 12 January 2009 (UTC)

WPBannerMeta/hooks/priorityscale

In the hook, Template:WPBannerMeta/hooks/priorityscale, could the importance parameter be changed from

 |importance={{{importance|}}}

to

 |importance={{WPBannerMeta/importance|{{{importance|}}}|{{{class|}}}}}

as currently, it's use on {{Business}} doesn't quite work properly on some pages. Thanks. (PS: Once it's fixed, {{WikiProject Mathematics}} could also use it) -- WOSlinker (talk) 21:51, 12 January 2009 (UTC)

Also, PROJECT_LINK can be removed as it doesn't do anything. And is there any reason why SHOW shouldn't always be YES and not a parameter as well? -- WOSlinker (talk) 21:57, 12 January 2009 (UTC)

The 'invisible' version is used on eg {{WPBeatles}}. Rest is  Done Happy‑melon 22:11, 12 January 2009 (UTC)

Just wondering if the following would be better, which would then show the scale on the template page (as the importance scale usually is).

<includeonly>{{#ifeq:{{{BANNER_NAME}}}|{{FULLPAGENAME}}|{{#ifeq:{{{category|¬}}}|¬|<!--
Template Version -->{{WPBannerMeta/importancescale
 |importance={{WPBannerMeta/importance|High|{{{class|}}} }}
 |class={{{class|}}}
 |SHOW={{{SHOW|}}}
 |BANNER_NAME={{{BANNER_NAME}}}
 |ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}
 |ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}
 |category=no
 |{{#if:{{{IMPORTANCE_SCALE_NAME|}}}|IMPN|xxx}}={{{IMPORTANCE_SCALE_NAME|}}} 
}}|<!--Core Version -->{{WPBannerMeta/importancescale
 |importance={{WPBannerMeta/importance|{{{importance|}}}|{{{class|}}} }}
 |class={{{class|}}}
 |SHOW={{{SHOW|}}}
 |BANNER_NAME={{{BANNER_NAME}}}
 |ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}
 |ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}
 |category={{{category|¬}}}
 |{{#if:{{{IMPORTANCE_SCALE_NAME|}}}|IMPN|xxx}}={{{IMPORTANCE_SCALE_NAME|}}} 
}}}}|<!--Core Version -->{{WPBannerMeta/importancescale
 |importance={{WPBannerMeta/importance|{{{importance|}}}|{{{class|}}} }}
 |class={{{class|}}}
 |SHOW={{{SHOW|}}}
 |BANNER_NAME={{{BANNER_NAME}}}
 |ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}
 |ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}
 |category={{{category|¬}}}
 |{{#if:{{{IMPORTANCE_SCALE_NAME|}}}|IMPN|xxx}}={{{IMPORTANCE_SCALE_NAME|}}} 
}}}}</includeonly><noinclude>
{{documentation}}
</noinclude>

-- WOSlinker (talk) 22:19, 12 January 2009 (UTC)

 Done, kinda. I tweaked the code a bit to remove duplication, but it's essentially yours. Good idea: we should try and do that for the other hooks as well. Happy‑melon 22:55, 12 January 2009 (UTC)

Documentation and To-Do Lists

Someone might want to change the Documentation from showing to-do lists as to be done with Collapsed section to do it with the HOOK_BOTTOM settings. Peachey88 ^{(Talk Page | Contribs)} 00:12, 13 January 2009 (UTC)

Hi, I've changed the docs for that section a bit & added a note about the hook for todo lists. -- WOSlinker (talk) 07:45, 13 January 2009 (UTC)

Collapsed notes

In the COLLAPSED_TEXT_issue section above, it was mentioned that it might be worth spinning off the C_NOTES as a hook. If that's worth doing, then could another hidden category be added, so that they could be converted over to using WPBannerMeta/hooks/notes against |COLLAPSED_HOOK=.

{{#if:{{{c note 1|}}}{{{c note 2|}}}{{{c note 3|}}}{{{c note 4|}}}{{{c note 5|}}}|[[Category:WPBannerMeta banners using collapsed notes|{{NAMESPACE}} {{PAGENAME}}]]}}

thanks -- WOSlinker (talk) 12:27, 13 January 2009 (UTC)

I know, why don't we add tracking categories to monitor every parameter... :D Happy‑melon 12:52, 13 January 2009 (UTC)

What's the rationale behind all this converting of collapsed things into hooks? Martin 13:13, 13 January 2009 (UTC)

If they're not widely used, the code bytes would be better off given over to extra taskforces, which I know are in heavy demand (and are more complicated to hook, since they need two separate hooks). I should say, WOSlinker, don't change anything yet until we see how many templates actually use the cnotes. Happy‑melon 14:57, 13 January 2009 (UTC)

I won't change anything yet. If we go ahead with the change though, the docs could be simplified to the following:

• Example using |c note 1=
• Explain that more than 5 can be added by using |HOOK_NOTE= and {{WPBannerMeta/hooks/notes}}
• Explain that collapsible notes can be added by using |HOOK_COLLAPSED= and {{WPBannerMeta/hooks/notes}}

-- WOSlinker (talk) 15:14, 13 January 2009 (UTC)

"Pages" versus "articles"

The WP:Tennis project seems to use "pages" for Category:Category-Class_tennis_pages, Project-Class tennis pages, Portal-Class tennis pages instead of "articles" like: FA-Class tennis articles, GA-Class tennis articles, etc. This seems "somewhat" coherent to seperate true "articles" from Wikipedia "Pages" that support the functions of Wikipedia. Is there a way to either work this into WPBannerMeta or allow the deviation through a parameter? (or tell me how "|ASSESSMENT_CAT" is supposed to allow this type of naming? -- Mjquin_id (talk) 20:34, 14 January 2009 (UTC)

Unfortunately not at the moment. You can have either "articles" or "pages", but all classes need to be the same. Martin 20:55, 14 January 2009 (UTC)

Another thought...

I think the "edit · history · watch · purge" text looks a little bit clunky where it currently is. Might I suggest the following:

<td style="text-align:left; padding:0px; background-color:white; border:1px solid #c0c090; padding:5px; margin-top:5px;"><sup class=plainlinks><center>[{{fullurl:{{FULLPAGENAME}}/Comments|action=edit}} edit]{{·}} [{{fullurl:{{FULLPAGENAME}}/Comments|action=history}} history]{{·}}  [{{fullurl:{{FULLPAGENAME}}/Comments|action=watch}} watch]{{·}} [{{fullurl:{{FULLPAGENAME}}|action=purge}} purge]</center></sup><br />{{{{FULLPAGENAME}}/Comments}}</td>

which would move this into a centralised position within the actual comments box? In either case, note the unnecessary extra space preceeding the {{·}} templates. PC78 (talk) 19:33, 3 January 2009 (UTC)

IMO, it was better before (apart from the spaces before {{·}}). —Ms2ger (talk) 20:18, 3 January 2009 (UTC)

Reverted. What does everyone else think? Happy‑melon 22:58, 3 January 2009 (UTC)

Could we see the two options side by side? Martin 09:18, 4 January 2009 (UTC)

This should give you a rough idea...

Current:

Proposed:

FWIW I think the bottom one looks neater. PC78 (talk) 12:58, 4 January 2009 (UTC)

I think I prefer the top one, if only because it takes up less room. You've got that orange bar doing not very much - might as well put the links in there. Martin 13:05, 4 January 2009 (UTC)

Changing my mind. Space is not an issue because it won't be displayed unless "show" is clicked. And it is clearer. Hmm, I'm torn. Martin 13:06, 4 January 2009 (UTC)

For one thing I think it's more appropraite to have these links with the actual message. At a glance, with the comments section collapsed, it's not obvious what they're for. PC78 (talk) 13:09, 4 January 2009 (UTC)

Okay, I support this change. Could I also suggest that the template checks not only that the /comments subpage exists but also that it contains something? It's annoying when, occasionally, you go to check a comment and the comments have been blanked. Martin 10:35, 5 January 2009 (UTC)

Would it be better if "purge" was "refresh" like it is on the Todo template? -- WOSlinker (talk) 20:57, 6 January 2009 (UTC)

Probably. Might be an idea to add a link for "view" as well. PC78 (talk) 21:10, 6 January 2009 (UTC)

This edit is to stop the archiving bot, as this thread is not concluded. Martin 15:11, 15 January 2009 (UTC)

Bottom-importance

Some WikiProjects, like WP:WikiProject Comics and WP:WikiProject Dungeons & Dragons, have a "Bottom" importance in addition to the other importance ratings, but that means that they can't use WPBannerMeta for their templates and still have that importance rating. Could functionality for Bottom-importance be added here for use on a WikiProject-by-WikiProject basis, so that groups who want it can use it and people who don't want it can ignore it? Thanks. -Drilnoth (talk) 03:22, 15 January 2009 (UTC)

I have just added Bottom-importance to the D&D template as promised. I'm not sure if it's widely used enough to justify implementation across the board. I know of only you, comics and cricket that use it although I guess there might be others. I know that Happy-melon said he was against custom importance masks, after all the difficulty in adding custom class masks, but let's see what he says ... Martin 14:11, 15 January 2009 (UTC)

(ec) Actually, it seems that {{D&D}} has been altered to allow Bottom-importance anyway, so unless other projects want this it's a moot point. -Drilnoth (talk) 14:12, 15 January 2009 (UTC)

Thanks Martin! -Drilnoth (talk) 14:12, 15 January 2009 (UTC)

I don't have a problem with using custom importance masks per se, just that coding it into the banner itself is computationally very expensive and fiddly, since a correct importance definition requires the class value to have already been normalised; either we create two layers of normalisation before hitting the actual code (messy), or we re-normalise the class value every time we need it for importance calculation (expensive because we have to use #ifexist:). In the situations where a banner is custom-coded to use an importance mask, that's not a problem, because you know that the custom mask will be there, you don't have to check for it. I've tweaked our own /importancescale subtemplate so you can call that instead of a D&D custom one; I'll have a think and see if it's possible to be more elegant than what you've done, but it's a perfectly satisfactory solution. Good thinking, too. Happy‑melon 14:59, 15 January 2009 (UTC)

I'm entirely willing to believe that it's difficult! But I don't quite understand. Importance depends on class but class does not depend on importance. So check the class first, then check the importance. Why would you need to do it twice? Martin 15:09, 15 January 2009 (UTC)

Hang on, I've got it. It would need an "intermediate" layer before the core. Yes, fiddly. Martin 15:10, 15 January 2009 (UTC)

Small errors in importance mask

A couple of small errors in the importance mask have come to light while coding the {{D&D}} template.

1. There is a line that says "RM WHEN THESE ARE UNSUPPORTED" next to some classes which are now unsupported.
2. The switch at the end doesn't work because the namespace begins with a capital letter. (You could save a few bytes by using SUBJECTSPACE here.)

Martin 14:15, 15 January 2009 (UTC)

 Fixed good spot. Happy‑melon 15:01, 15 January 2009 (UTC)

Unrelated error: AUTO_ASSESS_CAT is passed to core, but is not used. Martin 15:07, 15 January 2009 (UTC)

Needed a general overhaul :D Happy‑melon 15:53, 15 January 2009 (UTC)

Excellent. You're on form today. Umm, request two headers up? Martin 16:01, 15 January 2009 (UTC)

Oh, and is there any advantage in being able to specify NO auto-assess category? For example COMMENTS_CAT=none allows that. Martin 16:08, 15 January 2009 (UTC)

That's on the todo list somewhere... during the next blue-moon season... :D it would be a good idea though. Happy‑melon 16:15, 15 January 2009 (UTC)

Chemical Element

I'm working on getting {{Chemical Element}} to use WPBannerMeta at User:Peachey88/Sandbox/016 but i don't think it's possible because it sticks the articles in multiple categories based on its rating, for example a FA class article would be in the following categories FA-Class Chemistry articles and FA-Class chemical elements articles as well as Wikipedia Version 0.5, Wikipedia CD Selection and Natural sciences Version 0.5 articles. So I'm guessing it's not do-able or do you guys have some magic pixie dust wikicode that do can do? Peachey88 ^{(Talk Page | Contribs)} 03:26, 12 January 2009 (UTC)

This should help:

{{WPBannerMeta/qualityscale
  |class={{{class|}}}
  |BANNER_NAME={{subst:FULLPAGENAME}}
  |category={{{category|¬}}}
 |FULL_QUALITY_SCALE = 
 |ASSESSMENT_CAT     = chemical elements articles
}}
{{#ifeq:{{{category|¬}}}|¬|
[[Category:Wikipedia Version 0.5|{{PAGENAME}}]]
[[Category:Wikipedia CD Selection|{{PAGENAME}}]]
[[Category:Natural sciences Version 0.5 articles|{{PAGENAME}}]]
{{WP1.0/assessments|class={{{class}}}|category=Version 0.5}}
}}

-- WOSlinker (talk) 07:49, 12 January 2009 (UTC)

Use {{WPBannerMeta/hooks/qualitycats}} instead of this direct call. The principle is the same, however. Happy‑melon 23:06, 18 January 2009 (UTC)

Some notes and a question

{{editprotected}} I discovered with {{CVU}} that if you don't have to thread {{small}}, {{listas}}, or {{category}}; contrary to what the documentation says. Also, I would like a parameter added to allow the "Portal" prefix to be changed for special WikiProjects. A parameter could be added that has the default of portal, can have its prefix set to any prefix, or if set to "Main" will have no prefix.--Ipatrol (talk) 00:58, 16 January 2009 (UTC)

You do need to pass the small and category parameters. Listas as well, although it doesn't do anything at the moment, it will in the future. Regarding your other requests, can you be more specific? It sounds like a request specific to your project and so does not need the meta to be modified. I'm disabling the editprotected for now . Martin 08:58, 16 January 2009 (UTC)

Regarding your template, although you do not use any categories, the category=no still has a use (I think) because it will let you put the template on a non-talk page as an example without displaying the warning. You could disable small if you wanted to prevent the small option from ever being used. Anyway these things are specific to your project and do not need changes here. Martin 09:01, 16 January 2009 (UTC)

Weird display error with collapsed section

An error I haven't seen before. With IE7, the banner (e.g. Talk:Banksia brunnea but seems to be all those using the collapsed section) has excess spsace at top and bottom when collapsed. When expanded, the spacing is correct but the "hide" moves to the left. I might have to put a screenshot if other people can't see this! Martin 09:05, 16 January 2009 (UTC)

I reported possibly-related issues a somewhat-long time ago, in an archive not very far, far away. — SMcCandlish [talk] [cont] ‹(-¿-)› 09:51, 16 January 2009 (UTC)

I've got Mozilla and IE both running now and I can confirm it's only a problem on IE. But it looks terrible. Martin 10:18, 16 January 2009 (UTC)

I've posted the screenshots of when the collapsed section is both collapsed and expanded. Note that the box is exactly the same size in each case. Martin 10:31, 16 January 2009 (UTC)

(Gallery removed.) I've made a small change in the core/sandbox which seems to work (but makes the left border slightly bigger).

Current Module:WikiProject banner/doc
This page is a soft redirect.

Sandbox Template:WPBannerMeta/sandbox

-- WOSlinker (talk) 13:22, 16 January 2009 (UTC)

This looks promising. The bottom version does look okay. Martin 15:10, 16 January 2009 (UTC)

Finally! The sandbox version works great! This has been bugging me almost since this template hit the market it seems. §hep • ^Talk 20:28, 16 January 2009 (UTC)

Seems our spiritual leader is not around today. WOS, if you are confident that this will work then you could put an editprotected up. Apart from it looking fine on both browsers I have access to, I don't know enough about it to comment further. Martin 20:32, 16 January 2009 (UTC)

I've made the request but it's sometimes a few days before it gets done anyway.

{{editprotected}} Could a small change be made to Template:WPBannerMeta/core to fix the problem with IE (as described above).

Change the second occurence of {{td}} with <td></td>

Thanks -- WOSlinker (talk) 22:04, 16 January 2009 (UTC)

Does the problem still occur now I've made this tweak? Happy‑melon 14:54, 17 January 2009 (UTC)

Nope, that's broken it. Martin 18:04, 17 January 2009 (UTC)

How interesting. How about the other part?? Happy‑melon 19:03, 17 January 2009 (UTC)

Yes, that's looking okay. Why don't you install IE to test it :P Martin 21:45, 17 January 2009 (UTC)

True... well  Fixed in {{td}}, so hopefully the live template is sorted. Happy‑melon 00:25, 18 January 2009 (UTC)::::

All looking good from this end. Martin 11:29, 18 January 2009 (UTC)

Looks good here too. §hep • ^Talk 22:41, 18 January 2009 (UTC)

Comments' colspan

{{WikiProject banner/Archive 3/comments}} uses colspan="2". This doesn't turn out right when |IMAGE_RIGHT= is used. I would prefer if it changed based on that, but most cells seem to just use 3 in every case. —Ms2ger (talk) 15:07, 18 January 2009 (UTC)

In {{WikiProject banner/Archive 3/core}}, there's also a colspan="2" that I think needs changing as well. (The hide button moves on Talk:Banksia brunnea in IE) -- WOSlinker (talk) 15:51, 18 January 2009 (UTC)

 Fixed both. Took me a while to work out why the one in /core needed to be 3, but it's cos /note uses three columns. Happy‑melon 17:00, 18 January 2009 (UTC)

Suggestion: I've been thinking about creating a subpage for bug reports. Non-controversial things which otherwise clog up this discussion page. Thoughts? Martin 17:08, 18 January 2009 (UTC)

There isn't really much that goes on on this page that aren't bug reports :D We have bug reports, feature suggestions, and "how do I do X" threads, that's about it. I don't think it's got too out of hand, although perhaps we should bump up the autoarchiving... Happy‑melon 20:14, 18 January 2009 (UTC)

I'd be more in favour of slowing the bot down actually! There is a discussion near the top of the page which hasn't reached a conclusion yet (I added an edit the other day to stop it being archived). There are some little things I find (e.g. small non-urgent errors) which don't need the attention of this page. But let's leave for now then. Martin 21:54, 18 January 2009 (UTC)

More on priority vs importance and hooks

While the hooks/priorityscale now works better, it's still not that simple to use and also end up in needing to duplicate parameters in the banner code.

I know it's been mentioned before, but it would be really nice if there were options for a priority scale in the main banner as it would be easier to use (especially for anyone who hasn't used WPBannerMeta much).

|PRIORITY_SCALE      = 
 |priority={{{priority|}}}

and then in /core the code could be placed between IMPORTANCE_SCALE & HOOK_IMPORTANCE.

{{#if:{{{PRIORITY_SCALE|}}}|
{{WPBannerMeta/importancescale|IMPN=priority|importance={{WPBannerMeta/importance|{{{priority|}}}|{{{class|}}} }}|SHOW=yes|BANNER_NAME={{{BANNER_NAME}}}|ASSESSMENT_CAT={{{ASSESSMENT_CAT|}}}|ASSESSMENT_LINK={{{ASSESSMENT_LINK|}}}|PROJECT_LINK={{{PROJECT_LINK|}}}|category={{{category|¬}}} }}
}}

The HOOK_IMPORTANCE option would still stay as it could still be useful sometimes, but there wouldn't be as much need to use it most of the time.

Thoughts? - WOSlinker (talk) 09:33, 13 January 2009 (UTC)

Or, since everything else is the same, the presence of those two parameters just prompts a 'swap' in what's passed to the first /importancescale. I can see that working. Please tell me no one uses a scale other than "importance" or "priority"?? Happy‑melon 10:43, 13 January 2009 (UTC)

I've seen a few (only a about 3 or 4) templates with a |type= parameter which is to be set as Template, Category, Portal, Image, etc. when the banner was used on a non-article talk page, but I don't think that's worth supporting as they should really be using the FQS instead. -- WOSlinker (talk) 11:00, 13 January 2009 (UTC)

It doesn't seem to need much doing to support priority:

In WPBannerMeta/core, could

{{WPBannerMeta/importancescale|

be changed to

{{WPBannerMeta/importancescale|IMPN={{{IMPN|}}}|

and in WPBannerMeta, could

|IMPORTANCE_SCALE    = {{{IMPORTANCE_SCALE|}}}
 |importance={{{importance|}}}

be changed to

|IMPORTANCE_SCALE    = {{{IMPORTANCE_SCALE|}}}
 |importance={{{importance|{{{priority|}}}}}}
|IMPN                = {{#ifeq:{{lc:{{{IMPORTANCE_SCALE|}}}}}|priority|priority}}

then, to use it, all that would be required is |IMPORTANCE_SCALE = priority instead of |IMPORTANCE_SCALE = yes

-- WOSlinker (talk) 20:15, 20 January 2009 (UTC)

Looks good. Would be good to support Priority with a capital P because I've come across that before. Martin 21:11, 20 January 2009 (UTC)

Priority with a capital P can be supported in the Project Banner with |priority = {{{priority|{{{Priority|}}}}}} -- WOSlinker (talk) 21:51, 20 January 2009 (UTC)

You misunderstand. I saw a project (can't remember which now) which used, e.g. Low-Priority xxx articles, rather than Low-priority xxx articles. Martin 22:16, 20 January 2009 (UTC)

I saw one project something similar for Importance recently, so I've just put in a request for a speedy rename after I'd converted the banner. -- WOSlinker (talk) 22:37, 20 January 2009 (UTC)

The only project that uses "Priority" is WikiProject Mathematics. We're not adding something for one project out of 1,400. There are 26 projects by my count that use "priority". You have an interesting idea here, WOSlinker. Happy‑melon 22:39, 20 January 2009 (UTC)

Hooks and class masks

Question: should the class parameter be sent to hooks premasked, or should the hook pass it through the mask? It seems to me that the former is less user-friendly but is more efficient and also allows for custom masks to be used. Martin 21:56, 18 January 2009 (UTC)

Hooks should be responsible for ensuring that all parameters are handled as they would be in the template itself. So hooks should assume that all parameters are being sent in un-normalised, in shorthand notation, and using inverted camelcase :D. Efficiency is secondary to user-friendliness here. Note also that calling {{WPBannerMeta/class}} from a hook actually facilitates using custom masks in the approved manner. Happy‑melon 23:04, 18 January 2009 (UTC)

Hmmm, if you look at my category intersection hook, it would be necessary to call that mask three times! That's terrible efficiency ... Martin 23:46, 18 January 2009 (UTC)

You might have to do qualimpintersect & qualimpintersect/core if you want to process it only once. -- WOSlinker (talk) 00:04, 19 January 2009 (UTC)

That's certainly one solution; it's worked for the main banner :D. I might do that for /hooks/taskforces. Happy‑melon 00:05, 19 January 2009 (UTC)

You could also get them to show on the template page as well then which would be good. - WOSlinker (talk) 07:42, 19 January 2009 (UTC)

Oh, you two are good. Why didn't I think of that? I'll put my hook into a core straightaway. WOS, is there a way to do the templatepage stuff without affecting performance? I worry about having all the extra code on the hook. Martin 13:52, 19 January 2009 (UTC)

Don't panic :D. As long as the code isn't actually being parsed (and unfollowed parserfunction branches are discarded and not evaluated) you're only adding a few hundred bytes of dead code. The performance impact is minimal. It's only when you're A) adding those dead bytes innumerable times, or B) adding code that is parsed and then discarded, that you need to worry. It's a point that we all forget at various times. Happy‑melon 14:23, 19 January 2009 (UTC)

Ah, Happy-melon's favourite essay :P Martin 14:40, 19 January 2009 (UTC)

Actually my favourite essay is WP:SENSE, although it doesn't actually say what most people think it does. I actually care more about performance than WP:PERFORMANCE really condones. Happy‑melon 14:49, 19 January 2009 (UTC)

Right I am now sick of Template:D&D. I lost count of how many times I had to use the custom class and importance masks so I did something which is probably a Bad Idea: put the whole thing into a core. It seems to be working except that the core doesn't think it's the templatepage and I can't work out why not. Any help to make this code more efficient is definitely welcome! Martin 14:53, 19 January 2009 (UTC)

And another thing which is completely annoying me. Sometimes it accepts D&D, other times you have to type D&D and there doesn't seem to be any logic to it. Martin 14:55, 19 January 2009 (UTC)