MediaWiki talk:Wikimediaplayer.js

Fix for link iteration

It is requested that an edit be made to the interface page at MediaWiki:Wikimediaplayer.js. (edit · history · last · links)

This template must be followed by a complete and specific description of the request, that is, specify what text should be removed and a verbatim copy of the text that should replace it. "Please change X" is not acceptable and will be rejected; the request must be of the form "please change X to Y".

The edit may be made by any interface administrator. Remember to change the |answered=no parameter to "yes" when the request has been accepted, rejected or on hold awaiting user input. This is so that inactive or completed requests don't needlessly fill up the edit requests category. You may also wish to use the {{EIp}} template in the response. When the request has been completed or denied, please add the |answered=yes parameter to deactivate the template.

Hi there. An issue was identified at Wikipedia:Village Pump (technical)#Prose size script that I believe is caused by a combination of bad behavior in Internet Explorer and this module. In short, the use of a for/in loop with HTMLCollection objects returned from getElementsByTagName("a") has incorrect behavior if there are any named anchors in the page whose name attribute starts with a number (as is the case when section names start with a number). If this is the case, any attempt to use bracket syntax to select the node from the collection will interpret the first part of the name attribute as a number and fail if that numeric index does not exist.

One fix is to use a traditional for loop to fix this. The requested changes is to change the two instances of this code (lines 95 and 125):

for( var key in links )

To be this code:

for( var key = 0; key < links.length; key++ )

This will cause all browsers to use only numeric indexes that are in range and fix problems people are seeing in Internet Explorer. The problems with this script seem to be preventing all user JavaScript from loading on affected pages. Mike Dillon 15:49, 23 May 2007 (UTC)[reply]