Talk:Cartesian tree/GA1

GA Review

Article (edit | visual edit | history) · Article talk (edit | history) · Watch

Reviewer: Ganesha811 (talk · contribs) 17:27, 4 August 2023 (UTC)[reply]

Hi! I'll be reviewing this article, using the template below. Sorry for the long wait! If you have any questions, feel free to ask them here. —Ganesha811 (talk) 17:27, 4 August 2023 (UTC)[reply]

As this is a subject (actually, a whole field) I'm unfamiliar with, I'm diving into a little bit of research to make sure I can adequately assess comprehensiveness and detail. Hope to complete the review in the next few days. —Ganesha811 (talk) 16:49, 5 August 2023 (UTC)[reply]

Ok, no hurry. —David Eppstein (talk) 20:59, 5 August 2023 (UTC)[reply]

Rate	Attribute	Review Comment
1. Well-written:
	1a. the prose is clear, concise, and understandable to an appropriately broad audience; spelling and grammar are correct.	In general, some of the language is too technical and difficult for a novice reader to understand. I will make specific comments/suggestions on this as part of the prose review.
	1b. it complies with the Manual of Style guidelines for lead sections, layout, words to watch, fiction, and list incorporation.	Pass, no issues.
2. Verifiable with no original research:
	2a. it contains a list of all references (sources of information), presented in accordance with the layout style guideline.
	2b. reliable sources are cited inline. All content that could reasonably be challenged, except for plot summaries and that which summarizes cited content elsewhere in the article, must be cited no later than the end of the paragraph (or line if the content is not in prose).	All reliable academic sources, no issues here. Pass.
	2c. it contains no original research.
	2d. it contains no copyright violations or plagiarism.
3. Broad in its coverage:
	3a. it addresses the main aspects of the topic.	A sentence or two should be added to the lead, and a couple more to the body, on a very high-level, simple explanation of what a tree data structure is and how it works. This article is really only comprehensible now by going and reading a couple of other Wikipedia articles first, but it should be able to stand on its own.
	3b. it stays focused on the topic without going into unnecessary detail (see summary style).
	4. Neutral: it represents viewpoints fairly and without editorial bias, giving due weight to each.	No issues, pass.
	5. Stable: it does not change significantly from day to day because of an ongoing edit war or content dispute.	No issues. Pass.
6. Illustrated, if possible, by media such as images, video, or audio:
	6a. media are tagged with their copyright statuses, and valid non-free use rationales are provided for non-free content.	Pass, no issues, all are original works by nominator uploaded and released.
	6b. media are relevant to the topic, and have suitable captions.	Some tweaking possible to captions - will handle under prose review. Provisional pass.
	7. Overall assessment.

Re #3: I added some sentences to the start of the "Definitions" section providing glosses of the basic tree terminology used. It definitely does not belong in the lead. The phrasing of your comment "what a tree data structure is" already exhibits a misunderstanding: this is a mathematical structure, not a computer data structure. It can be represented by a data structure in a computer, and is used to define certain data structures, but it is not really a data structure on its own. Turning it into a data structure would require specifying additional information about how each node is represented in memory, what operations are to be performed on it and how, etc. —David Eppstein (talk) 06:14, 8 August 2023 (UTC)[reply]