Module talk:WikiProject banner/Archive 14

Archive 10

←

Archive 12

Archive 13

Archive 14

Archive 15

Archive 16

Discussion at Wikipedia talk:Content assessment § Proposal: Reclassification of Current & Future-Classes as time parameter

 You are invited to join the discussion at Wikipedia talk:Content assessment § Proposal: Reclassification of Current & Future-Classes as time parameter. There is a proposal to split "current" & "future" classes into a new parameter "time", in order to standardise article-rating across Wikipedia (per RfC), while also allowing simultaneous usage of quality criteria and time for interest projects. Thanks! —CX Zoom[he/him] ^{(let's talk • {C•X})} 07:28, 2 July 2023 (UTC)

Red links for inactive projects

See Talk:Hoekstra, the class List is red for Frisia because it does not have a category because its an inactive project. Christian75 (talk) 09:05, 29 June 2023 (UTC)

That's not even supposed to appear. Will check it out ... — Martin (MSGJ · talk) 09:12, 29 June 2023 (UTC)

I think such categories should be tracked and created. We did reach a consensus to retain inactive WikiProject banner, but not much work has been done yet on that front. —CX Zoom[he/him] ^{(let's talk • {C•X})} 09:21, 29 June 2023 (UTC)

I am trying to work out if this rating has just appeared with the module conversion, or whether it has been like that since 10 May? — Martin (MSGJ · talk) 09:23, 29 June 2023 (UTC)

Just to clarify that the template is working as expected. This was a compromise after the long discussion at Wikipedia:Village pump (miscellaneous)/Archive 73#Improper handling of assessment for inactive WikiProjects. If you don't like the red links, would you prefer this to be de-linked, or would you prefer the whole row is hidden in the banner? Personally I don't think there was consensus to recreate all those categories, but any WikiProject being "revived" can of course do so — Martin (MSGJ · talk) 13:35, 2 July 2023 (UTC)

Script errors

Template:WikiProject Portals seems to be generating script errors, e.g. on Wikipedia talk:Featured portal review but the errors are not visible on the page, they are just populating the category — Martin (MSGJ · talk) 09:13, 3 July 2023 (UTC)

Another thing, {{WikiProject Portals|historical=y}} doesn't populated the "historical" category, but {{WikiProject Portals}} does. —CX Zoom[he/him] ^{(let's talk • {C•X})} 09:29, 3 July 2023 (UTC)

Seems a bit of a mess. User:MJL has worked on this template in the past, maybe he/she can help? — Martin (MSGJ · talk) 09:49, 3 July 2023 (UTC)

It was an issue with note 4. Now fixed. -- WOSlinker (talk) 12:15, 3 July 2023 (UTC)

Thanks WOS! — Martin (MSGJ · talk) 13:34, 3 July 2023 (UTC)

@MSGJ: [Thank you for the ping] For the record, I use they/them pronouns rather than he/she.
Glad this got solved. While I did attempt to work on that template in the past, I self-reverted all my changes when I broke something. I probably wasn't going to be much of a help here. –MJL ‐Talk‐^☖ 17:12, 3 July 2023 (UTC)

minor comment on Module:WikiProject banner

Just a minor comment: the invocation of banner_rows:allDone() on line 614 is essentially a no-op, as the return value isn't being stored. isaacl (talk) 21:22, 4 July 2023 (UTC)

Understood. When I first coded this I assumed the done() were required in order to close the tags. Then I noticed that none of your examples on WT:LUA had them so guessed that tags were closed automagically. — Martin (MSGJ · talk) 21:26, 4 July 2023 (UTC)

Sure, if you had a mental model of an ongoing string of text being built up, I understand how you might think this. What happens though is that the function calls build a tree of objects representing the HTML. When tostring() is invoked on the banner variable, the tree is rendered into HTML, and thus as the tree is traversed, the corresponding start and end tags will be generated. isaacl (talk) 22:00, 4 July 2023 (UTC)