Talk:Binary search tree/GA3

GA Review

Article (edit | visual edit | history) · Article talk (edit | history) · Watch

Reviewer: Mhawk10 (talk · contribs) 05:16, 14 May 2022 (UTC)

Hello! I'll take a look at this article and give feedback over the next couple of days. — Ⓜ️hawk10 (talk) 05:16, 14 May 2022 (UTC)

@Mhawk10: Thanks for taking this one. If there are any copy edits, improvements or changes you want to be made, please let me know. I'll make the revisions ASAP. --WikiLinuz {talk} 🍁 12:44, 14 May 2022 (UTC)

@WikiLinuz: I've placed the article on-hold, per below. I'm still working through and spot-checking refs, though there are going to need to be some improvements made if this is going to become a GA. — Ⓜ️hawk10 (talk) 18:30, 16 May 2022 (UTC)

Rate	Attribute	Review Comment
1. Well-written:
	1a. the prose is clear, concise, and understandable to an appropriately broad audience; spelling and grammar are correct.
	1b. it complies with the Manual of Style guidelines for lead sections, layout, words to watch, fiction, and list incorporation.	There are issues with compliance with MOS:LEAD. The lead does not include any materials from the "Examples of Applications", "Types", and "History" sections, while it probably should. The length of the lead was something that was noted in Talk:Binary search tree/GA1 but has not been fixed. This technically would be enough for a quick fail, though it's often best to re-write the lead after all of the other fixes are made so I think it's best to WP:IAR and put this on hold rather than give a quick fail. — Ⓜ️hawk10 (talk) 02:53, 16 May 2022 (UTC)
2. Verifiable with no original research:
	2a. it contains a list of all references (sources of information), presented in accordance with the layout style guideline.
	2b. reliable sources are cited inline. All content that could reasonably be challenged, except for plot summaries and that which summarizes cited content elsewhere in the article, must be cited no later than the end of the paragraph (or line if the content is not in prose).
	2c. it contains no original research.	The second edition of the MIT textbook that is cited for the Tree-Predecessor pseudocode is left as an exercise to the reader (Exercise 12.2-3) in the cited textbook. While the text notes that "The procedure TREE-PREDECESSOR, which is symmetric to TREE-SUCCESSOR", the citation is a bit weak to support the specific pseudocode in the article. — Ⓜ️hawk10 (talk) 01:51, 16 May 2022 (UTC) Also, can you show that the "tree-deletion" pseudocode operates the same as the "TREE-DELETE" pseudocode in the cited source? If so, it's fine as a routine calculation, but this is something that you are going to need to demonstrate here. — Ⓜ️hawk10 (talk) 01:51, 16 May 2022 (UTC)
	2d. it contains no copyright violations or plagiarism.	I've acquired a copy of Introduction to Algorithms, Second Edition. The cited pages of the book appear to give pseudocode that contains the same function names as are in the book, though the pseudocode itself is transformed so as to not be a verbatim copy of what's in the book. The book was published in the United States, so the copyrights are exclusively governed by U.S. law. Copyrights in the United States are not valid when there are a very limited set of ways in which an idea can be expressed, so the pseudocode for those algorithms per se is not eligible under copyright protection. However, the choice to use "Tree-Search" for the name of the recursive search function and "Iterative-Tree-Search" for the iterative search function alongside the use of "Tree-Successor", "Tree-Maximum", "Tree-Minimum", "Tree-Insert", "Tree-Delete", and " probably extends beyond this limited exception to copyright—it's certainly possible to give the functions different names than are given in the MIT textbook. — Ⓜ️hawk10 (talk) 01:51, 16 May 2022 (UTC) If you'd like to take action against a source that copied Wikipedia without atribution, this medium post showed 67% similarity to this article on WP:EARWIG. This is a case of a publication copying Wikipedia, so it does not pose an issue for the article's promotion to GA. — Ⓜ️hawk10 (talk) 02:05, 16 May 2022 (UTC)
3. Broad in its coverage:
	3a. it addresses the main aspects of the topic.	There is a lot written about self-balancing binary search trees in the academic literature, which appears to be a child topic of this article. The current article addresses this topic within the "types" section, but it doesn't really go in-depth into it. It also isn't quite structured like the typical parent-child article relation (for example, with the {{main article}} template as a header of a section or sub-section). — Ⓜ️hawk10 (talk) 02:14, 16 May 2022 (UTC) Similarly, the history section is really short. It might be worthwhile to briefly describe the history of the major</> variants of the binary search tree as well; Red-Black Trees, AVL Trees, etc. are worth prominently mentioning in this article and might be helpful in expanding the history section beyond a sentence. — Ⓜ️hawk10 (talk) 02:44, 16 May 2022 (UTC)
	3b. it stays focused on the topic without going into unnecessary detail (see summary style).
	4. Neutral: it represents viewpoints fairly and without editorial bias, giving due weight to each.	Looks fine as of now. — Ⓜ️hawk10 (talk) 02:34, 16 May 2022 (UTC)
	5. Stable: it does not change significantly from day to day because of an ongoing edit war or content dispute.	I don't see any edit warring recently. — Ⓜ️hawk10 (talk) 02:35, 16 May 2022 (UTC)
6. Illustrated, if possible, by media such as images, video, or audio:
	6a. media are tagged with their copyright statuses, and valid non-free use rationales are provided for non-free content.	The images used in the article are tagged with their copyright status. — Ⓜ️hawk10 (talk) 18:30, 16 May 2022 (UTC)
	6b. media are relevant to the topic, and have suitable captions.	Images pertain to the material and have policy-compliant captions. — Ⓜ️hawk10 (talk) 18:30, 16 May 2022 (UTC)
	7. Overall assessment.	On hold for now. — Ⓜ️hawk10 (talk) 18:30, 16 May 2022 (UTC)