Jump to content

Talk:Android Debug Bridge/GA1

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia
< Talk:Android Debug Bridge
This is an old revision of this page, as edited by Rusalkii (talk | contribs) at 20:43, 30 November 2021. The present address (URL) is a permanent link to this revision, which may differ significantly from the current revision.

GA Review

GA toolbox
Reviewing

Article (edit | visual edit | history) · Article talk (edit | history) · Watch

Reviewer: Rusalkii (talk · contribs) 18:24, 30 November 2021 (UTC)[reply]


I'm a first time reviewer, so I intend to ask for a second opinion once the review is complete.

Initial thoughts: the article seems sparse for a GA. No illustrations but the one in the infobox, at this size I would want one or two more; perhaps an image of ADB in use? Architecture section is two sentences and should be significantly expanded or merged elsewhere, preferably expanded. Rusalkii (talk) 18:24, 30 November 2021 (UTC)[reply]

GA review (see here for what the criteria are, and here for what they are not)
  1. It is reasonably well written.
    a (prose, spelling, and grammar): b (MoS for lead, layout, word choice, fiction, and lists):
  2. It is factually accurate and verifiable.
    a (reference section): b (citations to reliable sources): c (OR): d (copyvio and plagiarism):
Copyvio: Earwig gives 6.5% similarity, with a couple sentences in the security section resembling this source. Could be rewritten but seems okay. Rusalkii (talk) 20:43, 30 November 2021 (UTC)[reply]
  1. It is broad in its coverage.
    a (major aspects): b (focused):
  2. It follows the neutral point of view policy.
    Fair representation without bias:
    No bias or promotional tone. Security issues given reasonable weight.
  3. It is stable.
    No edit wars, etc.:
    Recent history since August split from Android software development#Android Debug Bridge (ADB) has been almost entirely steady improvements by nominator PhotographyEdits, with a single incident of minor vandalism. Rusalkii (talk) 18:41, 30 November 2021 (UTC)[reply]
  4. It is illustrated by images and other media, where possible and appropriate.
    a (images are tagged and non-free content have fair use rationales): b (appropriate use with suitable captions):
    Own work screenshot and public domain logo. Could do with more images, but I couldn't find any in commons or appropriately licences after a quick search. Rusalkii (talk) 20:43, 30 November 2021 (UTC)[reply]
  5. Overall:
    Pass/Fail:


Comments

Lead

  • I made a couple minor changes to the prose and formatting. Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • I'm seeing both adb and ADB in sources, but article should not use both in prose. Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • It consists of a client and server on the host PC, where the server connects to the daemon on the Android device. "It consists of" is awkward and "where the server..." is confusing. This sentence feels like it wants to be several sentences explaining how ADB works in slightly more depth. Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • available since 2007 available where? to whom? was it created before then? Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • No mention other than infobox and the implication in Google made it possible of who created ADB. Given what I know about Android I assume Google, but this should be specified, ideally both in the lead and the history section. Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • Why are the shell and backups the features mentioned in the lead? Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • It has seen different security attacks and improvements to mitigate these This reads very vaguely. Why are these prominent enough for the lead? Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]
  • Images in infobox: is there an ADB specific logo that could be added? OK if not. Rusalkii (talk) 20:43, 30 November 2021 (UTC)[reply]
  • Overall impression of lead: vague. There's still plenty of space before the lead gets too long, it would be good to see some more concrete descriptions of what it is, where it came from, and how it is used. Rusalkii (talk) 19:24, 30 November 2021 (UTC)[reply]

Features

History

  • I would rename this section Development. Rusalkii (talk) 20:43, 30 November 2021 (UTC)[reply]
  • Reads like a list. There's some attempt at going chronologically, but 2015 follows 2017 and version numbers are interlaced with years seemingly interchangeably. If practical, I would divide this section into major releases, describe new features of each, and
Retrieved from "https://en.wikipedia.org/w/index.php?title=Talk:Android_Debug_Bridge/GA1&oldid=1057990365"