View source for User talk:Evad37/Script modules

{{talkheader}}

== Possible extension: Version control ==

Script module importation could be extended to include version control. This would necessitate each script module having an associated json page mapping version numbers to old revision ids. The {{tt|importScriptModule}} function, if given a version number as a second parameter, could first import the script module's json page, and add the {{tt|1=oldid=}} parameter with the appropriate value to the url for loading the script. There should be a way of specifying partial version numbers, and/or greater-than/less-than a version number, similar to [https://docs.npmjs.com/misc/semver how npm does it]. The {{tt|exportScriptModule}} function would also need to know the version number, and store the exported function/object at {{tt|Window.exportScriptModule[name][version]}}. Perhaps the json pages could be maintained by bot. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 03:02, 26 January 2019 (UTC)

== Start collecting ==

Regardless of if this is implemented or not, it would be useful to have a collection of such "script modules" (if implemented, they form the basis of the "namespace," and if not, they could still serve its purpose). Accordingly, if anyone has a script that they want to add, please post it [[User talk:DannyS712|here]] (I'll think of a better system soon) so that we can keep track of them. Thanks, --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 04:44, 26 January 2019 (UTC)
:I've got a bunch of helper functions in XFDcloser and my other scripts that are general enough to be reused (some of them I've straight copy/pasted between my scripts). Very simple functions are probably better off in libraries like [[User:Evad37/Module/extra.js]], while bigger/more-complicated ones I would make into their own module, e.g. [[User:Evad37/Module/multiButtonConfirm.js]] - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 00:29, 28 January 2019 (UTC)

== Comments ==

I think this is a good idea,  but have a couple of points: 
*With the existing syntax, I make out that not just functions, even ''classes'' can be exported? If so, that's awesome.
*Perhaps you could extend the syntax to match that of <code>mw.loader.using</code>, allowing multiple imports to be declared in an array, so that <code>$.when</code> need not be used?
*Is it necessary to restrict the import of scripts to the ones stored in the mediawiki namespace? While it does improve security, I don't that's a very big consideration since till now there hasn't been a single attack that vandalised the mediawiki space (right?). Most people are not interface admins. It would help people to maintain their script-modules if they aren't stored in mediawiki space. 
[[User:SD0001|SD0001]] ([[User talk:SD0001|talk]]) 05:41, 26 January 2019 (UTC)
:*Yes, anything that javascript can {{tt|return}} can be exported (except {{tt|undefined}}, but there wouldn't be much point in exporting that)
:*Yeah, that should be easy enough to do. Will take a look at coding it tomorrow.
:*I think there have been cases of malicious code being inserted into the sitewide common.js on other wikis by comprised admin accounts, which is part of the reason interface admins were introduced. Requiring an edit request and a quick check by an int-admin doesn't seem too much of a burdern, especially since this check is explicitly ''not'' a full code review. I expect most proposed edits will probably just be rubber-stamped, hence the comment about them not being much better than the average userscript. The other advantage of requiring int-admins to make the edits is that the syntax (single call to Window.exportScriptModule, all module code within the IIFE) is more likely to be enforced / less likely to be inadvertently broken.
:- <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 06:36, 26 January 2019 (UTC)
:{{tq|[allow] multiple imports to be declared in an array}} – {{Done}} - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 07:53, 27 January 2019 (UTC)

== Pseudo-namespace ==

I find it interesting that you want to create a pseudo-namespace for these script modules, when the review process for them are the same as other global scripts in technical terms. It seems that the purpose here is to prevent users from loading the rest of the MediaWiki namespace into their user scripts. What use cases are you expecting where we want to block a normal user from loading a sitewide script into their own user script? [[User:Deryck Chan|Deryck]][[User talk:Deryck Chan| C.]] 19:56, 26 January 2019 (UTC)
:{{ping|Deryck Chan}} fyi blocked users can't edit their own common.js, etc --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 20:19, 26 January 2019 (UTC)
::...therefore the issue of blocked users is irrelevant to my question about whether a pseudo-namespace is necessary. [[User:Deryck Chan|Deryck]][[User talk:Deryck Chan| C.]] 20:22, 26 January 2019 (UTC)
:::{{ping|Deryck Chan}} Sorry, I misunderstood your question. I read {{tq|expecting where we want to block a normal user from}} as "expecting where blocked users would be..." or something like that. But, what do you mean by {{tq|prevent users from loading the rest of the MediaWiki namespace into their user scripts}}? I'm confused by what you are referring to... --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 20:29, 26 January 2019 (UTC)
::::{{ping|DannyS712}} In Evad37's description, the reason for having a pseudo-namespace is so that interface admins can constrain what scripts can be loaded into user scripts and what scripts can't. Why do we want to stop users from loading MediaWiki namespace scripts in general, given that all of them have been reviewed by IAdmins? [[User:Deryck Chan|Deryck]][[User talk:Deryck Chan| C.]] 20:32, 26 January 2019 (UTC)
:::::{{ping|Deryck Chan}} I didn't know that we stop that... maybe because the MW namespace in general is for fully fledged scripts/gadgets/skins, etc, while this would be for reusable components? --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 20:39, 26 January 2019 (UTC)
:{{ping|Deryck Chan}} {{tq|the review process for them are the same as other global scripts in technical terms}} – the review process is meant to be a very low bar to cross, basically just "not evil", as opposed to gadgets which have [[WP:Gadget#General criteria for gadgets|more criteria]] and require a proposal to gather consensus.<br/>{{tq|It seems that the purpose here is to prevent users from loading the rest of the MediaWiki namespace into their user scripts}} – The purpose is to only allow ''script modules'' to be loaded using {{tt|Window.importScriptModule}}. Other types of MediaWiki scripts can be loaded using conventional means, such as how [[WP:XFDC|XFDcloser]] has a <code>importScript('MediaWiki:Gadget-morebits.js');</code> line, and later on uses <code>new Morebits.simpleWindow(</code>...etc... .<br/>{{tq|What use cases are you expecting where we want to block a normal user from loading a sitewide script into their own user script?}} – When using {{tt|Window.importScriptModule}} is going to return a rejected promise, because you tried to load a random script that doesn't use the <code>Window.exportScriptModule('{{gi|name}}', {{gi|IIFE}});</code> syntax<br/>{{tq|Why do we want to stop users from loading MediaWiki namespace scripts in general, given that all of them have been reviewed by IAdmins?}} – We don't, but only the special script modules using the correct syntax can be imported using {{tt|Window.importScriptModule}}. Other scripts have to be imported by other means.<br/>One other benefit of using a pseudo-namespace is making them easy to find using [[Special:PrefixIndex]]. And it is similar to gadgets being prefixed by "Gadget-". Plus like Danny just said, this is just for components to be used within other scripts. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 23:15, 26 January 2019 (UTC)
::{{ping|Evad37|Deryck Chan}} to get a better idea of what this would include, I suggest we combine some examples of snippets that we already reuse individually. See my post above. --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 23:38, 26 January 2019 (UTC)
:::Agree. Better to make a copy of [[User:Evad37/extra.js]] (or to go one step further, [[MediaWiki:Gadget-morebits.js]]) that uses the exprtScriptModule syntax, for the sake of demonstration. [[User:SD0001|SD0001]] ([[User talk:SD0001|talk]]) 04:39, 27 January 2019 (UTC)
::::{{ping|SD0001}} Yeah, but I don't know how to convert it... --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 05:02, 27 January 2019 (UTC)
{{od}}
Here are some sample script modules:
*[[User:Evad37/Module/parseAllTemplates.js]]
*[[User:Evad37/Module/extra.js]]
*[[User:Evad37/Module/multiButtonConfirm.js]]
Converting a regular user script to a script module isn't too hard:
# Add the line <code>Window.exportScriptModule('{{gi|moduleName}}', (function() {</code> to the top
# Remove any additions to the {{tt|Window}} object, and add a {{tt|return}} statement at the bottom with whatever should be exported
# Add the line <code>})());</code> to the bottom
# Clean up comments/documentation
- <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 00:22, 28 January 2019 (UTC)

== Problem being solved? ==

What's the problem being solved here? It seems to add a decent amount of complexity...for what gain exactly?

Creating a shared library seems like a decent idea, but I don't see much advantage to creating small individual modules compared to a single grabbag of stuff. I would also suggest looking at what Commons has (see [[c:Special:Gadgets]], the lib* ones), and whether we can leverage that. 

HTH, [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 01:06, 28 January 2019 (UTC)
:{{ping|Legoktm}} The idea came out of a discussion on my talk page [[User_talk:Evad37#Template_parser_script]]. One of the main things, really, is an easy way to use other people's code in a user script, with a promise to ensure it is loaded before it is used, and without reloading something that another script has already loaded. Currently this requires code like
:<syntaxhighlight lang="js">
var fooIsLoaded = Window.foo !== undefined;
$.when(
    fooIsLoaded ||
    $.getScript('https://en.wikipedia.org/w/index.php?title=User:Example/foo.js&action=raw&ctype=text/javascript')
).then(function() {
    // code that uses Window.foo
})
</syntaxhighlight> whereas I would like to simply write <syntaxhighlight lang="js">importScriptModule('foo').then(//... foo is ready to be used, and was not reloaded if already loaded</syntaxhighlight>
:The second thing would be to have a bit of an increase in security, by storing reusable code in MediaWiki: namespace – but with a lightweight ("not evil") approval process, so its still relatively easy for users to publish and update such code.
:The advantage of individual modules would be you only load what you need, e.g. not every script needs to parse wikitext. Having modules act as libraries for particular tasks or otherwise-related bits of code would make sense, rather than lots of small modules needing lots of network requests to load. (The demo modules are intentionally tiny as they are for proof-of-concept, rather than representing the size of a real module). - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 02:56, 28 January 2019 (UTC)
:{{re|Legoktm}} The proposal is basically to create an equivalent of <code>mw.loader.using</code> for stuff other than ResourceLoader modules. I wonder why <code>mw.loader.using</code> doesn't work for external scripts, while <code>mw.loader.load</code> does? That aside, the Commons libraries seem to be great, especially [[c:MediaWiki:Gadget-libWikiDOM.js]]. Since they are gadgets, do they get loaded on all pages? Otherwise, looking at [https://commons.wikimedia.org/w/index.php?search=%2FMediaWiki%3AGadget%5C-libWikiDOM%5C.js%2F&title=Special:Search&profile=advanced&fulltext=1&advancedSearch-current=%7B%22namespaces%22%3A%5B0%2C1%2C2%2C3%2C4%2C5%2C6%2C7%2C8%2C9%2C10%2C11%2C12%2C13%2C14%2C15%2C100%2C101%2C102%2C103%2C104%2C105%2C106%2C107%2C146%2C147%2C460%2C461%2C486%2C487%2C490%2C491%2C828%2C829%2C1198%2C1199%2C2300%2C2301%2C2302%2C2303%5D%7D&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns102=1&ns103=1&ns104=1&ns105=1&ns106=1&ns107=1&ns146=1&ns147=1&ns460=1&ns461=1&ns486=1&ns487=1&ns490=1&ns491=1&ns828=1&ns829=1&ns1198=1&ns1199=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1 a search result], they seem to be unused. [[User:SD0001|SD0001]] ([[User talk:SD0001|talk]]) 09:10, 28 January 2019 (UTC)
::No, those gadgets are not enabled by default, and due to a permissions trick, won't show up in Special:Preferences for users to enable. But they are normal ResourceLoader modules, so any gadget or user script can depend upon them with <code>mw.loader.using</code>. That's what I'd recommend doing instead of inventing a parallel system, especially since it's already planned to use the MediaWiki namespace. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 08:12, 29 January 2019 (UTC)
:::{{ping|Legoktm}} How can a "user script ... depend upon them with <code>mw.loader.using</code>"? It seems to always return a rejected promise with an {{samp|Unknown dependency}} error (when used with anything other than the modules listed at [[mw:RL/CM]]). - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 09:00, 29 January 2019 (UTC)
::::What module did you try to load? For example, if I wanted to ensure navpopups was loaded, I can do: <code>mw.loader.using('ext.gadget.Navigation_popups').done(() => console.log('success!'));</code>, and see "success!" printed. You can use <code>mw.loader.getState()</code> to see what the current state is, 'ready' for loaded, 'registered' for not loaded, and null if the module doesn't exist. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 17:03, 29 January 2019 (UTC)
:::::Well, I didn't realise that a {{code|ext.gadget.}} prefix was needed – that should really be documented on [[mw:RL/CM]], and possibly elsewhere. But in any case, I was trying to load [[MediaWiki:Gadget-morebits.js]] – still doesn't work, probably because it doesn't have it's own line on [[MediaWiki:Gadgets-definition]] (loading twinkle using {{code|mw.loader.using('ext.gadget.Twinkle')}} works as expected).
:::::Assuming int-admins are willing to add script modules/libraries as off-by-default, hidden gadgets without too much fuss, then that will take care of the bulk of this proposal. Something like {{code|mw.loader.using}} but for any userscript could still be useful – basically a wrapper for {{code|$.getScript}}, but taking a wiki page name like ({{code|importScript}}), or an array of page names (like {{code|mw.loader.using}}), and keeping track of what's already been loaded (by other scripts) to prevent unnecessary requests being sent. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 00:55, 1 February 2019 (UTC)
::::::Yep, morebits would need its own gadgets-definition line. What you're asking for is [[phab:T27962]], which is waiting for someone to work on it. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 18:04, 1 February 2019 (UTC)
:::::::That bug doesn't look too hard, I'll have a go at making a patch. - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 00:58, 2 February 2019 (UTC)
:::::::https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/487566/ - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 06:13, 2 February 2019 (UTC)
::::::::You're awesome. [[User:Legoktm|Legoktm]] ([[User talk:Legoktm|talk]]) 05:38, 6 February 2019 (UTC)

== Example modules ==

These aren't in the right format, but some scripts of mine that would be useful as "script modules" IMO:
* [[User:DannyS712 test/page.js]] get and set the contents of a wikitext page (interact with it as a string)
* [[User:DannyS712 test/JSON.js]] get and set the contents of a JSON page (interact with it as a JSON object)
--[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 07:17, 23 February 2019 (UTC)
:Not sure if you know this, but there is an existing [https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api mw.Api] ResourceLoader module, which also makes editing easy with its postWithToken method, and to set the [[mw:API:Client_code#Set_a_User-Agent_header|User-Agent header]] once (when creating an mw.Api object), rather than for each request. What I've started doing in XFDcloser is making some helper functions to make it easy to extract the wanted data from the returned JSON:<syntaxhighlight lang="js">
var arrayFromResponsePages = function(response) {
	return $.map(response.query.pages, function(page) { return page; });
};

var pageFromResponse = function(response) {
	return arrayFromResponsePages(response)[0];
};

var makeErrorMsg = function(code, jqxhr) {
	var details = '';
	if ( code === 'http' && jqxhr.textStatus === 'error' ) {
		details = 'HTTP error ' + jqxhr.xhr.status;
	} else if ( code === 'http' ) {
		details = 'HTTP error: ' + jqxhr.textStatus;
	} else if ( code === 'ok-but-empty' ) {
		details = 'Error: Got an empty response from the server';
	} else {
		details = 'API error: ' + code;
	}
	return details;
};
</syntaxhighlight>
:I think a module/library of function like this, perhaps with some that make the appropriate input object from just the page name, would be a good idea. That would simplify code to something like:<syntaxhighlight lang="js">
// import `apiLib` from script module/library
var api = new mw.Api( { ajax: { headers: { 'Api-User-Agent': /* your info here */ }	} } );
// ...
api.get( apiLib.query("Page title") )
.then(apiLib.pageWikitextFromResponse)
.then(function(pageWikitext) { /* ... do stuff ... */ });
</syntaxhighlight>
:As for the script module formatting, rather than re-invent the wheel it's probably better to just use the exisitng method of attaching stuff to the window object. Plus loading scripts with a callback (promise) is about to get much easier, once the patch I made for [[phab:T27962]] gets deployed (likely next week). - <u>'''[[User:Evad37|Evad]]''37'''''</u>&nbsp;<span style="font-size:95%;">&#91;[[d:w:User talk:Evad37|talk]]]</span> 00:33, 1 March 2019 (UTC)