View source for User talk:Danski454/unwatch.js

==AJAX?==
{{ping|Danski454}} Would it be possible to click to unwatch without leaving the current page? Perhaps with an AJAX method? ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 10:54, 6 May 2019 (UTC)
:{{ping|NMaia}} {{done}}: just add <code>var unwatchAJAX = true;</code> to your common.js (I left the old code in for those who still want it). --[[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 12:16, 6 May 2019 (UTC)
::Awesome, thanks! :) ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 12:21, 6 May 2019 (UTC)
:::{{ping|Danski454}} Did I... [https://meta.wikimedia.org/w/index.php?title=User%3ANMaia%2Fglobal.js&type=revision&diff=19079251&oldid=19079079 do this] right? It didn't work for me. ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 12:25, 6 May 2019 (UTC)
::::{{ping|NMaia}} That should work, what is happening instead? [[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 12:31, 6 May 2019 (UTC)
:::::{{ping|Danski454}} I'm still being directed to another page when I click [unwatch], same as before your modifications. No errors on my browser (Firefox) console. ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 12:35, 6 May 2019 (UTC)
::::::{{ping|NMaia}} That should not happen, have you tried [[WP:BYC|clearing your cache]]? --[[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 12:40, 6 May 2019 (UTC)
:::::::you should actually clear it. [[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 12:41, 6 May 2019 (UTC)
::::::::{{ping|Danski454}} I tried Ctrl+F5, to no avail, and then cleared cache and cookies from en.wikipedia.org, also to no avail. ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 12:44, 6 May 2019 (UTC)
:::::::::{{ping|NMaia}} this probably won't work, but try moving the <code>var unwatchAJAX = true;</code> before the mw.loader.load statement. [[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 12:49, 6 May 2019 (UTC)
::::::::::{{ping|Danski454}} Still didn't work. I tried using Ctrl+F5 and all. ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 13:28, 6 May 2019 (UTC)
{{Od|::::::::::}}
{{ping|NMaia}} what happens if you run the code <code>typeof unwatchAJAX !== "undefined" && unwatchAJAX</code> in the console? I'll probably need to ask [[WP:VPT]] anyway. [[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 13:37, 6 May 2019 (UTC)
:{{ping|Danski454}} Running that returns <code>false</code>. FWIW, on meta I get the same issue. ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 14:14, 6 May 2019 (UTC)
::{{ping|NMaia}} I think I've found it. Replace <code>var unwatchAJAX = true;</code> with <code>window.unwatchAJAX = true;</code>. It seems that code in global.js is run in a different scope. [[User:Danski454|Danski454]] ([[User talk:Danski454|talk]]) 14:21, 6 May 2019 (UTC)
:::{{ping|Danski454}} It works! You rock! Thank you. You might want to document these two variables as a comment on the code for future users :) ~<span style='color: green'><span title="Lernu Esperanton!">★ '''[[User:NMaia|nmaia]]''' <sup>[[User talk:NMaia|d]]</sup></span></span> 14:25, 6 May 2019 (UTC)