View source for Module talk:WikiProject banner

{{notice|If you wish to discuss the behaviour of the project banner inside the banner shell, then you may wish to post at [[Template talk:WikiProject banner shell]] instead.}}
{{WikiProject banner shell|
{{WikiProject Council}}
}}
{{to do|collapsed=yes}}
{{/happysad}}
{{User:MiszaBot/config
| algo = old(60d)
| archive = Module talk:WikiProject banner/Archive %(counter)d
| counter = 16
| maxarchivesize = 150K
| archiveheader = {{Aan}}
| minthreadstoarchive = 1
| minthreadsleft = 4
}}
{{archives|index=/Archive index|bot=lowercase sigmabot III|age=28|auto=short}}

== To do adjustments ==

I have [https://en.wikipedia.org/w/index.php?title=Module%3AWikiProject_banner%2Fauxiliary%2Fsandbox&diff=1274014600&oldid=1268570995 made a few adjustments] to the to do related code in /auxiliary/sandbox.
# Converted the presentational table to a more appropriate div.
# Use a dark mode token for the background.
# Removed support for setting custom styles. [[Template:WikiProject Freemasonry]] is the only project which uses them ([https://en.wikipedia.org/w/index.php?search=insource:/TODO_STYLE/%20-intitle:/(\/sandbox|\/doc)/&title=Special:Search&profile=advanced&fulltext=1&ns10=1&ns828=1 TODO_STYLE] [https://en.wikipedia.org/w/index.php?search=insource:/TODO_TITLE_STYLE/%20-intitle:/(\/sandbox|\/doc)/&title=Special:Search&profile=advanced&fulltext=1&ns10=1&ns828=1 TODO_TITLE_STYLE]), and the way in which they are used is not friendly for dark mode, though the particular color flavor happens to be readable. [https://en.wikipedia.org/w/index.php?title=Template%3AWikiProject_NASCAR&diff=1274014111&oldid=1175978317 I removed another] which was using the default in light mode.

It looks like [[Module:WikiProject banner/templatepage]] needs removal of the parameters of interest. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 02:10, 5 February 2025 (UTC)

:Great, thanks for the info. I can deal with /templatepage &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:15, 5 February 2025 (UTC)
:@[[User:Izno|Izno]] there is a slight spacing inconsistency with the new divs, which you can observe on [[Template:WikiProject Japan/sandbox]]. Are you able to line up the text on the left and the [show] links on the right? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 16:43, 22 March 2025 (UTC)
::Playing around with the left/right padding on the container seems to do it. Adding 2px on the left and another 2px on the right I think got it. Basically what's happening is that tables have a natural border-spacing (not coincidentally it's 2px) which is padding like but applied slightly differently. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:53, 22 March 2025 (UTC)
:::Padding is always inside the border. The spacing outside the border is the margin. See [https://www.w3.org/TR/css-box-3/#box-model The CSS Box Model]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 23:27, 22 March 2025 (UTC)
::::Tables are special in that they have the border-spacing property. The point I was making is that in fact there is more to the box model than just padding and margin. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 00:58, 23 March 2025 (UTC)
:::::I don't see any changes to the sandbox and the example is still looking the same? If you can fix the spacing in the sandbox, I suggest we change all of the collapsible boxes in the module to use div boxes, to keep things consistent &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 08:46, 24 March 2025 (UTC)
:::::@[[User:Izno|Izno]] are you still interested in this? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 20:48, 28 March 2025 (UTC)
::::::I didn't make any adjustments, which is why you do not see any changes.
::::::I didn't change the other collapsible boxes because they're more or less fairly marked up as tables, from memory (and memory may be wrong of course). [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 21:30, 28 March 2025 (UTC)
:::::::In that case I can't really see a benefit to converting the table to a div, as it will introduce an inconsistency. I have removed the style parameters from /templatepage, so these will now be treated as unknown parameters &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:53, 30 March 2025 (UTC)

== Pre-load templates ==

We are still using the following templates:
* [[Template:WPBannerMeta/templatepage/preloadqual]]
* [[Template:WPBannerMeta/templatepage/preloadimp]]
* [[Template:WPBannerMeta/templatepage/preloadmeta]]
* [[Template:WPBannerMeta/templatepage/editintro]]
and these are also using:
* [[Template:WPBannerMeta/templatepage/deduceclass]]
* [[Template:WPBannerMeta/templatepage/deduceimportance]]
* [[Template:WPBannerMeta/templatepage/impheader]]
* [[Template:WPBannerMeta/templatepage/qualheader]]
I would firstly like to move these to a more suitable location (as [[Template:WPBannerMeta]] is no longer in use) and also to update and simplify this whole family of templates, because things can be done a lot more easily these days &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 16:16, 22 March 2025 (UTC)

:{{done}}. I have moved the three preload templates to [[Template:WikiProject banner preload template]] and deleted all the rest which are no longer needed &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 18:14, 26 March 2025 (UTC)

== Tidy up intersecting categories ==

I am looking at tidying up the intersecting quality/importance categories and there seem to be 3 types:
* [[:Category:Draft-Class Ireland articles of Low-importance]] - this is a valid category but should be renamed to [[:Category:Draft-Class Ireland pages of Low-importance]] in line with the move of [[:Category:Draft-Class pages]]. This is under discussion [[Wikipedia:Categories for discussion/Log/2025 March 28#Category:Redirect-Class 20th Century Studios articles of Low-importance|here]] - please comment if you can.
* [[:Category:FM-Class Palaeontology articles of NA-importance]] seems entirely redundant because all FM-class pages are rated as NA-class, so it will be an exact copy of [[:Category:FM-Class Palaeontology pages]]. I have nominated for deletion [[Wikipedia:Categories for discussion/Log/2025 March 28#Category:Category-Class 20th Century Studios articles of NA-importance|here]] - please comment if you can.
* [[:Category:NA-Class glass articles of Unknown-importance]] is invalid because it will never be used (NA-class will always default to NA-importance not Unknown-importance), so I will tag it for speedy deletion under {{tl|db-c1}}.
&mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 07:52, 2 April 2025 (UTC)

== Misplaced banners by bot ==

In January 2024 there was an error in the bot's code which resulted in edits like [https://en.wikipedia.org/w/index.php?title=Talk:Warm-blooded&diff=prev&oldid=1194491681 this]. I suspect that most of these have now been fixed but I am still finding the occasional example. So I was wondering if there is a way we could track these. I think that every banner should be above the first h2 heading, so perhaps some pattern that checks whether the banner code is before the first instance of 2 equals signs (==) &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 08:01, 2 April 2025 (UTC)

:Maybe similar code to [[Module:Is infobox in lead]]? [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 08:45, 2 April 2025 (UTC)
::Looks promising &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 09:37, 2 April 2025 (UTC)

== Different shades of green ==
{{resolved}}
{{WPAVIATION|class=b|category=no}}
I am seeing two different shades of green when the B-checklist is used. I don't understand why because they are both using css class <code>assess-b</code> which is defined in [[Module:WikiProject banner/styles.css]] as DFFFBF. I believe this is the paler colour, so I'm not sure where the other green is being defined. &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 10:20, 1 May 2025 (UTC)
:I see only one box with a green background above. Please link to an example page where this issue can be observed. My color picker tool is showing the one above as {{Background color|#DFFFBF|#DFFFBF}}. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:14, 1 May 2025 (UTC)
::I see two. The one preceding "This article has been rated as B-class on Wikipedia's content assessment scale." is of colour {{colorbox|#dfffbf}} (<code>#dfffbf</code>); the one preceding "This article has not yet been checked against the criteria for B-class status:" is of colour {{colorbox|#b2ff66}} (<code>#b2ff66</code>). They are distinctly different. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 20:57, 1 May 2025 (UTC)
:::That is weird because on my devices (and presumably Jonesey95's too) there is no background color for the "B" preceding "This article has not yet been checked against the criteria for B-class status:". To me it is {{legend inline|#f8eaba|#f8eaba}}, the color of the rest of the banner. This is the case even with {{code|?safemode{{=}}yes}}. I checked on Edge and Chrome on Windows, and Chrome on Android btw. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 21:12, 1 May 2025 (UTC)
::::Well, that's what I get ''initially'', using Firefox, but the green comes in after a fraction of a second. This is clearly a case of [[FOUC]]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 22:04, 1 May 2025 (UTC)
:::::Is it different when you are logged out? I do not get a background color behind the second B (with the magnifying glass). I checked in Firefox for Mac (logged in), Chrome for Mac (logged out, regular and dark mode), and Safari for Mac (logged out). I also do not see any evidence of a background color when I use Inspect elements in my browser tools. Is it possible that some of you have .css customizations applying this color? Or maybe a different skin? I am using the Vector 2022 skin. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 23:09, 1 May 2025 (UTC)
::::::Yes, it's different when logged out - both greens are shown at page load, there isn't even a flash of brown. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 16:29, 2 May 2025 (UTC)
::::All very strange. The magnifying glass background has always been green for me, on multiple browsers. But when I log out the background disappears. I do not see anything obvious in my personal CSS which could be causing this however. &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 10:08, 2 May 2025 (UTC)
:::::Even stranger: I am seeing the second green background behind the magnifying glass today. I haven't restarted my computer or even my browser. What a strange situation. Anyway, if we changed that green to dfffbf, would that satisfy those of us who can see the two colors? – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:29, 2 May 2025 (UTC)
::::::I think I figured out what may be happening. {{U|WOSlinker}} transcluded <syntaxhighlight inline lang=wikitext><templatestyles src="Module:Class/styles.css"/></syntaxhighlight> in a comment below, so when the module asks for the <code><b class="assess-b">assess-b</b></code> class, that class is now available to me. So I tentatively conclude: the banner is using two different classes, which are pulling colors from two different style sheets when they are available. The fix may be to make the banner module use the same class (probably <code><b class="class-b">class-b</b></code>) for both backgrounds. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:46, 2 May 2025 (UTC)
:::::::{{fixed}}, I think, with [https://en.wikipedia.org/w/index.php?title=Module%3AWikiProject_banner%2Fauxiliary&diff=1288445529&oldid=1272930615 this edit]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:50, 2 May 2025 (UTC)
:::::::Yup, even I was able to see the darker green color as of late. After your edit, I see the same color for both B's in the template. What I still do not understand is why the css was behaving differently for some of us, and differently for the rest yesterday. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 18:09, 2 May 2025 (UTC)
::::::::As I used to tell my customers when was a person who fixed computers: "I just fix things. Answering 'why' questions is a job for philosophers." – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 18:23, 2 May 2025 (UTC)
:::A search over Template & Module namespaces show that {{legend inline|#b2ff66|#b2ff66}} is the colour defined for B-Class at [[Module:Class/definition.json]] and [[Module:Class/styles.css]]. Where or why is it being called by the banner, I have no idea. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 22:15, 1 May 2025 (UTC)
::::[https://en.wikipedia.org/w/index.php?search=insource%3A%2Fb2ff66%2F&title=Special%3ASearch&profile=advanced&fulltext=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns118=1&ns119=1&ns126=1&ns127=1&ns710=1&ns711=1&ns828=1 Here's a possibly helpful set of search results]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 23:13, 1 May 2025 (UTC)

:Maybe this is the reason. [[Module:Class]] uses the <b class="assess-b">assess-b</b> class with css at [[Module:Class/styles.css]]<templatestyles src="Module:Class/styles.css"/> and [[Module:WikiProject banner]] uses the <b class="class-b">class-b</b> class with css at [[Module:WikiProject banner/styles.css]]<templatestyles src="Module:WikiProject banner/styles.css"/>. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 12:44, 2 May 2025 (UTC)
::I didn't think we were using [[Module:Class]] or [[Module:Class/styles.css]] anymore, but perhaps I'm wrong &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 14:28, 2 May 2025 (UTC)
:::When I am editing this talk page section and I pop open "Templates used in this section:", I see [[:Module:Class/styles.css]]. That page is transcluded in 43K pages. We could change the B-class color there to {{Background color|#DFFFBF|#DFFFBF}} and see if anyone complains. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 17:29, 2 May 2025 (UTC)
::::It's not just the B class that is a different shade when comparing those two css files. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 17:48, 2 May 2025 (UTC)
:::::If I remember correctly, the colors defined at [[Module:Class/definition.json]] were initially used for WP banners during the massive overhaul 2 years ago. There were complaints that these bright colors stand out too much and cause distraction to editors. Eventually, it was agreed to use a lighter pastel-like palette for all classes. <span class="nowrap">&#8212;'''[[User:CX Zoom|CX Zoom]]'''[he/him]</span> <sup class="nowrap">([[User talk:CX Zoom|let's talk]] • {[[Special:Contributions/CX Zoom|C]]•[[User:CX Zoom/X|X]]})</sup> 18:06, 2 May 2025 (UTC)
::::That's probably because WOSlinker manually added those styles to this page. If you look at [[User talk:MSGJ/Sandbox/1|my sandbox]] you will not find those styles being used &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 06:29, 6 May 2025 (UTC)
:::::Yes, I figured that out above, and fixed it. The discussion ended up a bit out of order. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 18:45, 7 May 2025 (UTC)
::::::So what do you see on my sandbox? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 07:08, 8 May 2025 (UTC)
:::::::In your sandbox I see: "[[User:MSGJ/Sandbox/1|1]]&nbsp;&nbsp;&nbsp;[[User:MSGJ/Sandbox/2|2]]&nbsp;&nbsp;&nbsp;[[User:MSGJ/Sandbox/3|3]]&nbsp;&nbsp;&nbsp;[[User:MSGJ/Sandbox/4|4]]" – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 13:38, 8 May 2025 (UTC)
::::::::{{replyto|Jonesey95}} Not those. MSGJ linked the relevant sandbox in [[#c-MSGJ-20250506062900-Jonesey95-20250502172900|their post of 06:29, 6 May 2025 (UTC)]]. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 13:59, 8 May 2025 (UTC)
:::::::::Sorry, I couldn't see the link through the noise here. I see two of the same color light-green (#DFFFBF) background, as I would expect after I changed the magnifying-glass cell to use class-b with [https://en.wikipedia.org/w/index.php?title=Module%3AWikiProject_banner%2Fauxiliary&diff=1288445529&oldid=1272930615 this edit]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 14:17, 8 May 2025 (UTC)
::::::::::Ah, okay I hadn't noticed that edit. So everything makes sense then! &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 06:09, 9 May 2025 (UTC)