View source for Module talk:Formatnum

{{Permanently protected}}
{{oldtfdfull|date= 2018 September 21 |result=keep |disc=Module:Formatnum}}

== language:formatNum(tonumber(number),…) ==

If {{serif|I}} read the code correctly, then <code>tonumber(number)</code> is already computed and stored in the variable named “value”. [[User:Incnis Mrsi|Incnis Mrsi]] ([[User talk:Incnis Mrsi|talk]]) 09:55, 22 October 2019 (UTC)
:
: {{re|Incnis Mrsi}} It's true that the variable {{var|value}} stores the numeric value of the parameter passed as {{var|number}}. However, if you read line 44, the <code>mw.language:formatNum()</code> call doesn't handle exponents properly. The lines 41 to 52 convert {{var|number}} to a string, then if there is an exponent, it stores the [[significand]] as a string back into {{var|number}} and the exponent in {{var|exponent}}. So by the time the code reaches lines 84 or 86 the string value in {{var|number}} may or may not be the same as that passed into the function. So it's necessary to again convert that string back to a number in order to use <code>mw.language:formatNum()</code>. Writing <code>language:formatNum(value, ...)</code> wouldn't work properly if the number passed contained an exponent. Hope that makes sense. --[[User:RexxS|RexxS]] ([[User talk:RexxS|talk]]) 16:18, 22 October 2019 (UTC)
:: Ah, got it{{snd}}the variable may be reassigned with <code>number = string.sub(number, 1, pos - 1)</code>. [[User:Incnis Mrsi|Incnis Mrsi]] ([[User talk:Incnis Mrsi|talk]]) 17:11, 22 October 2019 (UTC)

==Zero precision not working==

If I use <code>fn.formatNum(5435.12345,"en",2)</code> I get the result <code>5,435.12</code> as expected. Similarly with other positive values for precision. But with <code>fn.formatNum(5435.12345,"en",0)</code> the number is returned with all the post decimal point digits, i.e. <code>5,435.12345</code>). Looking at the code there are a couple of <code>if prec > 0 then ... elseif prec < 0 then .. end</code> blocks which suggests zero is ignored. Is this intentional or an oversight? <span style="font-family:Arial;background:#d6ffe6;border:solid 1px;border-radius:5px;box-shadow:darkcyan 0px 1px 1px;">&nbsp;&nbsp;[[User:Jts1882|Jts1882]]&nbsp;&#124;[[User talk:Jts1882|&nbsp;talk]]&nbsp;</span> 15:35, 9 December 2019 (UTC)

== #invoke ==

{{edit template-protected|answered=yes}}
The production code cannot be #invoke'd normally, only wrapped by templates. The sandbox code fixes this. [[User:Trigenibinion|Trigenibinion]] ([[User talk:Trigenibinion|talk]]) 11:56, 3 March 2021 (UTC)
:[[File:Red information icon with gradient background.svg|20px|link=|alt=]] '''Not done for now:''' please establish a [[Wikipedia:Consensus|consensus]] for this alteration '''[[Wikipedia:Edit requests|before]]''' using the {{tlx|edit template-protected}} template.<!-- Template:ETp --> It is not obvious to me that it would be beneficial to allow a module-version to be used. What is the proposed use case where it is necessary? (See also [[Template talk:Infobox]] for a related case.) [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 02:11, 5 June 2021 (UTC)
::This is needed so that this module or another one can be conditionally #invoke'd. See [[Template:FXConvert/sandbox]]. [[User:Trigenibinion|Trigenibinion]] ([[User talk:Trigenibinion|talk]]) 08:43, 17 July 2022 (UTC)
::: {{not done}} Nothing has changed since {{u|Izno}}'s decline. This request is part of a proposal to produce code bloat whose existence five people have objected to at TfD, and hence is by definition not uncontroversial enough for an edit request. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 14:34, 1 August 2022 (UTC)
::::Supporting #invoke has nothing to do with code bloat. It is only a couple lines of code. It is not required by [[Template:FXConvert]] or [[Module:Wordify]], it can be worked around, but that is not the best solution. [[User:Trigenibinion|Trigenibinion]] ([[User talk:Trigenibinion|talk]]) 16:11, 1 August 2022 (UTC)
:::::Asked and answered. Reopening without consensus is not acceptable. No TE in their right mind would make such an edit without the necessary garnered consensus. Rather than spinning your wheels, just go and get the necessary consensus. '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I.&nbsp;Ellsworth</span>]]'''''&thinsp;,&nbsp;[[Editor|<span style="color:black">ed.</span>]]&nbsp;[[User talk:Paine Ellsworth|<sup>put'r&nbsp;there</sup>]]&nbsp;<small>20:20, 5 August 2022 (UTC)</small>
::::::Isn't this the place to garner consensus? [[User:Trigenibinion|Trigenibinion]] ([[User talk:Trigenibinion|talk]]) 21:24, 15 August 2022 (UTC)
:::::::{{to|Trigenibinion}} yes, this talk page would be the place to garner consensus. Since this talk page may not be monitored by many editors, a [[WP:CAN|neutral invitation]] on other appropriate talk pages would put more eyes on your proposal. For some edits, especially major changes, a formal [[WP:RFC|RfC]] is used to help garner [[WP:consensus|consensus]]. '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I.&nbsp;Ellsworth</span>]]'''''&thinsp;,&nbsp;[[Editor|<span style="color:black">ed.</span>]]&nbsp;[[User talk:Paine Ellsworth|<sup>put'r&nbsp;there</sup>]]&nbsp;<small>18:49, 27 August 2022 (UTC)</small>