View source for Module talk:AfC submission catcheck

== What does this module do? ==

Any chance of some documentation or explanation? Any links to relevant discussions would be useful. Thanks &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 08:20, 1 October 2014 (UTC)
:{{ping|MSGJ}} I just added a doc page for it. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 12:00, 1 October 2014 (UTC)
::Thanks &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 12:01, 1 October 2014 (UTC)
== Requested move 23 June 2018 ==

<div class="boilerplate" style="background-color: #efe; margin: 2em 0 0 0; padding: 0 10px 0 10px; border: 1px dotted #aaa;"><!-- Template:RM top -->
:''The following discussion is an archived discussion of a [[WP:RM|requested move]]. <span style="color:red">'''Please do not modify it.'''</span> Subsequent comments should be made in a new section on the talk page. No further edits should be made to this section.''

'''No consensus to move at this time'''. [[User:BD2412|<span style="background:gold">'''''bd2412'''''</span>]] [[User talk:BD2412|'''T''']] 15:28, 14 July 2018 (UTC)

[[:Module:AFC submission catcheck]] → {{no redirect|Module:AFC submission check}} – Module does more than just check for categories.  [[User:Pppery|&#123;&#123;3x&#124;p&#125;&#125;ery]] ([[User talk:Pppery|talk]]) 17:40, 23 June 2018 (UTC)<small>--'''''Relisting.''''' [[User:TheSandDoctor|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">The</span><span style="color:#009933; font-weight:bold;">SandDoctor</span>]] <sup>[[User talk:TheSandDoctor|<span style="color:#009933;">Talk</span>]]</sup> 16:49, 1 July 2018 (UTC)</small>

* '''Comment''' – I don't think module and template names matter much, since they are not visible to readers.  And this one does not need a discussion to move it; so be bold and move it if you think that's a good idea, and if someone disagrees they'll let you know or move it back.  Not worthy of a wider discussion. [[User:Dicklyon|Dicklyon]] ([[User talk:Dicklyon|talk]]) 22:53, 5 July 2018 (UTC)
*:{{u|Dicklyon}}, we just had a huge issue with this module and [[Module:AfC]] being moved, because there are a half dozen pages and bots that use it in order to function properly that all broke. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 23:02, 5 July 2018 (UTC)
*::Why wasn't that mentioned in the move proposal?  And what's the compulsion to move it if it causes such problems to do so?  This RM is ridiculous to not spell these things out. [[User:Dicklyon|Dicklyon]] ([[User talk:Dicklyon|talk]]) 03:44, 6 July 2018 (UTC)
:''The above discussion is preserved as an archive of a [[WP:RM|requested move]].  <span style="color:red">'''Please do not modify it.'''</span> Subsequent comments should be made in a new section on this talk page. No further edits should be made to this section.''</div><!-- Template:RM bottom -->

== [[Template:Draft categories]] removes categories ==

{{ping|WOSlinker}} I created {{tl|Draft categories}} in May. [//en.wikipedia.org/w/index.php?title=Draft:Deanna_Kamiel&diff=848093886&oldid=848083720 Example use]. It is not advertised anywhere and has almost no uses but I'm planning to advertise it. Can the module be coded to not add [[:Category:AfC submissions with categories]] when {{tl|Draft categories}} prevents the categories from being added? PrimeBot made an unnecessary "fix" in [//en.wikipedia.org/w/index.php?title=Draft:Deanna_Kamiel&diff=848138539&oldid=848102738]. [[User:PrimeHunter|PrimeHunter]] ([[User talk:PrimeHunter|talk]]) 10:48, 30 June 2018 (UTC)

:{{ping|PrimeHunter}} I've created a version at [[Module:AFC submission catcheck/sandbox]] which I think should work. Did a little bit of testing and seemed ok. Have a look yourself and see what you think. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 13:05, 30 June 2018 (UTC)
::{{ping|WOSlinker}} Thanks. It looks good. [[User:PrimeHunter|PrimeHunter]] ([[User talk:PrimeHunter|talk]]) 15:31, 30 June 2018 (UTC)

== Template-protected edit request on 17 January 2019 ==

{{edit template-protected|Module:AFC submission catcheck|answered=yes}}

Hi. I'd like to add a line to the module, to remove another false positive.

From:

<code>
tc = removeFalsePositives(mw.ustring.gsub(tc,"%[%[Category:Articles created via the Article Wizard%]%]",""))</code>

To:
<br><code>
tc = removeFalsePositives(mw.ustring.gsub(tc,"%[%[Category:Articles created via the Article Wizard%]%]",""))<br>
tc = removeFalsePositives(mw.ustring.gsub(tc,"%[%[Category:Unsuitable for Wikipedia AfC submissions%]%]",""))</code>

This is because the category (Unsuitable for Wikipedia AfC submissions) is a part of the AfC proces, and so should not be removed  as a category that a draft is in.

Thanks,

--[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 19:17, 17 January 2019 (UTC)
:For a current example of why this is needed, see [[Draft:Annai Flim Factorie]] --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 19:17, 17 January 2019 (UTC)

*{{ping|WOSlinker}} I know it's been years - but do you have any feedback on this? — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 20:44, 17 January 2019 (UTC)
::While there's no harm calling removeFalsePositives twice, it only needs to be called once, so the following should do as well:
<pre>
tc = removeFalsePositives(mw.ustring.gsub(tc,"%[%[Category:Articles created via the Article Wizard%]%]",""))
tc = mw.ustring.gsub(tc,"%[%[Category:Unsuitable for Wikipedia AfC submissions%]%]","")
</pre>
::-- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 22:14, 17 January 2019 (UTC)
:::{{ping|WOSlinker}} Why does it only need to be called once and/or what purpose does having the separate function serve? --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 22:38, 17 January 2019 (UTC)
::::That function removes any html commented sections and nowiki sections from the text to look at.  So once removed there is no need to call it again to remove the text since it's already gone.  It's in a separate function as it's called from two separate places in the code, from with "checkforcats" and "submitted". Another option for the code is to split into 3 lines as below, which may be more readable. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 23:11, 17 January 2019 (UTC)
<pre>
tc = removeFalsePositives(tc)
tc = mw.ustring.gsub(tc,"%[%[Category:Articles created via the Article Wizard%]%]","")
tc = mw.ustring.gsub(tc,"%[%[Category:Unsuitable for Wikipedia AfC submissions%]%]","")
</pre>
:::::{{ping|WOSlinker}} Oh, I didn't realize that the articles created via the article wizard wasn't part of the actual function, but rather just nested inline. In that case, I would agree that it should be converted to 2 lines (and then add a 3rd that I am proposing) to improve readability. --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 00:37, 18 January 2019 (UTC)

=== More requests ===

;Request 2:

Purely to make the code easier to read:

Current line 7:

<pre>return mw.ustring.gsub(mw.ustring.gsub(str, "<!--.--->", ""), "<nowiki>.-</nowiki>", "")</pre>

Replacement:

<pre>
str = mw.ustring.gsub(str, "<!--.--->", "")
str = mw.ustring.gsub(str, "<nowiki>.-</nowiki>", "")
return str</pre>

;Request 3:

Remove category declarations that are nested within {{tl|Draft categories}}, since those don't actually categorize pages. Assuming that the above request is implemented, please add the following 2 lines directly before the "return str":

<pre>
str = mw.ustring.gsub(str, "{{Draft categories.-}}", "")
str = mw.ustring.gsub(str, "{{draft categories.-}}", "")</pre>

There are 2 different lines because lua is not case insensitive. To see a current example where this is needed, check out [[Draft:Nosheen Phoenix]]. As for as the specific coding above is concerned, I ''think'' that lua doesn't use <nowiki>{{ or }}</nowiki>, but if it does they should be escaped.

{{A note}} due to the limitations of displaying "nowiki" tags, it may seem unclear why this module uses "str = mw.ustring.gsub(str, "<nowiki>.-</nowiki>", "")". The middle string is actually "<nowiki><nowiki>.-</nowiki></nowiki>", and I put the original in the source code of this edit request to make it easier to copy-paste.

Thanks, --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 01:38, 18 January 2019 (UTC)
:I have created [[Module:AFC submission catcheck/sandbox]] with all three of the changes requested being implimented. --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 07:37, 18 January 2019 (UTC)

::All done. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 08:36, 18 January 2019 (UTC)

=== Even more ===

Sorry. I should have looked at this too before making the other requests

;Request 4:

Remove categories that are in the form "Category:Drafts about" (as seen [[:Category:Draft articles|here]]). This would be accomplished by adding the check:

<pre>
str = mw.ustring.gsub(str,"%[%[Category:Drafts about.-%]%]","")</pre>

I have implemented this request, and have moved this and the other checks for categories that shouldn't count into the "false positives" function for easier readability, at [[Module:AFC submission catcheck/sandbox]]. For a current example where this is needed, check out [[Draft:James Drake (wrestler)]]. Thanks, --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 04:52, 19 January 2019 (UTC)
:{{ping|WOSlinker}} if you have a minute, I have another request --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 04:52, 19 January 2019 (UTC)
::Done -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 08:50, 19 January 2019 (UTC)

== Template-protected edit request on 7 March 2019 ==

{{edit template-protected|Module:AFC submission catcheck|answered=yes}}

Please '''remove''' line 10 in its entirety:

<code>str = mw.ustring.gsub(str,"%[%[Category:Articles created via the Article Wizard%]%]","")</code>

Per [[Wikipedia:Categories for discussion/Log/2019 January 6#Category:Articles created via the Article Wizard]], the category was deleted.

Thanks, --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 07:52, 7 March 2019 (UTC)
: Done [[User:Pppery|&#123;&#123;3x&#124;p&#125;&#125;ery]] ([[User talk:Pppery|talk]])  12:34, 7 March 2019 (UTC)

== Template-protected edit request on 17 March 2019 ==

{{edit template-protected|Module:AFC submission catcheck|answered=yes}}
After line 11 (<code><nowiki>str = mw.ustring.gsub(str,"%[%[Category:Drafts about.-%]%]","")</nowiki></code>), please add:

<code><nowiki>str = mw.ustring.gsub(str, "{{[Ss]uppress categories.-}}", "")</nowiki></code>

So that categories that are suppressed with {{tl|Suppress categories}} do not create false positives (they aren't actually categorized, but they are labeled as having categories). For an example of such a false positive, see [[Special:Permalink/888225677]]. Thanks, --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 19:26, 17 March 2019 (UTC)
: {{Ping|DannyS712}} Why would one use {{tl|suppress categories}} as oppposed to {{tl|Draft categories}} on a draft? [[User:Pppery|&#123;&#123;3x&#124;p&#125;&#125;ery]] ([[User talk:Pppery|talk]])  19:31, 17 March 2019 (UTC)
::{{ping|Pppery}} I'm not sure, but I've seen it before (don't remember where) and it has the same result. Maybe if there are more experienced editors, who are prohibited from creating new articles directly, they submit AfC drafts and use suppress categories instead. --[[User:DannyS712|DannyS712]] ([[User talk:DannyS712|talk]]) 19:33, 17 March 2019 (UTC)
:[[File:Red information icon with gradient background.svg|20px|link=|alt=]] '''Not done:''' please establish a [[Wikipedia:Consensus|consensus]] for this alteration '''[[Wikipedia:Edit requests|before]]''' using the {{tlx|edit template-protected}} template.<!-- Template:ETp --> It seems like there is already an existing template that can/should be used, so unless there's a consensus to change what appears to be the current norms I don't see this being necessary. I would also note that there are (currently) zero draft pages that use {{t|suppress categories}}. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 23:15, 21 March 2019 (UTC)

== Alternative approach to implementation ==

I see the experimental [https://www.mediawiki.org/wiki/Extension:CategoryToolbox Extension:CategoryToolbox]has the function 'mw.ext.cattools.havePages':
:mw.ext.cattools.havePages( categories, pages, [ depth ], [ mode ] )
...
:If you specify mode as OR: for each page provided in the pages table, it checks if it belongs to at least one category, provided in the ''categories'' table.
IIUC, it is not expensive when not used recursively; i.e. when we test for direct membership of a category, rather than membership of subcategories. &mdash; [[User:Chalst|''Charles Stewart'']] <small>[[User_talk:Chalst|(talk)]]</small> 14:22, 16 December 2020 (UTC)
: [[mw:Extension:CategoryToolbox]] is not installed on Wikipedia. [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 04:28, 22 December 2020 (UTC)

== Template-protected edit request on 4 September 2021 ==

{{edit template-protected|Module:AfC submission catcheck|answered=yes}}
Another false positive case [[:Category:Draft articles]] on for example [[Draft:PeanutButterGamer]] Cheers [[User:KylieTastic|KylieTastic]] ([[User talk:KylieTastic|talk]]) 11:58, 4 September 2021 (UTC)
:{{done}}. I changed the plural "Drafts" to optionally ignore the s ("Drafts?"). <!-- Template:ETp --> [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:08, 4 September 2021 (UTC)

== Template-protected edit request on 19 March 2023 ==

{{edit template-protected|Module:AfC submission catcheck|answered=yes}}
I've seen several uses of {{tl|Draft Categories}} getting stuck in [[:Category:AfC submissions with categories]] suggest change from  

<syntaxhighlight lang="lua">
str = mw.ustring.gsub(str, "{{[Dd]raft categories[^{}]-{{[^{}]-}}[^{}]-}}", "")
str = mw.ustring.gsub(str, "{{[Dd]raft categories.-}}", "")
</syntaxhighlight>

to

<syntaxhighlight lang="lua">
str = mw.ustring.gsub(str, "{{[Dd]raft [Cc]ategories[^{}]-{{[^{}]-}}[^{}]-}}", "")
str = mw.ustring.gsub(str, "{{[Dd]raft [Cc]ategories.-}}", "")
</syntaxhighlight> Cheers  [[User:KylieTastic|KylieTastic]] ([[User talk:KylieTastic|talk]]) 16:11, 19 March 2023 (UTC)
:{{done}}<!-- Template:ETp --> [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 16:15, 19 March 2023 (UTC)

== Template-protected edit request on 1 September 2024 ==

{{edit template-protected|answered=yes}}
Currently, this module gives false positives when the redirect {{tl|draftcat}} is used. I think the solution would be adding something like:
<syntaxhighlight lang="lua">
str = mw.ustring.gsub(str, "{{[Dd]raftcat[^{}]-{{[^{}]-}}[^{}]-}}", "")
str = mw.ustring.gsub(str, "{{[Dd]raftcat.-}}", "")
</syntaxhighlight> [[User:Jlwoodwa|jlwoodwa]] ([[User talk:Jlwoodwa|talk]]) 00:14, 1 September 2024 (UTC)

:Coukd you explain what this regex and test this in a sandbox ? [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2;">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 15:30, 15 September 2024 (UTC)
::@[[User:Jlwoodwa|Jlwoodwa]] ^^ [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2;">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 15:30, 15 September 2024 (UTC)
::It's based on the existing lines 9 and 10, which were added in [[Special:Diff/932782470]] and [[Special:Diff/878994611]] respectively. The second line is straightforward{{snd}}remove any substring that starts with <code><nowiki>{{draftcat</nowiki></code>, up to the next instance of <code><nowiki>}}</nowiki></code> (where <code>.-</code> means "match zero or more of any character, non-greedily"). The first line is a modification of the second to deal with <code><nowiki>{{DEFAULTSORT:foo}}</nowiki></code> inside the {{tl|draftcat}} invocation; each <code><nowiki>[^{}]-</nowiki></code> part means "match zero or more of any character ''except curly braces'', non-greedily".
::Since it's a straightforward copy of the existing patterns for {{tl|draft categories}}, I don't think it should break anything, but I'll test it in a sandbox just to make sure. [[User:Jlwoodwa|jlwoodwa]] ([[User talk:Jlwoodwa|talk]]) 19:24, 15 September 2024 (UTC)
:::{{ping|Sohom Datta}} Seems to work{{snd}}see [[Module talk:AfC submission catcheck/testcases]]. [[User:Jlwoodwa|jlwoodwa]] ([[User talk:Jlwoodwa|talk]]) 19:29, 15 September 2024 (UTC)
:{{done}}<!-- Template:ETp --> [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2;">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 20:34, 15 September 2024 (UTC)

==Template-protected edit request ==
{{Edit template-protected|Module:AfC submission catcheck|answered=yes}}
Please add 
<code><nowiki> str = mw.ustring.gsub(str, "<pre>.-</pre>", "") </nowiki></code>
Some people use &lt;pre> to disable categories. Thanks, [[User:Polygnotus|Polygnotus]] ([[User talk:Polygnotus|talk]]) 06:21, 7 December 2024 (UTC)
:{{done}}<!-- Template:ETp --> [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 06:51, 7 December 2024 (UTC)