View source for Module talk:ATP rankings

{{WikiProject banner shell |1=
{{WikiProject Tennis}}
}}

== Pre-launch thoughts ==

Couple things I've noticed in my initial tests, I'll split them into subsections to discuss as I find them. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:37, 31 July 2023 (UTC)
===Regions===
Some of the [[:Category:ATP Tour navigational boxes|ATP Tour navigational boxes]] are for regions (Africa, Europe, etc) - is it worth trying to get a mega-list? My initial thought is no and to send those to TFD for further discussion. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:15, 31 July 2023 (UTC)

===Disambiguation===
How to deal with disambiguations, for example [[Ben Shelton]] should be [[Ben Shelton (tennis)]]. [[Module:Disambiguation]] will tell us if it ''is'' a dab, but won't necessarily give us the correct disambiguator to append - though I would put money on (tennis) being used in 99% of cases).[[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:15, 31 July 2023 (UTC)
:For disambiguation pages, I feel like the best approach would be something like:
:# If there is a manual mapping for the name to a page, use that. We can have a new JSON module where those are stored.
:# If the undisambiguated title is not a disambig page, use that.
:# If a page with (tennis) exists, use that.
:# If there is a disambiguation page (as opposed to no page at all), don't link to it but add a category so manual mappings (see step 1) can be added.
:[[User:Taavi|Taavi]] ([[User talk:Taavi|talk!]]) 12:24, 31 July 2023 (UTC)
::Good idea. Categorise the dab names and make a list (either in a separate json or just a submodule) to perform a swap. This will also work for pages where the name on the PDF might not match up exactly with the Wikipedia name and allow us to override if necessary. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:40, 31 July 2023 (UTC)
:::I ''think'' I can call this {{done}}; the disambiguation code seems to work for <code>(tennis)</code> and I've added in some tracking for pages that don't quite meet the planned-for exceptions (i.e. "forced disambiguation"). [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 11:53, 1 August 2023 (UTC)
::::There's a possibility that I'll move [[Module:ATP rankings/data/disambiguation]] to a JSON page and change it's format slightly to allow using the same file to override a country for a specific player when that's needed (Russia and Belarus for example). [[User:Taavi|Taavi]] ([[User talk:Taavi|talk!]]) 18:24, 1 August 2023 (UTC)
:::::That's a really good idea, actually. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 18:25, 1 August 2023 (UTC)

===Bad country returned===
I know the module currently doesn't have the Russian and Belarusian players since that aspect of the bot/json is still under construction, but we should probably have a non-Lua warning given if the code is given incorrectly (like I keep doing with <code>SPA</code> instead of <code>ESP</code> for Spain). [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:37, 31 July 2023 (UTC)

:Is [[Special:Diff/1168253505]] what you had in mind? [[User:Taavi|Taavi]] ([[User talk:Taavi|talk!]]) 18:22, 1 August 2023 (UTC)
::Something like that. I know there are a few folk who are not overly thrilled with the idea of error messages showing up as [[:Category:Pages with script errors|script errors]] but honestly gigantic red messages to me get the point across more than sufficiently. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 18:24, 1 August 2023 (UTC)

== RUS and BUL ==

{{u|Taavi}}, any update on the Russia/Bulgaria no-country issue? [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 08:29, 17 August 2023 (UTC)

:@[[User:Primefac|Primefac]] Thanks for the ping, sorry for the delay. I went ahead and converted the old disambiguation module to [[Module:ATP rankings/data/overrides.json]] and added support for a new <code>country</code> field to manually override countries for specific players. Note that the country data is parsed by the bot during the weekly imports, not when the template is rendered, so changes aren't instant. [[User:Taavi|Taavi]] ([[User talk:Taavi|talk!]]) 15:18, 3 September 2023 (UTC)
::Yeah, figured any changes made would have to wait for the next round of updates. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 16:35, 3 September 2023 (UTC)
:::{{bcc|Taavi}} So just to check, we should manually input the overrides for the RUS/BUL players, and the bot will match that with the current rank. Yes? [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:52, 20 September 2023 (UTC)
::::{{bcc|Primefac}}Yes, that's correct. [[User:Taavi|Taavi]] ([[User talk:Taavi|talk!]]) 19:41, 23 September 2023 (UTC)

== Edition day of the ATP rankings ==
One day does not correspond to the rankings release date, e.g. [https://en.wikipedia.org/wiki/Adrian_Mannarino#External_links ''As of Oct 13, 2024''], but the rankings was published on [http://www.protennislive.com/posting/ramr/singles_entry_numerical.pdf ''October 14, 2024'']. [[User:Kacir|Kacir]] 15:32, 16 October 2024 (UTC)
:Fixed. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 15:41, 16 October 2024 (UTC)
::Thank you. [[User:Kacir|Kacir]] 15:43, 16 October 2024 (UTC)

== Armenia ==

{{ping|Primefac}} Can you please investigate why 
<code><nowiki>{{Top male singles tennis players by country|ARM}}</nowiki></code> 
{{Top male singles tennis players by country|ARM}}
returns an error ? [[User:Joeykai|Joeykai]] ([[User talk:Joeykai|talk]]) 04:10, 17 March 2025 (UTC)
:In order to give a +/- indicator for rank changes, it needs to compare the most recent week with the previous week's rankings. On 2 March Daniil Sarksian was added to the table but there was no ranking for the previous week, so it throws an error. The next time the table is updated it should go away. I will have a think about how best to deal with this; in the past it's just shown a "silly" number (usually + whatever rank they were listed at) but obviously throwing large errors isn't ideal. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 12:27, 17 March 2025 (UTC)

== Guadeloupe ==

{{ping|Primefac}} Can you please investigate why 
<code><nowiki>{{Top male singles tennis players by country|GUD}}</nowiki></code> 
{{Top male singles tennis players by country|GUD}}
returns an error ? [[User:Joeykai|Joeykai]] ([[User talk:Joeykai|talk]]) 21:04, 20 March 2025 (UTC)
:Because [[Guadeloupe]] is not an IOC-recognised country. [[User:Primefac|Primefac]] ([[User talk:Primefac|talk]]) 22:30, 20 March 2025 (UTC)
:: Since the ATP ranks players representing Guadeloupe, shouldn't this be fixed ? [[User:Joeykai|Joeykai]] ([[User talk:Joeykai|talk]]) 21:49, 22 March 2025 (UTC)