View source for MediaWiki talk:RefToolbarConfig.js/Archive 1

==Coauthors==
Please do not remove the coauthors field until the auto-filling function is updated to support multiple authors. Otherwise this will completely break auto-filling from a DOI/ISBN for works that have multiple authors. <span style="font-family:Broadway">[[User:Mr.Z-man|Mr.]][[User talk:Mr.Z-man|'''''Z-'''man'']]</span> 18:01, 9 February 2014 (UTC)

== Protected edit request on 8 April 2014 ==

{{edit protected|<!-- Page to be edited -->|answered=yes}}
Hello!

Since "<code>$j</code>" is deprecated, could someone replace this by "<code>$</code>"? [[User:Helder.wiki|Helder.wiki]] 00:31, 8 April 2014 (UTC)
:{{Reply to|Helder.wiki}} Will this change how the script works in any way? <b>[[User:Callanecc|Callanecc]]</b> ([[User talk:Callanecc|talk]] • [[Special:Contributions/Callanecc|contribs]] • [[Special:Log/Callanecc|logs]]) 08:13, 9 April 2014 (UTC)
::{{reply to|Callanecc}} Not really. The global variable [https://github.com/wikimedia/mediawiki-core/blob/648667ac9f0848dfbb75b513d79c73d7a5e5b7b1/resources/src/mediawiki/mediawiki.js#L2406-L2408 <code>$j</code> is defined as <code>$</code>] but will be removed soon. [[User:Helder.wiki|Helder.wiki]] 09:31, 9 April 2014 (UTC)
:::{{Reply to|Helder.wiki}} So if I change "<code>$j</code>" to "<code>$</code>" it won't break anything? <b>[[User:Callanecc|Callanecc]]</b> ([[User talk:Callanecc|talk]] • [[Special:Contributions/Callanecc|contribs]] • [[Special:Log/Callanecc|logs]]) 09:58, 9 April 2014 (UTC)
::::{{Reply to|Callanecc}} Yep. We did a [[Special:Diff/599725964|similar change]] in other parts of the script a few days ago: [[MediaWiki talk:RefToolbarNoDialogs.js#Use of "$j" is deprecated. Use $ or jQuery instead]] and [[MediaWiki talk:Gadget-refToolbarBase.js#Use of "$j" is deprecated. Use $ or jQuery instead]]. But I forgot about this RefToolbarConfig.js. [[User:Helder.wiki|Helder.wiki]] 10:25, 9 April 2014 (UTC)
:::::[[File:Yes check.svg|20px|link=|alt=]] '''Done'''<!-- Template:EP --> thank you. <b>[[User:Callanecc|Callanecc]]</b> ([[User talk:Callanecc|talk]] • [[Special:Contributions/Callanecc|contribs]] • [[Special:Log/Callanecc|logs]]) 11:00, 9 April 2014 (UTC)

== Urlstatus ==

{{edit protected|answered=yes}}
This was requested on [[Wikipedia:Village pump (technical)/Archive_175#RefToolbar]], without any objections. Add the following in a newline after line 64. It should be added along with [[MediaWiki talk:RefToolbarMessages-en.js#Urlstatus]]. The change will add an edit field for the url-status parameter for the cite web template. (url-status is the new parameter for dead links)

<code>{"field": "url-status", "tooltip":"cite-urlstatus-tooltip"}</code>
--[[User:Snaevar|Snaevar]] ([[User talk:Snaevar|talk]]) 21:55, 9 October 2019 (UTC)
:@[[User:Snaevar|Snaevar]]: Done (though technically, you're missing a comma that needs to be added in your edit request). The tooltip could probably stand to be expanded upon though; it's not super descriptive as is. [[User:Writ Keeper|Writ&nbsp;Keeper]]&nbsp;[[User Talk: Writ Keeper|&#9863;]][[Special:Contributions/Writ_Keeper|&#9812;]] 14:34, 10 October 2019 (UTC)

== normalize parameter names ==

{{edit interface-protected|answered=yes}}
cs1|2 is (slowly) moving to deprecate and remove all-run-together multiword parameter names with hyphenated parameter names.  [[WP:RefToolbar]] should not create cs1 templates that include parameters that will be deprecated and their support withdrawn.  Switching to the hyphenated forms now will ease the cleanup requirements later.  To that end, I propose that [[MediaWiki:RefToolbarConfig.js|RefToolbarConfig.js]] shall be changed by replacing the code at certain line numbers with the code as listed in the table.
{| class="wikitable"
|+proposed changes
! line # !! new code
|-
| 49 || {{code|lang=js|{"field": "access-date"},}}
|-
| 54 || {{code|lang=js|{"field": "author<N>-link", "tooltip":"cite-authorlink-tooltip", 'increment_group':'authorlink', 'increment_button':true},}}
|-
| 55 || {{code|lang=js|{"field": "archive-url"},}}
|-
| 56 || {{code|lang=js|{"field": "archive-date"},}}
|-
| 74 || {{code|lang=js|{"field": "access-date"},}}
|-
| 84 || {{code|lang=js|{"field": "author<N>-link", "tooltip":"cite-authorlink-tooltip", 'increment_group':'authorlink', 'increment_button':true},}}
|-
| 85 || {{code|lang=js|{"field": "archive-url"},}}
|-
| 86 || {{code|lang=js|{"field": "archive-date"},}}
|-
| 109 || {{code|lang=js|{"field": "access-date"},}}
|-
| 115 || {{code|lang=js|{"field": "author<N>-link", "tooltip":"cite-authorlink-tooltip", 'increment_group':'authorlink', 'increment_button':true},}}
|-
| 119 || {{code|lang=js|{"field": "archive-url"},}}
|-
| 120 || {{code|lang=js|{"field": "archive-date"},}}
|-
| 141 || {{code|lang=js|{"field": "access-date"},}}
|-
| 146 || {{code|lang=js|{"field": "author<N>-link", "tooltip":"cite-authorlink-tooltip", 'increment_group':'authorlink', 'increment_button':true},}}
|}
—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 14:11, 25 October 2020 (UTC)
*LGTM from a technical standpoint. Changes appear to be consistent with the [[Help_talk:Citation_Style_1/Archive_5#RFC:_Citation_Style_1_parameter_naming_convention|2014 RFC]]. – [[User:SD0001|<span style="font-weight: bold; color: green">SD0001</span>]] ([[User talk:SD0001|talk]]) 14:21, 16 November 2020 (UTC)
:[[File:Yes check.svg|20px|link=|alt=]] '''Done'''<!-- Template:EIp --> &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 19:15, 22 November 2020 (UTC)
:::{{u|MSGJ}} and {{u|SD0001}}, there are still some issues here, even after we've [[Wikipedia_talk:RefToolbar#Autofill_access-date_button_not_there|gotten the access date autofill button back]]. The archive URL label is currently displaying as "Archive-url", and a bunch of others are similar. Regardless of how we label them behind the scenes, the actual display should be grammatical, so capitalizing "URL", no dash, etc. I think we may need to make some edits to [[MediaWiki:RefToolbarMessages-en.js]] to get the proper configurations back? <span style="color:#AAA"><small>&#123;{u&#124;</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}&#125;</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 21:58, 24 November 2020 (UTC)
:::{{ping|Trappist the monk}} &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 22:28, 24 November 2020 (UTC)
::::<small>Oops, sorry I forgot to ping you, Trappist! <span style="color:#AAA"><small>&#123;{u&#124;</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}&#125;</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 23:13, 24 November 2020 (UTC)</small>
::::I have only sufficient js skills to have figured out how to prevent this tool from emitting cs1|2 citation templates that use to-be-deprecated parameters.  But, if I had to guess, I would guess at these changes:
:::::{| class="wikitable"
|+guesses
! line # !! new code
|-
| 67 || {{code|lang=js|'cite-access-date-label' : 'Access date',}}
|-
| 69 || {{code|lang=js|'cite-author-link-label' : "Author's article",}}
|-
| 70<sup>†</sup> || {{code|lang=js|'cite-url-status-label' : 'URL status',}}
|-
| 71 || {{code|lang=js|'cite-archive-url-label' : 'Archive URL',}}
|-
| 72 || {{code|lang=js|'cite-archive-date-label' : 'Archive date',}}
|}
:::::<sup>†</sup> {{para|coauthors}} is not a supported cs1{{pipe}}2 parameter
::::It may be that lines 87–90 and 93–95 can be deleted because, apparently, the label does not change for each successive click of the add-another button.
::::
::::{{lang|la|caveat lector}}
::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 23:21, 24 November 2020 (UTC)
:::::{{u|Trappist the monk}} and {{u|MSGJ}}, this appears to have fallen off the table, which is not good. Can we make sure it gets implemented? <span style="color:#AAA"><small>&#123;{u&#124;</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}&#125;</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 06:33, 3 December 2020 (UTC)
::::::I have given all the help that I know how to give.  I am not an IA so cannot do the change.
::::::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 14:02, 3 December 2020 (UTC)
{{outdent}}
:[[File:Yes check.svg|20px|link=|alt=]] '''Done'''<!-- Template:EIp --> I have implemented the "guesses". Please reopen with a specific request if something else needs to be done. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 20:17, 15 December 2020 (UTC)
::Looks to me like it's working now. Thanks, Izno! <span style="color:#AAA"><small>&#123;{u&#124;</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}&#125;</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 23:13, 15 December 2020 (UTC)

Re-opening as {{para|authorlink}} and its enumerated versions are still being generated, rather than the desired {{para|author-link}}. --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 07:24, 14 March 2021 (UTC)
:Are you sure?  If I create a {{tlx|cite book}} from isbn 978-0-679-60168-5 and add Jane Austen as author's article I get:
::<code><nowiki><ref>{{cite book |last1=Austen |first1=Jane |author1-link=Jane Austen |title=Pride and prejudice |date=1995 |publisher=Modern Library |location=New York |isbn=978-0-679-60168-5}}</ref></nowiki></code>
:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 12:45, 14 March 2021 (UTC)
::Yes, I'm sure. I haven't tried letting it generate the details from an ISBN, but if you just type in all the details manually, it generates "authorlink", or its enumerated variants if you type in more than one author. That's why the "authorlink" count is going up, while the other three biggies are going down. --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 16:50, 14 March 2021 (UTC)
:::Where the tool gets the data to fill in the form should not matter.  But, to try it, I just hand entered:
::::Last name: Austen
::::First name: Jane
::::Title: Pride and Prejudice
::::Author's article: Jane Austen
:::and from that I get:
::::<code><nowiki><ref>{{cite book |last1=Austen |first1=Jane |author1-link=Jane Austen |title=Pride and Prejudice}}</ref></nowiki></code>
:::This is the correct and expected output.
:::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 17:13, 14 March 2021 (UTC)
::::Here's what I get when I enter those exact same details (I hate the horizontal format)
::::<code><nowiki><ref>{{cite book
|last=Austen
|first=Jane
|authorlink=Jane Austen
|title=Pride and Prejudice}}</ref></nowiki></code>
::::BTW, I don't see any field labeled "Author's article", instead I see "Authorlink:" I suspect the difference may be because we are using different versions of the wiki editor. I believe I'm using some old version (can't be sure, as I use an external editor for most of my editing). --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 17:34, 14 March 2021 (UTC)
::::Hmm, tried typing in ISBN. Doesn't generate anything other than what I've already typed manually. But whatever it is that I'm using, it's almost certainly responsible for the count going up. --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 17:46, 14 March 2021 (UTC)
:::::Found it! This is the culprit: [[Wikipedia:RefToolbar/1.0]]. --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 18:11, 14 March 2021 (UTC)
::::::Hmm, I can see why no-one wants to maintain [[MediaWiki:RefToolbarLegacy.js]]. I stuck with the old toolbar because I like some of its buttons, and I never use the cite-generating tools. But (and I'm speculating here) I suspect the best solution will be to withdraw the old toolbar completely (after giving plenty of notice), as its small benefit isn't worth the trouble of maintaining obsolete code? --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 18:59, 14 March 2021 (UTC)
:::::::It looks like we may need an interface editor to modify this script to update many parameters at [[MediaWiki:RefToolbarLegacy.js]], including accessdate, trans_title, and more. In order for such an editor to respond effectively, we need to identify which lines of the script need to be changed, as Trappist did above for this page. I have marked this edit request as answered, since it has technically been done. A new edit request, with proposed edits, should be opened at the other script's talk page. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 01:02, 15 March 2021 (UTC)
::::::::Thanks, that would be good if someone's willing and able to do it. But I won't be too surprised or upset if they say, "Yuk, not worth the effort", in which case the best course is probably to withdraw the old toolbar. --[[User:NSH001|NSH001]] ([[User talk:NSH001|talk]]) 05:29, 15 March 2021 (UTC)
:{{slink|MediaWiki_talk:RefToolbarLegacy.js#normalize_parameter_names}}
:—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 13:56, 16 March 2021 (UTC)
::Done.
::—[[User:Trappist the monk|Trappist the monk]] ([[User talk:Trappist the monk|talk]]) 14:55, 5 April 2021 (UTC)

== Interface-protected edit request on 16 November 2020 ==

{{edit interface-protected|MediaWiki:RefToolbarConfig.js|answered=yes}}
Continuing from [[MediaWiki_talk:RefToolbarMessages-en.js#Interface-protected_edit_request_on_24_October_2020]], please add the new tooltips to complete the implementation, as demonstrated [https://en.wikipedia.org/w/index.php?title=User:Sdkb/sandbox/testpage&type=revision&diff=989043469&oldid=989042492&diffmode=source here]. <span style="color:#AAA"><small>&#123;{u&#124;</small><span style="border-radius:9em;padding:0 5px;background:#088">[[User:Sdkb|<span style="color:#FFF">'''Sdkb'''</span>]]</span><small>}&#125;</small></span> <sup>[[User talk:Sdkb|'''talk''']]</sup> 19:02, 16 November 2020 (UTC)
:[[File:Yes check.svg|20px|link=|alt=]] '''Done'''<!-- Template:EIp --> &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 19:18, 22 November 2020 (UTC)