View source for MediaWiki talk:Gadget-calculator.js

== Make it previewable ==

{{edit interface-protected|MediaWiki:Gadget-calculator.js|answered=yes}}
Currently it doesn't work in live preview, reply tool, etc. This should fix it ([[Special:EditPage/User:Nardog/Gadget-calculator.js|code]]).

<!-- Generated using w:en:User:NguoiDungKhongDinhDanh/FormattedEditRequest -->
{| class="diff diff-editfont-monospace" style="margin: auto; font-size: small; overflow-wrap: break-word;"
|-
| class="diff-lineno" | Line 176:
| class="diff-lineno" | Line 176:
|-
| class="diff-context diff-side-deleted" | 
| class="diff-context diff-side-added" | 
|-
| class="diff-context diff-side-deleted" | <nowiki>	// Evaluate the value of an AST at runtime.</nowiki>
| class="diff-context diff-side-added" | <nowiki>	// Evaluate the value of an AST at runtime.</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>	var evaluate = function( ast ) {</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>	var evaluate = function( ast</nowiki><ins class="diffchange diffchange-inline"><nowiki>, parserOutput</nowiki></ins><nowiki> ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if ( ast instanceof Numb ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if ( ast instanceof Numb ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			return ast.value;</nowiki>
| class="diff-context diff-side-added" | <nowiki>			return ast.value;</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		}</nowiki>
| class="diff-context diff-side-added" | <nowiki>		}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if ( ast instanceof Ident ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if ( ast instanceof Ident ) {</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>			var elm = </nowiki><del class="diffchange diffchange-inline"><nowiki>document</nowiki></del><nowiki>.</nowiki><del class="diffchange diffchange-inline"><nowiki>getElementById</nowiki></del><nowiki>( 'calculator-field-' + ast.value );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>			var elm = </nowiki><ins class="diffchange diffchange-inline"><nowiki>parserOutput</nowiki></ins><nowiki>.</nowiki><ins class="diffchange diffchange-inline"><nowiki>querySelector</nowiki></ins><nowiki>( '</nowiki><ins class="diffchange diffchange-inline"><nowiki>#</nowiki></ins><nowiki>calculator-field-' + ast.value );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			if ( elm.tagName === 'INPUT' ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>			if ( elm.tagName === 'INPUT' ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>				if ( elm.type === 'radio' || elm.type === 'checkbox' ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>				if ( elm.type === 'radio' || elm.type === 'checkbox' ) {</nowiki>
|-
| class="diff-lineno" | Line 192:
| class="diff-lineno" | Line 192:
|-
| class="diff-context diff-side-deleted" | <nowiki>		}</nowiki>
| class="diff-context diff-side-added" | <nowiki>		}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if ( ast instanceof Operator ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if ( ast instanceof Operator ) {</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>			evaledArgs = ast.args.map( </nowiki><del class="diffchange diffchange-inline"><nowiki>evaluate</nowiki></del><nowiki> )</nowiki><del class="diffchange diffchange-inline"><nowiki>;</nowiki></del>
| class="diff-addedline diff-side-added" | <nowiki>			evaledArgs = ast.args.map( </nowiki><ins class="diffchange diffchange-inline"><nowiki>function</nowiki></ins><nowiki> </nowiki><ins class="diffchange diffchange-inline"><nowiki>(arg</nowiki></ins><nowiki>)</nowiki><ins class="diffchange diffchange-inline"><nowiki> {</nowiki></ins>
|-
| class="diff-empty diff-side-deleted" | 
| class="diff-addedline diff-side-added" | <nowiki>				return evaluate( arg, parserOutput );</nowiki>
|-
| class="diff-empty diff-side-deleted" | 
| class="diff-addedline diff-side-added" | <nowiki>			});</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			if ( mathFuncs.indexOf(ast.op) !== -1 ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>			if ( mathFuncs.indexOf(ast.op) !== -1 ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>				return Math[ast.op].apply( Math, evaledArgs );</nowiki>
| class="diff-context diff-side-added" | <nowiki>				return Math[ast.op].apply( Math, evaledArgs );</nowiki>
|-
| class="diff-lineno" | Line 276:
| class="diff-lineno" | Line 278:
|-
| class="diff-context diff-side-deleted" | 
| class="diff-context diff-side-added" | 
|-
| class="diff-context diff-side-deleted" | <nowiki>	// Start code that does setup and HTML interaction.</nowiki>
| class="diff-context diff-side-added" | <nowiki>	// Start code that does setup and HTML interaction.</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>	var setup = function() {</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>	var setup = function(</nowiki><ins class="diffchange diffchange-inline"><nowiki> $content </nowiki></ins><nowiki>) {</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>		var elms = Array.from( </nowiki><del class="diffchange diffchange-inline"><nowiki>document</nowiki></del><nowiki>.</nowiki><del class="diffchange diffchange-inline"><nowiki>getElementsByClassName</nowiki></del><nowiki>( 'calculator-field' ) );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>		var elms = Array.from( </nowiki><ins class="diffchange diffchange-inline"><nowiki>$content</nowiki></ins><nowiki>.</nowiki><ins class="diffchange diffchange-inline"><nowiki>find</nowiki></ins><nowiki>( '</nowiki><ins class="diffchange diffchange-inline"><nowiki>.</nowiki></ins><nowiki>calculator-field' ) );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if (elms.length &gt; 200) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if (elms.length &gt; 200) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			console.log( "Too many calculator widgets on page" );</nowiki>
| class="diff-context diff-side-added" | <nowiki>			console.log( "Too many calculator widgets on page" );</nowiki>
|-
| class="diff-lineno" | Line 346:
| class="diff-lineno" | Line 348:
|-
| class="diff-context diff-side-deleted" | <nowiki>		console.log( "Change happened!" );</nowiki>
| class="diff-context diff-side-added" | <nowiki>		console.log( "Change happened!" );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		inProgressRefresh = {};</nowiki>
| class="diff-context diff-side-added" | <nowiki>		inProgressRefresh = {};</nowiki>
|-
| class="diff-empty diff-side-deleted" | 
| class="diff-addedline diff-side-added" | <nowiki>		// Fall back on body</nowiki>
|-
| class="diff-empty diff-side-deleted" | 
| class="diff-addedline diff-side-added" | <nowiki>		var parserOutput = e.target.closest( '.mw-parser-output, body' );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		var itemId = e.target.id.replace( /^calculator-field-/, '' );</nowiki>
| class="diff-context diff-side-added" | <nowiki>		var itemId = e.target.id.replace( /^calculator-field-/, '' );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		inProgressRefresh[itemId] = true;</nowiki>
| class="diff-context diff-side-added" | <nowiki>		inProgressRefresh[itemId] = true;</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		for ( var i in backlinks[itemId] ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		for ( var i in backlinks[itemId] ) {</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>			refresh( backlinks[itemId][i] );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>			refresh( backlinks[itemId][i]</nowiki><ins class="diffchange diffchange-inline"><nowiki>, parserOutput</nowiki></ins><nowiki> );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		}</nowiki>
| class="diff-context diff-side-added" | <nowiki>		}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if ( e.target.type === 'radio' ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if ( e.target.type === 'radio' ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			// when a radio element gets checked, others get unchecked.</nowiki>
| class="diff-context diff-side-added" | <nowiki>			// when a radio element gets checked, others get unchecked.</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>			var otherElms = </nowiki><del class="diffchange diffchange-inline"><nowiki>document</nowiki></del><nowiki>.</nowiki><del class="diffchange diffchange-inline"><nowiki>getElementsByName</nowiki></del><nowiki>( e.target.name );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>			var otherElms = </nowiki><ins class="diffchange diffchange-inline"><nowiki>parserOutput</nowiki></ins><nowiki>.</nowiki><ins class="diffchange diffchange-inline"><nowiki>querySelectorAll</nowiki></ins><nowiki>(</nowiki><ins class="diffchange diffchange-inline"><nowiki> '[name="' +</nowiki></ins><nowiki> e.target.name</nowiki><ins class="diffchange diffchange-inline"><nowiki> + '"]'</nowiki></ins><nowiki> );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			for ( var l = 0; l &lt; otherElms.length; l++ ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>			for ( var l = 0; l &lt; otherElms.length; l++ ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>				if ( otherElms[l].id === e.target.id ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>				if ( otherElms[l].id === e.target.id ) {</nowiki>
|-
| class="diff-lineno" | Line 361:
| class="diff-lineno" | Line 365:
|-
| class="diff-context diff-side-deleted" | <nowiki>				if ( backlinks[oElmId] ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>				if ( backlinks[oElmId] ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>					for ( var k in backlinks[oElmId] ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>					for ( var k in backlinks[oElmId] ) {</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>						refresh( backlinks[oElmId][k] );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>						refresh( backlinks[oElmId][k]</nowiki><ins class="diffchange diffchange-inline"><nowiki>, parserOutput</nowiki></ins><nowiki> );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>					}</nowiki>
| class="diff-context diff-side-added" | <nowiki>					}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>				}</nowiki>
| class="diff-context diff-side-added" | <nowiki>				}</nowiki>
|-
| class="diff-lineno" | Line 369:
| class="diff-lineno" | Line 373:
|-
| class="diff-context diff-side-deleted" | <nowiki>	}</nowiki>
| class="diff-context diff-side-added" | <nowiki>	}</nowiki>
|-
| class="diff-context diff-side-deleted" | 
| class="diff-context diff-side-added" | 
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>	var refresh = function (itemId) {</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>	var refresh = function (itemId</nowiki><ins class="diffchange diffchange-inline"><nowiki>, parserOutput</nowiki></ins><nowiki>) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if ( !itemList[itemId] || itemList[itemId] instanceof Null ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if ( !itemList[itemId] || itemList[itemId] instanceof Null ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			// This should not happen.</nowiki>
| class="diff-context diff-side-added" | <nowiki>			// This should not happen.</nowiki>
|-
| class="diff-lineno" | Line 380:
| class="diff-lineno" | Line 384:
|-
| class="diff-context diff-side-deleted" | <nowiki>		}</nowiki>
| class="diff-context diff-side-added" | <nowiki>		}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		inProgressRefresh[itemId] = true;</nowiki>
| class="diff-context diff-side-added" | <nowiki>		inProgressRefresh[itemId] = true;</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>		var res = evaluate( itemList[itemId] );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>		var res = evaluate( itemList[itemId]</nowiki><ins class="diffchange diffchange-inline"><nowiki>, parserOutput</nowiki></ins><nowiki> );</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>		var elm = </nowiki><del class="diffchange diffchange-inline"><nowiki>document</nowiki></del><nowiki>.</nowiki><del class="diffchange diffchange-inline"><nowiki>getElementById</nowiki></del><nowiki>( "calculator-field-" + itemId );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>		var elm = </nowiki><ins class="diffchange diffchange-inline"><nowiki>parserOutput</nowiki></ins><nowiki>.</nowiki><ins class="diffchange diffchange-inline"><nowiki>querySelector</nowiki></ins><nowiki>( "</nowiki><ins class="diffchange diffchange-inline"><nowiki>#</nowiki></ins><nowiki>calculator-field-" + itemId );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		if ( elm.tagName === 'INPUT' ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		if ( elm.tagName === 'INPUT' ) {</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>			elm.value = res;</nowiki>
| class="diff-context diff-side-added" | <nowiki>			elm.value = res;</nowiki>
|-
| class="diff-lineno" | Line 391:
| class="diff-lineno" | Line 395:
|-
| class="diff-context diff-side-deleted" | <nowiki>		}</nowiki>
| class="diff-context diff-side-added" | <nowiki>		}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		for ( var i in backlinks[itemId] ) {</nowiki>
| class="diff-context diff-side-added" | <nowiki>		for ( var i in backlinks[itemId] ) {</nowiki>
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>			refresh( backlinks[itemId][i] );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>			refresh( backlinks[itemId][i]</nowiki><ins class="diffchange diffchange-inline"><nowiki>, parserOutput</nowiki></ins><nowiki> );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>		}</nowiki>
| class="diff-context diff-side-added" | <nowiki>		}</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>	}	</nowiki>
| class="diff-context diff-side-added" | <nowiki>	}	</nowiki>
|-
| class="diff-context diff-side-deleted" | 
| class="diff-context diff-side-added" | 
|-
| class="diff-deletedline diff-side-deleted" | <nowiki>	</nowiki><del class="diffchange diffchange-inline"><nowiki>$</nowiki></del><nowiki>( setup );</nowiki>
| class="diff-addedline diff-side-added" | <nowiki>	</nowiki><ins class="diffchange diffchange-inline"><nowiki>mw.hook( 'wikipage.content' ).add</nowiki></ins><nowiki>( setup );</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>	</nowiki>
| class="diff-context diff-side-added" | <nowiki>	</nowiki>
|-
| class="diff-context diff-side-deleted" | <nowiki>} )();</nowiki>
| class="diff-context diff-side-added" | <nowiki>} )();</nowiki>
|} [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 01:59, 14 September 2024 (UTC) {{small|updated 11:34, 14 September 2024 (UTC)}}
:cc: @[[User:Bawolff|Bawolff]]. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 07:18, 14 September 2024 (UTC)
::Should these sort of changes be made "upstream" during testing? — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 08:15, 14 September 2024 (UTC)
::I'm unsure that would work properly if the wikipage.content hook was fired multiple times during one page view. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 08:51, 14 September 2024 (UTC)
:::{{re|Bawolff}} For what reason do you suspect it might not? And if it doesn't then it should be fixed. Not being able to preview is unacceptable IMO. I tested my patch and it works in live preview, realtime preview, and reply tool. [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 10:25, 14 September 2024 (UTC)
:::Ah, it doesn't work if both live ''and'' realtime preview are used, presumably because elements with the same IDs exist. That could be mitigated by scoping queries to the $content fired by the hook and keeping references to the associated elements, requiring a wrapper element, or including a serial number in the IDs that increases on each hook firing. [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 10:34, 14 September 2024 (UTC)
::::Another technique is to attach a <code>--bound</code> class to the elements that have been processed, and skip them on further runs, c.f. [[mw:MediaWiki:Gadget-site-tpl-copy.js]]. – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 11:01, 14 September 2024 (UTC)
:::::I'm not sure if that would help because IDs are looked up not only when elements are processed but also on interaction.
:::::Come to think of it, probably the simplest solution is to scope the query to the nearest <code>.mw-parser-output</code>. I'll test it and update the patch. [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 11:12, 14 September 2024 (UTC)
::::::I think the best way to do this would be to have the gadget keep references to the actual elements, instead of just their IDs. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 19:34, 15 September 2024 (UTC)
:{{re|Izno}} What is "the answer" here? [[User:Nardog|Nardog]] ([[User talk:Nardog|talk]]) 09:42, 15 September 2024 (UTC)
::My concern from above didn't really get answered - right now this is a test, and I'd expect that improvements are going to get synced in from the external site, clobbering local improvements. Not a showstopper, just something to consider. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 13:31, 15 September 2024 (UTC)
::@[[User:Nardog|Nardog]] You said {{tq|I'll test it and update the patch.}} without posting a further update and only now do I see you did actually work on it. You're free to reactivate if you think it's ready again. That was what I based that off.
::I do also agree with Xaosflux though. [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 16:04, 15 September 2024 (UTC)

{{editprotected|ans=yes}}
Can this be resynced with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js ? The new version should address [[User:Nardog]]'s concerns. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 06:40, 26 September 2024 (UTC)

== NaN ==

@[[User:Bawolff|Bawolff]] Another issue is that NaN shows up in result cells when one or more inputs are blank. Can we make the result blank in such cases? – [[User:SD0001|<span style="font-weight: bold; color: #C30">SD0001</span>]] ([[User talk:SD0001|talk]]) 07:54, 26 September 2024 (UTC)

:This can be worked around by setting a default value for all the cells of 0 (or whatever is appropriate), so they don't start off as blank. Alternatively, the calculator template can take a <code>NaN-text</code> parameter to adjust the text used for not-a-number (The #if in the template code won't let you set it to empty string, although the js should work if you manually made the html. I guess using something like &amp;#32; should work with the current template). [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 09:33, 26 September 2024 (UTC)

== inconsistent sizing on firefox ==

{{editprotected|ans=yes}}
Can this be resynced with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js to fix a bug with inconsistent sizing of number boxes on firefox between different skins. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 03:29, 30 September 2024 (UTC)
:[[user:Xaosflux]] completed this. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 20:29, 9 October 2024 (UTC)

== Live preview ==
{{tracked|T376875}}
It seems like being a "category gadget" breaks live preview, because during live preview, MediaWiki won't recognize the page as being in the right category. I'm not sure if there is any solution to that. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 05:08, 10 October 2024 (UTC)
:Looks like this bug is already reported at [[phab:T376875]]. — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 19:44, 10 October 2024 (UTC)

== Please update to new version ==

{{editrequest|answered=yes}}
Based on feedback (Mostly from [[User:Uwappa]]) there is a new version of this gadget that adds some requested features and fixes some bugs (An issue where sometimes fields are refreshed in the wrong order). Please update this page to the new version from https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js . Thanks [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 06:48, 30 October 2024 (UTC)

:Done for easy debugging:
:* display normally hidden checkboxes WHTR against NICE ranges 0.4 (LT GE), 0.5 (GE), 0.6 (GE)
:* display normally hidden radio buttons, which NICE health level warning to show.
:To see bug:
:- OK height 180 waist 89, one radio button checked
:- NOK height 178, waist 88, no radio button checked
:It looks like 
:* OK radio for NICE level 0.5-0.6 switched off as WHtR drops below .05
:* NOK radio button for NICE level 0.40-0.5 does not switch on as WHtR drops below 0.5. No radio button selected from 4.
:* OK radio button for NICE level 0.40-0.50 does switch on when WHtR drops from 0.49 to 0.48 
:See fields in action at: [[Template:Body_roundness_index/sandbox]]
:Good luck with debugging. [[User:Uwappa|Uwappa]] ([[User talk:Uwappa|talk]]) 07:15, 30 October 2024 (UTC)
::{{ping|Uwappa}} If you want to test the new version of the gadget, i was using https://mdwiki.org/wiki/User:Bawolff/sandbox2 as a test page (I didn't copy over the css since that is not really needed to test this). I believe the new version fixes the issue you mentioned. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 07:28, 30 October 2024 (UTC)
:::No, thanks, If you say it's a fixed bug than I just trust that, won't bother to redo your work.
:::Thank you! [[User:Uwappa|Uwappa]] ([[User talk:Uwappa|talk]]) 07:33, 30 October 2024 (UTC)
:::: {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 16:18, 9 November 2024 (UTC)
:::::What does 'done' mean?
:::::I can't recreate the bug any more, so the fix is live?
:::::So body roundness calculator version 4 can go live soon as well, escape the sandbox??? [[User:Uwappa|Uwappa]] ([[User talk:Uwappa|talk]]) 17:43, 9 November 2024 (UTC)
::::::It means the script is updated, so the bug should  no longer be present. If you encounter any more bugs, let me know. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 11:59, 11 November 2024 (UTC)
:::::::This is probably a Calculator bug as well:
:::::::- OK default height 180, waist 81, WHtR 0.45
:::::::- kind of OK height down to 79-> waist down to 80, WHtR down to 0.44692737430167595
:::::::(preferred: WHtR remains 4.5, just waist updated)
:::::::- NOK: height back up to 180->, WHtR 0.4444444444444444 (kind of OK), but waist not updated?
:::::::What I tried to do
:::::::- if new height, new waist, same WHtR
:::::::- if new waist, new WHtR, height unchanged
:::::::- if new WHtR, new waist, height unchanged [[User:Uwappa|Uwappa]] ([[User talk:Uwappa|talk]]) 15:03, 11 November 2024 (UTC)
::::::::I think its just refusing to update waist because it detects a loop is happening since waist and whtr both mutually depend on each other. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 18:20, 11 November 2024 (UTC)
:::::::::Yes, I've been on that train of thought.
:::::::::But why the f*** is there a difference between:
:::::::::* height from 179 to 180
:::::::::* height from 180 to 179
:::::::::[[File:SMirC-what.svg|x50px]] [[User:Uwappa|Uwappa]] ([[User talk:Uwappa|talk]]) 19:25, 11 November 2024 (UTC)

== request to resync script ==

{{editprotected|answered=yes}}
Sorry, I realize I asked for an update not that long ago. There was recently some discussion about potentially using this gadget to make step-by-step interactive math proofs (e.g. [[User:Dimitris131/sandbox]], [[User:Bawolff/math steps]]). It turns out that is possible with the current version of the gadget, however the resulting HTML doesn't follow accessibility best practices. Anyways, the new version from [https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js mdwiki] supports making buttons with the proper HTML that should be accessible (Along with some unrelated minor fixes). Any chance we could get this gadget resynced with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js ? [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 18:35, 12 November 2024 (UTC)
: {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 01:41, 13 November 2024 (UTC)

== Request to resync ==

{{editprotected|answered=yes}}
Please resync this with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js  . New version has some small bug fixes and accessibility improvements. Thanks [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 18:13, 20 November 2024 (UTC)
: {{done}} [[User:Pppery|* Pppery *]] [[User talk:Pppery|<sub style="color:#800000">it has begun...</sub>]] 04:46, 21 November 2024 (UTC)

== Resync request ==

{{Editprotected|answered=yes}}
Please resync this with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js . The primary change is a fix for an off-by-1 error in processing the round() function in formulas. It also has some minor improvements for integrating with virtual keyboards on mobile phones, a new switch() function in formulas, improved error messages in formulas and allowing buttons to update multiple fields at once. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 02:13, 3 January 2025 (UTC)
:{{done}} — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 11:08, 3 January 2025 (UTC)

== Resync request ==

{{editprotected|answered=yes}}
Please resync with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 19:00, 27 January 2025 (UTC)
:{{done}} — [[User:Xaosflux|<span style="color:#FF9933; font-weight:bold; font-family:monotype;">xaosflux</span>]] <sup>[[User talk:Xaosflux|<span style="color:#009933;">Talk</span>]]</sup> 19:38, 27 January 2025 (UTC)

== Resync request ==
{{editprotected|answered=yes}}
Apologies for asking again so soon. I realized the most recent version had a bug in it. Do you mind resyncing with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js again? Thanks. [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 15:33, 28 January 2025 (UTC)

:For future reference, can you provide a summary of the bug onwiki :) [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 16:35, 28 January 2025 (UTC)
::So there were a couple things, mostly fairly minor:
::* I mixed up arithmetic and logical shift because I am silly - [https://mdwiki.org/w/index.php?title=MediaWiki:Gadget-calculator.js&diff=prev&oldid=1447689]
::* There was a triple === comparison to the number 1, but the other side was a string, so the comparison was failing, which caused the disable option for buttons not to work if you specified it as "1" instead of "true". [https://mdwiki.org/w/index.php?title=MediaWiki:Gadget-calculator.js&diff=prev&oldid=1447807]
::* Some of the event handling code was using event.target instead of event.currentTarget. Normally this is fine, but if the html was nested, this could lead to the code thinking the event was for the wrong target [https://mdwiki.org/w/index.php?title=MediaWiki:Gadget-calculator.js&diff=prev&oldid=1447802].
::Since the last sync, there was also added a small new feature - the "until" feature. This is meant to support usecases where you want a button to do something until a certain point is reached. This was meant to support some of the experiments being done with chessboard displays (e.g. [[Module:Sandbox/Bawolff/Chessboard]]) [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 16:57, 28 January 2025 (UTC)
:{{done}}<!-- Template:ESp --> [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 22:14, 28 January 2025 (UTC)

== resync request ==
{{editprotected|answered=yes}}
Could i have another resync with https://mdwiki.org/wiki/MediaWiki:Gadget-calculator.js please?

The main changes is support for formatting numeric fields without affecting the field value [https://en.wikipedia.org/wiki/Template_talk:Calculator#Decimals_parameter_for_number_fields? as requested here] and handling duplicated label ids better [https://en.wikipedia.org/w/index.php?title=Talk:Four-dimensional_space&oldid=1272916035#Bug_in_switcher as requested here] [[User:Bawolff|Bawolff]] ([[User talk:Bawolff|talk]]) 04:51, 8 February 2025 (UTC)
:{{done}}<!-- Template:ESp --> [[User:Sohom Datta|<b class="skin-invert" style="color:#795cb2; display: inline-block; transform: rotate(1deg)">Sohom</b>]] ([[User talk:Sohom Datta|<span class="skin-invert" style="color: #36c;">talk</span>]]) 08:09, 8 February 2025 (UTC)