This is an archive of past discussions about Module:WikiProject banner. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page.
How does your code interact with the exists check in lines 409-413 and 620-624? By the way, the bot should now be actively moving these categories, so it should all be sorted in a few days, so we could just wait? — Martin (MSGJ · talk) 10:57, 17 December 2024 (UTC)
The moving of the categories seems to have stalled at CfD, so we should probably fix this. Can you see if your code can be simplified so we don't check categories exist multiple times? By the way, it's great to have another Lua editor to help out — Martin (MSGJ · talk) 22:14, 17 December 2024 (UTC)
Yeah, the duplicated expensive function calls are bugging me too. I've reworked the function so it stores "which suffix worked" in a variable, and I've added a case before both exists-checks you mentioned so they'll use that variable instead if it's non-nil. That leaves at most three exists-checks per category (except maybe an edge case for FM); does this look good? jlwoodwa (talk) 00:12, 18 December 2024 (UTC)
Done — Martin (MSGJ · talk) 10:44, 18 December 2024 (UTC)